From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: Re: [PATCH 3/3] staging: r8188eu: don't accept SIGTERM for cmd thread
Date: Sun, 17 Oct 2021 16:47:04 +0200 [thread overview]
Message-ID: <1638491.UCx7rxsUkF@localhost.localdomain> (raw)
In-Reply-To: <20211016181343.3686-4-martin@kaiser.cx>
On Saturday, October 16, 2021 8:13:43 PM CEST Martin Kaiser wrote:
> At the moment, our command thread can be killed by user space.
>
> [root@host ]# kill `pidof RTW_CMD_THREAD`
>
> The driver will then stop working until the module is unloaded
> and reloaded.
>
> Don't process SIGTERM in the command thread. Other drivers that have a
> command thread don't process SIGTERM either.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 2 --
> drivers/staging/r8188eu/include/osdep_service.h | 5 -----
> 2 files changed, 7 deletions(-)
Dear Martin,
After thinking a little more about this topic, now I'm ready for...
Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Regards,
Fabio
prev parent reply other threads:[~2021-10-17 14:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 18:13 [PATCH 0/3] staging: r8188eu: clean up osdep_service.h Martin Kaiser
2021-10-16 18:13 ` [PATCH 1/3] staging: r8188eu: res_to_status is unused Martin Kaiser
2021-10-16 18:54 ` Fabio M. De Francesco
2021-10-17 12:46 ` Michael Straube
2021-10-16 18:13 ` [PATCH 2/3] staging: r8188eu: daemonize is not defined Martin Kaiser
2021-10-16 18:59 ` Fabio M. De Francesco
2021-10-17 12:48 ` Michael Straube
2021-10-16 18:13 ` [PATCH 3/3] staging: r8188eu: don't accept SIGTERM for cmd thread Martin Kaiser
2021-10-16 18:53 ` Fabio M. De Francesco
2021-10-17 10:29 ` Phillip Potter
2021-10-17 12:51 ` Fabio M. De Francesco
2021-10-17 14:13 ` Fabio M. De Francesco
2021-10-17 18:02 ` Martin Kaiser
2021-10-17 20:12 ` Phillip Potter
2021-10-17 13:14 ` Fabio M. De Francesco
2021-10-17 14:11 ` Fabio M. De Francesco
2021-10-17 13:19 ` Fabio M. De Francesco
2021-10-17 14:47 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638491.UCx7rxsUkF@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.