From: Rob Herring <robh@kernel.org>
To: Jarrett Schultz <jaschultzms@gmail.com>
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
platform-driver-x86@vger.kernel.org, devicetree@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, Mark Gross <markgross@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH 1/5] dt-bindings: platform: microsoft: Document surface xbl
Date: Fri, 03 Dec 2021 17:34:15 -0600 [thread overview]
Message-ID: <1638574455.193372.1042997.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211202191630.12450-2-jaschultz@microsoft.com>
On Thu, 02 Dec 2021 11:16:26 -0800, Jarrett Schultz wrote:
> Introduce yaml for surface xbl driver.
>
> Signed-off-by: Jarrett Schultz <jaschultz@microsoft.com>
>
> ---
>
> Changes in v3:
> - Updated description to only pertain to the hardware
> - Updated the required field to properly reflect the binding
> - Removed the first example
> - Fixed the size of the reg field in the second example
>
> ---
>
> Changes in v2:
> - Removed json-schema dependence
> - Elaborated on description of driver
> - Updated example
> ---
> .../platform/microsoft/surface-xbl.yaml | 69 +++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml: properties:properties: 'compatible' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml: properties: 'properties' should not be valid under {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']}
hint: A json-schema keyword was found instead of a DT property name.
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml: ignoring, error in schema: properties: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
Documentation/devicetree/bindings/platform/microsoft/surface-xbl.example.dt.yaml:0:0: /example-0/imem@146bf000/xbl@a94: failed to match any schema with compatible: ['microsoft,sm8150-surface-duo-xbl']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1562961
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-12-03 23:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 19:16 [PATCH v2 0/5] platform: surface: Introduce Surface XBL Driver Jarrett Schultz
2021-12-02 19:16 ` [PATCH 1/5] dt-bindings: platform: microsoft: Document surface xbl Jarrett Schultz
2021-12-02 20:04 ` Trilok Soni
2021-12-03 23:34 ` Rob Herring [this message]
2021-12-02 19:16 ` [PATCH 2/5] platform: surface: Propagate ACPI Dependency Jarrett Schultz
2021-12-03 9:59 ` Hans de Goede
2021-12-03 17:34 ` [EXTERNAL] " Jarrett Schultz
2021-12-06 21:40 ` Hans de Goede
2022-01-12 7:39 ` Geert Uytterhoeven
2022-01-14 6:20 ` Felipe Balbi
2022-01-14 8:29 ` Geert Uytterhoeven
2022-01-14 8:31 ` Hans de Goede
2022-01-14 8:37 ` Felipe Balbi
2022-01-14 17:11 ` [EXTERNAL] " Jarrett Schultz
2021-12-02 19:16 ` [PATCH 3/5] platform: surface: Add surface xbl Jarrett Schultz
2021-12-02 19:16 ` [PATCH 4/5] arm64: dts: qcom: sm8150: Add imem section Jarrett Schultz
2021-12-02 19:16 ` [PATCH 5/5] arm64: dts: qcom: surface-duo: Add surface xbl Jarrett Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638574455.193372.1042997.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jaschultz@microsoft.com \
--cc=jaschultzms@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.