From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3DEFC433F5 for ; Fri, 3 Dec 2021 23:37:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 07A9B253B; Sat, 4 Dec 2021 00:36:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 07A9B253B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638574626; bh=0dHj4n5AvvSs6deeTAdsmALBRYJT3t7ILevipSepM7E=; h=From:To:In-Reply-To:References:Subject:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=unva1GKfAyRl0X19zSj6RzIJk1pAh+WCmK8OPmetgruw1LtA6Kw0y/jw0X46I6/0r so8l6RFolC8NmiaGUc3SpJpDRc4lt8EFgnv/hMN9rz4FAte9PSzMuZmwyAbMJqSkd3 Iogu4DMWnM07v1wLCILQ4S7JpM17VaAEpjtc4V3I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EE355F804FF; Sat, 4 Dec 2021 00:34:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CA3C7F80506; Sat, 4 Dec 2021 00:34:39 +0100 (CET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BBC8EF800A7 for ; Sat, 4 Dec 2021 00:34:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BBC8EF800A7 Received: by mail-oi1-f172.google.com with SMTP id bf8so8817813oib.6 for ; Fri, 03 Dec 2021 15:34:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=eoZz1/dE2uVxxnzNEe6cyt2XRJa+hiTl6N5jptXjP3M=; b=fkIA+9sp3nRqMp6I3mZdk2zrGd8azkFNyM7Htf8pPouuvp6Jp57fBecIpQtWQeJ5op iiDbNnIdCh8KY684uvjRtEf97KhXVKnYBzSNkjoDDqpayLKfidDDBN6kk036tBy5uqfm Ujy3kCraff4tyfIfnZ3ouwWgZdidmzjW4fRVhV0LzdMJgbez3CrDtcT8sGyuOYmiUuwb Bp0SRpQFofEmqhU6kteQKh49iMzk2UjjGBO1wBHTKB0zMVL+zrQU1LOBmNM/1Ybyo1Bs dw0yp7Ime/IahgD4i8PIcXDGDL7wy99cAAJjnRpOXh4pvZ3d2hKm3TT6mdlA3O/X9nGQ L6Pg== X-Gm-Message-State: AOAM531mj2sGel3a11m09J5GHgq+zcb9wJlO6qrKwXfg+tVTVbfypZq1 WJdqx/6J3AxvCMRzksttEA== X-Google-Smtp-Source: ABdhPJwDbeAXVAQZ2vLphcIxOo4mkEU5tjYPEpZZO3smEEfXMEv5SE51yep6JOTtmec1IaaZujuNXA== X-Received: by 2002:a05:6808:23cb:: with SMTP id bq11mr12281951oib.2.1638574471549; Fri, 03 Dec 2021 15:34:31 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id k16sm877919otp.21.2021.12.03.15.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 15:34:31 -0800 (PST) Received: (nullmailer pid 1043015 invoked by uid 1000); Fri, 03 Dec 2021 23:34:15 -0000 From: Rob Herring To: Jayesh Choudhary In-Reply-To: <20211203120243.24173-1-j-choudhary@ti.com> References: <20211203120243.24173-1-j-choudhary@ti.com> Subject: Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Fri, 03 Dec 2021 17:34:15 -0600 Message-Id: <1638574455.292522.1043014.nullmailer@robh.at.kernel.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, peter.ujfalusi@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 03 Dec 2021 17:32:43 +0530, Jayesh Choudhary wrote: > Convert the bindings for McASP controllers for TI SOCs from txt > to YAML schema. > > Adds additional properties 'clocks', 'clock-names', 'power-domains', > '#sound-dai-cells' and 'port' which were missing from txt file. > Removes properties 'sram-size-playback' and 'sram-size-capture' > since they are not used. > Adds 'dmas' and 'dma-names' in the example which were missing from > the txt file. > Changes 'interrupts' and 'interrupt-names' from optional to > required properties. > Changes 'op-mode', 'serial-dir' and 'tdm-slots' to optional properties > as they are not needed if the McASP is used only as GPIO. > > Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS > INSTRUMENTS ASoC DRIVERS' > > Signed-off-by: Jayesh Choudhary > --- > Changelog: > v4: > - changes the commit message > - adds type and description to relevant properties > - changes maxItems for 'serial-dir' > - removes properties 'sram-size-playback' and 'sram-size-capture' > as they are not used > - removes 'function-gpios' > - removes 'num-serializer' > - marks 'tdm-slots', 'serial-dir' and 'op-mode' as optional properties > - adds the yaml file in MAINTAINERS > > v3: > - removes maxItems from 'clock-names' > > v2: > - changes the commit message > - modifies the properties 'clocks', 'clock-names', 'dma-names', > 'dmas', 'interrupts' and 'interrupt-names' according to the > arm SOCs > - adds 'ports' and 'num-serializer' as node properties > > .../bindings/sound/davinci-mcasp-audio.txt | 86 -------- > .../bindings/sound/davinci-mcasp-audio.yaml | 185 ++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 186 insertions(+), 86 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1563206 mcasp@0: 'num-serializer' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/am335x-cm-t335.dt.yaml arch/arm/boot/dts/am335x-sbc-t335.dt.yaml mcasp@0: 'rt-num-evt' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/am335x-wega-rdk.dt.yaml From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B341C433F5 for ; Fri, 3 Dec 2021 23:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383517AbhLCXiB (ORCPT ); Fri, 3 Dec 2021 18:38:01 -0500 Received: from mail-oi1-f181.google.com ([209.85.167.181]:42653 "EHLO mail-oi1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383542AbhLCXh4 (ORCPT ); Fri, 3 Dec 2021 18:37:56 -0500 Received: by mail-oi1-f181.google.com with SMTP id n66so8743252oia.9; Fri, 03 Dec 2021 15:34:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=eoZz1/dE2uVxxnzNEe6cyt2XRJa+hiTl6N5jptXjP3M=; b=qayHWLvM2KIiHe/I3+K/oerdt+5asL6KRusXS4FjOv2KVVT4akFoCd4M4TjNDi4GBF LdS924BRMOo0KxoSAZilcRLGPsREcuGNZy3SRrVVf4i3ooFE2EdiKaYfLo9Z1QpWFfwx fiyyjzjA0JsRy9pIe1KYFWjaIkE4ML+WMO9QCTKLBcWopW/1WgX+Hoy0xMcSwRyB0M8p tgn/U7gkqBeg4g6TM1xEL6Yf40ToIlbWZfFVS27S5Yquh6XKCQcQVNloodcJcX/+fd9X g+SFPKY7ebJgmIonoFBjLKeQgYuafpBDzypWVLk8OuIieHPIyb/WoUiaCwOfpg7E0O6Y XjSw== X-Gm-Message-State: AOAM532Mb6Ezk/S+KuCjtJwXJ7sXD+snDk3UI6kFCAwp/olWxpMGMVnm RMCK9pGx+3ve2hhrYei7TA== X-Google-Smtp-Source: ABdhPJwDbeAXVAQZ2vLphcIxOo4mkEU5tjYPEpZZO3smEEfXMEv5SE51yep6JOTtmec1IaaZujuNXA== X-Received: by 2002:a05:6808:23cb:: with SMTP id bq11mr12281951oib.2.1638574471549; Fri, 03 Dec 2021 15:34:31 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id k16sm877919otp.21.2021.12.03.15.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 15:34:31 -0800 (PST) Received: (nullmailer pid 1043015 invoked by uid 1000); Fri, 03 Dec 2021 23:34:15 -0000 From: Rob Herring To: Jayesh Choudhary Cc: lgirdwood@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, devicetree@vger.kernel.org, peter.ujfalusi@gmail.com, linux-kernel@vger.kernel.org In-Reply-To: <20211203120243.24173-1-j-choudhary@ti.com> References: <20211203120243.24173-1-j-choudhary@ti.com> Subject: Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Fri, 03 Dec 2021 17:34:15 -0600 Message-Id: <1638574455.292522.1043014.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 03 Dec 2021 17:32:43 +0530, Jayesh Choudhary wrote: > Convert the bindings for McASP controllers for TI SOCs from txt > to YAML schema. > > Adds additional properties 'clocks', 'clock-names', 'power-domains', > '#sound-dai-cells' and 'port' which were missing from txt file. > Removes properties 'sram-size-playback' and 'sram-size-capture' > since they are not used. > Adds 'dmas' and 'dma-names' in the example which were missing from > the txt file. > Changes 'interrupts' and 'interrupt-names' from optional to > required properties. > Changes 'op-mode', 'serial-dir' and 'tdm-slots' to optional properties > as they are not needed if the McASP is used only as GPIO. > > Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS > INSTRUMENTS ASoC DRIVERS' > > Signed-off-by: Jayesh Choudhary > --- > Changelog: > v4: > - changes the commit message > - adds type and description to relevant properties > - changes maxItems for 'serial-dir' > - removes properties 'sram-size-playback' and 'sram-size-capture' > as they are not used > - removes 'function-gpios' > - removes 'num-serializer' > - marks 'tdm-slots', 'serial-dir' and 'op-mode' as optional properties > - adds the yaml file in MAINTAINERS > > v3: > - removes maxItems from 'clock-names' > > v2: > - changes the commit message > - modifies the properties 'clocks', 'clock-names', 'dma-names', > 'dmas', 'interrupts' and 'interrupt-names' according to the > arm SOCs > - adds 'ports' and 'num-serializer' as node properties > > .../bindings/sound/davinci-mcasp-audio.txt | 86 -------- > .../bindings/sound/davinci-mcasp-audio.yaml | 185 ++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 186 insertions(+), 86 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1563206 mcasp@0: 'num-serializer' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/am335x-cm-t335.dt.yaml arch/arm/boot/dts/am335x-sbc-t335.dt.yaml mcasp@0: 'rt-num-evt' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/am335x-wega-rdk.dt.yaml