From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 07/32] net/qede: fix 32 bit compilation
Date: Wed, 26 Oct 2016 18:54:04 +0200
Message-ID: <1638805.EFUnSErrGQ@xps13>
References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com>
 <1476850306-2141-8-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, ferruh.yigit@intel.com
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 347D7BD5B
 for <dev@dpdk.org>; Wed, 26 Oct 2016 18:54:09 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id 140so27621591wmv.0
 for <dev@dpdk.org>; Wed, 26 Oct 2016 09:54:09 -0700 (PDT)
In-Reply-To: <1476850306-2141-8-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-18 21:11, Rasesh Mody:
> Fix 32 bit compilation for gcc version 4.3.4.
> 
> Fixes: ec94dbc57362 ("qede: add base driver")
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
[...]
>  ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> +ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  CFLAGS_BASE_DRIVER += -Wno-missing-declarations
> +ifeq ($(shell gcc -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0)
>  CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
> +endif
>  CFLAGS_BASE_DRIVER += -Wno-strict-prototypes
>  ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-shift-negative-value

What the hell are you doing here?
1/ You should better fix "unused-but-set-variable" errors
2/ It won't work when cross-compiling because you do not use $(CC)
	in $(shell gcc

I really do not want to look at the qede patches.
But each time my eyes stop on one of them, I'm struggling.