From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
Marcel Apfelbaum <marcel@redhat.com>,
idan brown <idan.brown@ravellosystems.com>,
Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property
Date: Mon, 14 Dec 2015 12:28:50 -0500 (EST) [thread overview]
Message-ID: <163895392.40236889.1450114130220.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20151214190935-mutt-send-email-mst@redhat.com>
> Well qapi/qmp docs say things like:
>
> Any name (command, event, type, field, or enum value) beginning with
> "x-" is marked experimental, and may be withdrawn or changed
> incompatibly in a future release.
>
> It's thus reasonable to use this for internal properties,
> that we don't want users to play with.
What distinguishes an internal from an external property? Everything
except links to backends would be "internal".
We've used a much more restrictive definition so far than that---basically
known-broken or debugging-only---and I think it's more appropriate.
> BTW, we probably should teach -help to hide these options by default.
Please, no obscuring of functionality. Debugging-only functionality
definitely belongs in -help.
Paolo
next prev parent reply other threads:[~2015-12-14 17:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 8:08 [Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities Shmulik Ladkani
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 1/6] vmw_pvscsi: Set device subsystem and revision Shmulik Ladkani
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 2/6] vmw_pvscsi: Change offset of msi pci capability Shmulik Ladkani
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 3/6] vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property Shmulik Ladkani
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 4/6] vmw_pvscsi: coding: Introduce PVSCSIClass Shmulik Ladkani
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint Shmulik Ladkani
2015-12-14 17:14 ` Paolo Bonzini
2015-12-14 17:31 ` Shmulik Ladkani
2015-12-14 17:37 ` Michael S. Tsirkin
2015-12-14 18:05 ` Paolo Bonzini
2015-12-14 21:01 ` Shmulik Ladkani
2015-12-14 21:10 ` Michael S. Tsirkin
2015-12-15 5:48 ` Shmulik Ladkani
2015-12-14 18:25 ` Marcel Apfelbaum
2015-12-13 8:08 ` [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property Shmulik Ladkani
2015-12-14 17:07 ` Paolo Bonzini
2015-12-14 17:12 ` Michael S. Tsirkin
2015-12-14 17:28 ` Paolo Bonzini [this message]
2015-12-14 17:35 ` Michael S. Tsirkin
2015-12-14 18:04 ` Paolo Bonzini
2015-12-14 18:26 ` Michael S. Tsirkin
2015-12-15 8:13 ` Shmulik Ladkani
2015-12-13 8:24 ` [Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163895392.40236889.1450114130220.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmitry@daynix.com \
--cc=idan.brown@ravellosystems.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.