From: Rob Herring <robh@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, swboyd@chromium.org,
andy.shevchenko@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, jic23@kernel.org
Subject: Re: [PATCH v6 4/5] dt-bindings: iio: Add sx9324 binding
Date: Wed, 08 Dec 2021 21:08:51 -0600 [thread overview]
Message-ID: <1639019331.997945.934414.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211209005806.3575399-5-gwendal@chromium.org>
On Wed, 08 Dec 2021 16:58:05 -0800, Gwendal Grignou wrote:
> Similar to SX9310, add biddings to setup sx9324 hardware properties.
> SX9324 is a little different, introduce 4 phases to be configured in 2
> pairs over 3 antennas.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes in v6:
> - Fix syntax errors in device tree binding documentation.
> - Run 'make dt_binding_check' to make fix errors.
>
> Changes in v5:
> - Use consistent field naming, prefixed with phX.
>
> Changes in v4:
> - Use const instead of single enum
> - Specify ph0-pin better
> - Recopy type information for phX-pin
> - Fix cut and paste errors.
>
> Changes in v3:
> - Remove duplicate information.
> - Use intervals instead of enum.
> - Fix filter description.
>
> Changes in v2:
> - Fix interrupt documentation wording.
>
> .../iio/proximity/semtech,sx9324.yaml | 161 ++++++++++++++++++
> 1 file changed, 161 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.example.dt.yaml: proximity@28: semtech,ph01-resolution:0:0: 2 is not one of [8, 16, 32, 64, 128, 256, 512, 1024]
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.example.dt.yaml: proximity@28: semtech,ph23-resolution:0:0: 2 is not one of [8, 16, 32, 64, 128, 256, 512, 1024]
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1565557
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-12-09 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 0:58 [PATCH v6 0/5] Expand Semtech SAR Sensors support Gwendal Grignou
2021-12-09 0:58 ` [PATCH v6 1/5] iio: sx9310: Add frequency in read_avail Gwendal Grignou
2021-12-09 0:58 ` [PATCH v6 2/5] iio: sx9310: Extract common Semtech sensor logic Gwendal Grignou
2021-12-09 0:58 ` [PATCH v6 3/5] iio: proximity: Add SX9324 support Gwendal Grignou
2021-12-09 0:58 ` [PATCH v6 4/5] dt-bindings: iio: Add sx9324 binding Gwendal Grignou
2021-12-09 3:08 ` Rob Herring [this message]
2021-12-09 0:58 ` [PATCH v6 5/5] iio: sx9324: Add dt_binding support Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639019331.997945.934414.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.