All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Yauheni Kaliuta <ykaliuta@redhat.com>
Cc: bpf <bpf@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: PPC jit and pseudo_btf_id
Date: Wed, 15 Dec 2021 20:18:13 +0530	[thread overview]
Message-ID: <1639577374.grloptq1hq.naveen@linux.ibm.com> (raw)
In-Reply-To: <CANoWswkVLUDzwivbkiJ28LKo8F2YZJ4sRR=76NNcYwpdncquwA@mail.gmail.com>

Yauheni Kaliuta wrote:
>> Can you please check if the below patch fixes the issue for you?
> 
> It does, thanks!
> 
> I was actually thinking later about something similar and I wonder
> about naming. Should the function be renamed to more generic, and is
> it really for func_addr only or can be any generic value?

Good point. Looking at jit_subprogs(), it looks like the extra pass 
fixes up addresses of subprog calls, as well as that of other bpf 
functions.  So, I agree that it makes sense to change the function name.  
func_addr looks to still be correct though.

Thanks for testing this. I will update this patch and post it along with 
a few other fixes.


Regards,
Naveen


      reply	other threads:[~2021-12-15 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 22:37 PPC jit and pseudo_btf_id Yauheni Kaliuta
2021-12-14 12:09 ` Naveen N. Rao
2021-12-14 12:46   ` Yauheni Kaliuta
2021-12-15 14:48     ` Naveen N. Rao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1639577374.grloptq1hq.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=jolsa@redhat.com \
    --cc=ykaliuta@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.