From: Rob Herring <robh@kernel.org>
To: Alexandre Ghiti <alexandre.ghiti@canonical.com>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-rtc@vger.kernel.org, linux-input@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Support Opensource <support.opensource@diasemi.com>,
Mark Brown <broonie@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 2/2] dt-bindings: Migrate DA9063 text bindings to YAML
Date: Thu, 16 Dec 2021 21:47:33 -0600 [thread overview]
Message-ID: <1639712853.383823.1677945.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211216164037.2888316-2-alexandre.ghiti@canonical.com>
On Thu, 16 Dec 2021 17:40:37 +0100, Alexandre Ghiti wrote:
> DA9063 devices bindings used text format, so migrate those bindings to YAML
> format before adding any new bindings.
>
> Signed-off-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>
> ---
>
> Changes in v2:
> - Fix all errors detected with make dt_binding_checks
>
> .../bindings/input/da9063-onkey.yaml | 39 ++++++
> .../devicetree/bindings/mfd/da9063.txt | 111 ------------------
> .../devicetree/bindings/mfd/da9063.yaml | 105 +++++++++++++++++
> .../bindings/regulator/da9063-regulator.yaml | 51 ++++++++
> .../devicetree/bindings/rtc/da9063-rtc.yaml | 31 +++++
> .../bindings/watchdog/da9063-watchdog.yaml | 31 +++++
> 6 files changed, 257 insertions(+), 111 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/da9063-onkey.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
> create mode 100644 Documentation/devicetree/bindings/regulator/da9063-regulator.yaml
> create mode 100644 Documentation/devicetree/bindings/rtc/da9063-rtc.yaml
> create mode 100644 Documentation/devicetree/bindings/watchdog/da9063-watchdog.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: 'interrupt-controller', 'onkey', 'regulators', 'rtc', 'wdt' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/trivial-devices.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: regulators: 'compatible' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: regulators: 'bcore1', 'ldo11' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: 'wdt' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml
doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/input/da9062-onkey.txt: Documentation/devicetree/bindings/mfd/da9063.txt
See https://patchwork.ozlabs.org/patch/1569315
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-12-17 3:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:40 [PATCH v2 1/2] dt-bindings: mfd: Fix typo "DA9093" -> "DA9063" Alexandre Ghiti
2021-12-16 16:40 ` [PATCH v2 2/2] dt-bindings: Migrate DA9063 text bindings to YAML Alexandre Ghiti
2021-12-16 16:49 ` Mark Brown
2021-12-17 3:47 ` Rob Herring [this message]
2021-12-21 17:00 ` [PATCH v2 1/2] dt-bindings: mfd: Fix typo "DA9093" -> "DA9063" Rob Herring
2021-12-29 15:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639712853.383823.1677945.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.ghiti@canonical.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.