From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@nvidia.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] eal: save error in string copy
Date: Sat, 12 Jun 2021 10:34:52 +0200 [thread overview]
Message-ID: <16401109.pIj2lYa0bN@thomas> (raw)
In-Reply-To: <20210611224907.1904-1-xuemingl@nvidia.com>
12/06/2021 00:49, Xueming Li:
> From: Thomas Monjalon <thomas@monjalon.net>
>
> Sets rte_errrno if the destination buffer is too small.
Would be good to mention the function name,
and the reason for the change.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
You did half of the patch, so you should add your Signed-off.
> ---
> lib/eal/common/eal_common_string_fns.c | 4 +++-
> lib/eal/common/eal_common_trace.c | 1 -
> lib/eal/include/rte_string_fns.h | 5 ++---
> lib/graph/node.c | 12 +++---------
> 4 files changed, 8 insertions(+), 14 deletions(-)
Did you check all occurences of rte_strcpy?
next prev parent reply other threads:[~2021-06-12 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 22:49 [dpdk-dev] [PATCH] eal: save error in string copy Xueming Li
2021-06-12 8:34 ` Thomas Monjalon [this message]
2021-06-12 23:06 ` Xueming(Steven) Li
2021-06-12 23:05 ` [dpdk-dev] [v1] " Xueming Li
2021-06-13 8:24 ` [dpdk-dev] [PATCH v2] " Xueming Li
2021-07-05 10:05 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16401109.pIj2lYa0bN@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.