From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH V4 1/9] bus: introduce hotplug failure handler Date: Thu, 05 Jul 2018 10:30:36 +0200 Message-ID: <1640513.v5es5KfRRd@xps> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <2407710.IcmoihaDi7@xps> <2f9bb7bb-0647-5601-7e1f-1eba44890843@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com To: "Guo, Jia" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B26DE8DA6 for ; Thu, 5 Jul 2018 10:30:40 +0200 (CEST) In-Reply-To: <2f9bb7bb-0647-5601-7e1f-1eba44890843@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2018 08:23, Guo, Jia: > > On 7/4/2018 3:55 PM, Thomas Monjalon wrote: > > 04/07/2018 09:16, Guo, Jia: > >> On 7/4/2018 6:21 AM, Thomas Monjalon wrote: > >>> 29/06/2018 12:30, Jeff Guo: > >>>> /** > >>>> + * Implementation a specific hot plug handler, which is responsible > >>>> + * for handle the failure when hot remove the device, guaranty the system > >>>> + * would not crash in the case. > >>>> + * @param dev > >>>> + * Pointer of the device structure. > >>>> + * > >>>> + * @return > >>>> + * 0 on success. > >>>> + * !0 on error. > >>>> + */ > >>>> +typedef int (*rte_bus_hotplug_handler_t)(struct rte_device *dev); > >>> [...] > >>>> @@ -211,6 +224,8 @@ struct rte_bus { > >>>> rte_bus_parse_t parse; /**< Parse a device name */ > >>>> struct rte_bus_conf conf; /**< Bus configuration */ > >>>> rte_bus_get_iommu_class_t get_iommu_class; /**< Get iommu class */ > >>>> + rte_bus_hotplug_handler_t hotplug_handler; > >>>> + /**< handle hot plug on bus */ > >>> The name is misleading. > >>> It is to handle unplugging but is called "hotplug". > >> ok, so i prefer hotplug_failure_handler than hot_unplug_handler, since > >> it is more explicit for failure handle, and more clearly. > >> > >>> In order to demonstrate how the handler is used, you should > >>> introduce the code using this handler in the same patch. > >>> > >> sorry, i check the history of rte_bus.h, and the way is introduce ops at > >> first, second implement in specific bus, then come across the usage. > >> I think that way clear and make sense. what do you think? > >> Anyway, i will check the commit log if is there any misleading. > > I think it is better to call ops when they are introduced, > > and implement the ops in second step. > > > > Hi, Thomas > > sorry but i want to detail the relationship of the ops and api as bellow > to try if we can get the better sequence. > > Patch num: > > 1: introduce ops hotplug_failure_handler > > 2: implement ops hotplug_failure_handler > > 3:introduce ops sigbus_handler. > > 4:implement ops sigbus_handler > > 5: introduce helper rte_bus_sigbus_handler to call the ops sigbus_handler > > 6: introduce the mechanism to call helper rte_bus_sigbus_handler and > call hotplug_failure_handler. > > If per you said , could I modify the sequence like 6->5->3->4->1->2? I > don't think it will make sense, and might be more confused. > > And I think should be better that introduce each ops just say item, then > when introduce the caller patch, the functional is ready to use by the > patch. > > > if i did not got your point and you have other better sequence about > that please explicit to let me know. Thanks. The main concern is to be able to understand each patch separately. When introducing a new op, we need to understand how it will be used. But actually, no need to change patch organization, you just need to provide a clear doxygen documentation, and introduce the context in the commit log.