From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: CMD7:MMC_CMD_SELECT_CARD response fix
Date: Tue, 11 Oct 2011 15:21:58 +0530 (IST) [thread overview]
Message-ID: <1641063460.195195.1318326718941.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <1317820403-27846-1-git-send-email-ajay.bhargav@einfochips.com>
----- "Ajay Bhargav" <ajay.bhargav@einfochips.com> wrote:
> As per JEDEC document JESD84-A441 (page 105) response for CMD7
> (MMC_CMD_SELECT_CARD) response should be R1 instead of R1b. In uboot
> we
> never take MMC to disconnected state and on powerup its always ideal
> state which later goes to stand-by state.
>
> from document footnote:
> R1 while selecting from Stand-By State to Transfer State; R1b while
> selecting from Disconnected State to Programming State.
>
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index e384399..79d00f6 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -987,7 +987,7 @@ int mmc_startup(struct mmc *mmc)
> /* Select the card, and put it into Transfer Mode */
> if (!mmc_host_is_spi(mmc)) { /* cmd not supported in spi */
> cmd.cmdidx = MMC_CMD_SELECT_CARD;
> - cmd.resp_type = MMC_RSP_R1b;
> + cmd.resp_type = MMC_RSP_R1;
> cmd.cmdarg = mmc->rca << 16;
> cmd.flags = 0;
> err = mmc_send_cmd(mmc, &cmd, NULL);
> --
> 1.7.0.4
any comments?
Regards,
Ajay Bhargav
next prev parent reply other threads:[~2011-10-11 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 13:13 [U-Boot] [PATCH] mmc: CMD7:MMC_CMD_SELECT_CARD response fix Ajay Bhargav
2011-10-07 4:49 ` Ajay Bhargav
2011-10-11 9:51 ` Ajay Bhargav [this message]
2011-10-11 16:39 ` Andy Fleming
[not found] <1875335715.200694.1318396495863.JavaMail.root@ahm.einfochips.com>
2011-10-12 5:22 ` Ajay Bhargav
2011-10-15 23:53 ` Andy Fleming
2011-10-20 6:24 ` Ajay Bhargav
[not found] <2034492837.237420.1318799477125.JavaMail.root@ahm.einfochips.com>
2011-10-16 21:14 ` Ajay Bhargav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1641063460.195195.1318326718941.JavaMail.root@ahm.einfochips.com \
--to=ajay.bhargav@einfochips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.