From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3899C433F5 for ; Fri, 28 Jan 2022 15:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=teXXTLzP9yIEmnTa1SktbDqIrNXrbEi3SiDPjz+u2Sg=; b=TS79c4LYRaoOZS c0gSyHg+qeXiZhBHIwOROavhHEN1ihWCaYp8ck0VRUFN8HfFhdA0yDdgfC1im2H8heqklocYY8uHG Ro52hd4seii0/+B92SDbVjDzWljuArj3U3eqS0PeFnfNL1vCi6U4cFHxaoVfNpZzz1OJir3jC2J9Y D3V2dz2tVX++2IZ7Jr+Os1EFe1w2pw17NWdyTWcww+GfSz6MbZR1BvLj9qoPcOU3peBLBw61ClUl1 JC4L6Qp3vKHOijezqWQDzcpTlraxO7b05kWSfEMnl2qbiMEGwnvP+XQQh6T6fEiuVdE5LQKwApKf+ +Ij6RS84ZlKdW1ReCZ+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDT34-002hIX-4W; Fri, 28 Jan 2022 15:20:26 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDT2r-002hET-FV for linux-arm-kernel@lists.infradead.org; Fri, 28 Jan 2022 15:20:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26060B80D2A; Fri, 28 Jan 2022 15:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D6F92C340E6; Fri, 28 Jan 2022 15:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643383210; bh=ceVVnou4kfql6ZPDjslsQVwx9NKAS8aICoGNXGiUpKM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=oiAKyW4pJmQnyfiJJk4AiypkW3W0Ty5Lv1AWoDKZ5ORs4ta4er27AKysOiNCRu6wG 0e9UUdzI/RSnKNUcNyh2ZngcJjFi0jEOVcTcXuuAta9ablLmwsIT53k8QvwfVWmqc/ Z7RECqEoPrA6yZfldofzRxv5v4I833ftoKLpnJ8lZ2/KPlPhEPp0gSm5NmdkEvfKQA 3aDvaxr8i4SysxK7QTTDSsrNHizhO+9nQTYQwvacs8JaENbFFK7Cm7ha7/Dfcvith2 Bx7eRZ64At5gIGC3vFw2FraCFkk6GOG9pD4JW6EJueg3vCjPoYSrqxMb0Z+wDf/Yi6 jTffkOtF2R2bQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B55A2E5D087; Fri, 28 Jan 2022 15:20:10 +0000 (UTC) MIME-Version: 1.0 Subject: Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164338321073.8810.2377370074085228481.git-patchwork-notify@kernel.org> Date: Fri, 28 Jan 2022 15:20:10 +0000 References: <20220128141550.2350-1-jszhang@kernel.org> In-Reply-To: <20220128141550.2350-1-jszhang@kernel.org> To: Jisheng Zhang Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, qiangqing.zhang@nxp.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_072013_688724_68078370 X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 28 Jan 2022 22:15:50 +0800 you wrote: > There are two issues with runtime pm handling in stmmac_dvr_remove(): > > 1. the mac is runtime suspended before stopping dma and rx/tx. We > need to ensure the device is properly resumed back. > > 2. the stmmaceth clk enable/disable isn't balanced in both exit and > error handling code path. Take the exit code path for example, when we > unbind the driver or rmmod the driver module, the mac is runtime > suspended as said above, so the stmmaceth clk is disabled, but > stmmac_dvr_remove() > stmmac_remove_config_dt() > clk_disable_unprepare() > CCF will complain this time. The error handling code path suffers > from the similar situtaion. > > [...] Here is the summary with links: - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() https://git.kernel.org/netdev/net/c/6449520391df You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B4BC4332F for ; Fri, 28 Jan 2022 15:20:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345714AbiA1PUN (ORCPT ); Fri, 28 Jan 2022 10:20:13 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:50764 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243841AbiA1PUL (ORCPT ); Fri, 28 Jan 2022 10:20:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 843CC60DE8; Fri, 28 Jan 2022 15:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D6F92C340E6; Fri, 28 Jan 2022 15:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643383210; bh=ceVVnou4kfql6ZPDjslsQVwx9NKAS8aICoGNXGiUpKM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=oiAKyW4pJmQnyfiJJk4AiypkW3W0Ty5Lv1AWoDKZ5ORs4ta4er27AKysOiNCRu6wG 0e9UUdzI/RSnKNUcNyh2ZngcJjFi0jEOVcTcXuuAta9ablLmwsIT53k8QvwfVWmqc/ Z7RECqEoPrA6yZfldofzRxv5v4I833ftoKLpnJ8lZ2/KPlPhEPp0gSm5NmdkEvfKQA 3aDvaxr8i4SysxK7QTTDSsrNHizhO+9nQTYQwvacs8JaENbFFK7Cm7ha7/Dfcvith2 Bx7eRZ64At5gIGC3vFw2FraCFkk6GOG9pD4JW6EJueg3vCjPoYSrqxMb0Z+wDf/Yi6 jTffkOtF2R2bQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B55A2E5D087; Fri, 28 Jan 2022 15:20:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164338321073.8810.2377370074085228481.git-patchwork-notify@kernel.org> Date: Fri, 28 Jan 2022 15:20:10 +0000 References: <20220128141550.2350-1-jszhang@kernel.org> In-Reply-To: <20220128141550.2350-1-jszhang@kernel.org> To: Jisheng Zhang Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, qiangqing.zhang@nxp.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 28 Jan 2022 22:15:50 +0800 you wrote: > There are two issues with runtime pm handling in stmmac_dvr_remove(): > > 1. the mac is runtime suspended before stopping dma and rx/tx. We > need to ensure the device is properly resumed back. > > 2. the stmmaceth clk enable/disable isn't balanced in both exit and > error handling code path. Take the exit code path for example, when we > unbind the driver or rmmod the driver module, the mac is runtime > suspended as said above, so the stmmaceth clk is disabled, but > stmmac_dvr_remove() > stmmac_remove_config_dt() > clk_disable_unprepare() > CCF will complain this time. The error handling code path suffers > from the similar situtaion. > > [...] Here is the summary with links: - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() https://git.kernel.org/netdev/net/c/6449520391df You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html