From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E221C433EF for ; Mon, 31 Jan 2022 02:52:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E5D7835BA; Mon, 31 Jan 2022 03:52:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Fr6o/1Z3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B1ED8339D; Mon, 31 Jan 2022 03:52:28 +0100 (CET) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3D2F58339D for ; Mon, 31 Jan 2022 03:52:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=masami.hiramatsu@linaro.org Received: by mail-pg1-x52b.google.com with SMTP id e16so11001689pgn.4 for ; Sun, 30 Jan 2022 18:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Z2ROnf8FiP3NdigMZdG7gXUWT9ksrzqvxWkcZavbpuA=; b=Fr6o/1Z3bwyntT3KOgMQZTx3DToWbSxCJBmvzY2vfBCW4zu1nZwHi3oCJgTXeIoacT 0jj8Ve3+V8hcFNQFoEDuvhzuRYp50OS2Fo+W/ucu1DM/frFZ20sltkjf+ad6OfE2+Ar3 jSepq/zSHHHm0BWjpICYBNgvn/63KZmOJZ+HoVzKmEBS/oaBkNnN103rWPpWiYonoHh8 WN2UxAfDxxvCiIrSdmZ0mKXzj2GUy1gPnFzmlhWWbgXNe+qMvl7l4ZcXwfGCfE4BDmUE 5VxOfZH2t8gdv3Km3mmlUFd+OkJfuUW1ETwf+H9D8rliMaGACknRu5AgWIHjrVo4UKJH q9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Z2ROnf8FiP3NdigMZdG7gXUWT9ksrzqvxWkcZavbpuA=; b=prQnjTzxNzjetZeBtM72xzQ7WzuP/elCiBMtQnboNLTb3KGig9qBwLJ88uhnvCPAYU mgTMRVUDCPZ6u0vR1UUAa0WRnkYU63+9UIwkVvb9R7Slkl39ShQ+0l5GvQ8KvikUfko6 yX47j4UcRD93HhF50HrgyMB8bhzmH4C4qgtaLRdqRiharfaRvIIPZ38GwExU9AgO+ZPn D7wqtu+mpfb6bkt/L5SE4It+ab9NkDvFaOyLYE0xWVTP5fwyEGuD0kgU4pXo4MbLJb0S Qj+IA3meO4p+D2oawnet4idR+TIBkGOtBZr/9yXE7ozhX7t7giOyGmWbBkTQESqv1jca zzzg== X-Gm-Message-State: AOAM531XnsiZV3OvxxCQvuVvcdtbhPHW7pb2V9GfjzvBq77IQoG1QVTw FznUn9fqu1LR5VEAREz+JpX0DA== X-Google-Smtp-Source: ABdhPJxGu5N2TNaEHo9EMrHzoYGmvQMWXRdvclx5ghlcGHPqsvzaL4TT1PingeaXBR+MUK7G4CZ6NA== X-Received: by 2002:a63:e250:: with SMTP id y16mr14927001pgj.147.1643597543701; Sun, 30 Jan 2022 18:52:23 -0800 (PST) Received: from localhost.localdomain (113x37x226x201.ap113.ftth.ucom.ne.jp. [113.37.226.201]) by smtp.gmail.com with ESMTPSA id s37sm12089955pfg.144.2022.01.30.18.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jan 2022 18:52:23 -0800 (PST) From: Masami Hiramatsu To: Tom Rini , Lukasz Majewski Cc: u-boot@lists.denx.de, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, jaswinder.singh@linaro.org Subject: [PATCH v2 1/5] DFU: Do not copy the entity name over the buffer size Date: Mon, 31 Jan 2022 11:52:20 +0900 Message-Id: <164359754070.280839.249007223441412046.stgit@localhost> X-Mailer: git-send-email 2.25.1 In-Reply-To: <164359753172.280839.8310577813724924540.stgit@localhost> References: <164359753172.280839.8310577813724924540.stgit@localhost> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Use strlcpy() instead of strcpy() to prevent copying the entity name over the name buffer size. Signed-off-by: Masami Hiramatsu --- drivers/dfu/dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index af3975925a..66c41b5e76 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -503,7 +503,7 @@ static int dfu_fill_entity(struct dfu_entity *dfu, char *s, int alt, debug("%s: %s interface: %s dev: %s\n", __func__, s, interface, devstr); st = strsep(&s, " "); - strcpy(dfu->name, st); + strlcpy(dfu->name, st, DFU_NAME_SIZE); dfu->alt = alt; dfu->max_buf_size = 0;