From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks Date: Fri, 20 Dec 2013 22:14:28 +0100 Message-ID: <1644725.nymfPqUWVu@flatron> References: <1383905648-23733-1-git-send-email-sachin.kamat@linaro.org> <3552349.yKrGzNhczA@amdc1227> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-ee0-f48.google.com ([74.125.83.48]:37133 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514Ab3LTVOb (ORCPT ); Fri, 20 Dec 2013 16:14:31 -0500 Received: by mail-ee0-f48.google.com with SMTP id e49so1271543eek.35 for ; Fri, 20 Dec 2013 13:14:30 -0800 (PST) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sachin Kamat Cc: Tomasz Figa , Andrew Bresticker , linux-samsung-soc , Mike Turquette On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote: > Hi Tomasz, > > On 19 December 2013 19:40, Tomasz Figa wrote: > > Hi Sachin, Andrew, > > > > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote: > >> Hi Tomasz, > >> > >> On 10 November 2013 22:38, Tomasz Figa wrote: > >> > Hi Sachin, Andrew, > >> > > >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: > >> >> From: Andrew Bresticker > >> >> > >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e. > >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. > >> >> Fix this so that the MFC will start up. > >> > > >> > Wow, this means that there is a mistake in the documentation. Not that > >> > I'm surprised, though. > >> > > >> > I guess you are sure about this, so: > >> > > >> > Reviewed-by: Tomasz Figa > >> > >> I believe you are going to take this through your tree along with a > >> few others which you have already reviewed? > > > > This patch seems to depend on my Exynos 5250 clock clean-up series, which > > will be merged for 3.14. Are you okay with this patch being merged for > > 3.14 as well or this fix is needed for earlier kernel versions too? > > (It is not a regression introduced in 3.13, though.) > > Yes, I did rebase it on top of your series along with other patches. > Though not a regression introduced in 3.13, I think it makes sense to have this > sent as a fix during this release (3.13) itself. Let me know if you > want me to base it > on top of 3.13-rc4 and re-send. Since this is just a trivial fix, let me do it myself when applying. Best regards, Tomasz