From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister()
Date: Wed, 23 Feb 2022 12:40:10 +0000 [thread overview]
Message-ID: <164562001060.25344.12731632032260958454.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220222134251.GA2271@kili>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 22 Feb 2022 16:42:51 +0300 you wrote:
> This test is checking if we exited the list via break or not. However
> if it did not exit via a break then "node" does not point to a valid
> udp_tunnel_nic_shared_node struct. It will work because of the way
> the structs are laid out it's the equivalent of
> "if (info->shared->udp_tunnel_nic_info != dev)" which will always be
> true, but it's not the right way to test.
>
> [...]
Here is the summary with links:
- [net] udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister()
https://git.kernel.org/netdev/net/c/de7b2efacf4e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-02-23 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 13:42 [PATCH net] udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister() Dan Carpenter
2022-02-23 12:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164562001060.25344.12731632032260958454.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.