From: patchwork-bot+netdevbpf@kernel.org
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, nicolas.ferre@microchip.com,
claudiu.beznea@microchip.com, davem@davemloft.net,
kuba@kernel.org, soren.brinkmann@xilinx.com,
scott.mcnutt@siriusxm.com, stable@vger.kernel.org
Subject: Re: [PATCH net v2] net: macb: Fix lost RX packet wakeup race in NAPI receive
Date: Fri, 04 Mar 2022 12:10:10 +0000 [thread overview]
Message-ID: <164639581051.6905.901376862020393638.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220303181027.168204-1-robert.hancock@calian.com>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 3 Mar 2022 12:10:27 -0600 you wrote:
> There is an oddity in the way the RSR register flags propagate to the
> ISR register (and the actual interrupt output) on this hardware: it
> appears that RSR register bits only result in ISR being asserted if the
> interrupt was actually enabled at the time, so enabling interrupts with
> RSR bits already set doesn't trigger an interrupt to be raised. There
> was already a partial fix for this race in the macb_poll function where
> it checked for RSR bits being set and re-triggered NAPI receive.
> However, there was a still a race window between checking RSR and
> actually enabling interrupts, where a lost wakeup could happen. It's
> necessary to check again after enabling interrupts to see if RSR was set
> just prior to the interrupt being enabled, and re-trigger receive in that
> case.
>
> [...]
Here is the summary with links:
- [net,v2] net: macb: Fix lost RX packet wakeup race in NAPI receive
https://git.kernel.org/netdev/net/c/0bf476fc3624
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-03-04 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 18:10 [PATCH net v2] net: macb: Fix lost RX packet wakeup race in NAPI receive Robert Hancock
2022-03-04 9:19 ` Claudiu.Beznea
2022-03-04 12:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164639581051.6905.901376862020393638.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robert.hancock@calian.com \
--cc=scott.mcnutt@siriusxm.com \
--cc=soren.brinkmann@xilinx.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.