From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7] eal: map uio resources after hugepages. Date: Fri, 07 Nov 2014 16:15:06 +0100 Message-ID: <1646488.MLiSkxW7Wj@xps13> References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> <1415372269-8723-1-git-send-email-liang.xu@cinfotech.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: lxu Return-path: In-Reply-To: <1415372269-8723-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Liang, I see you are learning how to send a patch. It's a good thing. I don't know if the idea of your patch will be accepted but here are more tips about formatting: - You should use checkpatch.pl from kernel.org and fix the most important issues - The commit log should be wrapped to avoid long lines - The title is important. You didn't update it for vfio. And there should be no point at the end of the title. - You should use your real name in Signed-off-by. - You should annotate each new version to show the changes See http://dpdk.org/dev#send and https://www.kernel.org/doc/Documentation/SubmittingPatches Looking at other submissions could be inspiring also. Thanks -- Thomas