From: Kris Bahnsen <kris@embeddedTS.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Featherston <mark@embeddedts.com>
Subject: Re: [PATCH v2] gpio: ts4900: Do not set DAT and OE together
Date: Wed, 09 Mar 2022 10:03:15 -0800 [thread overview]
Message-ID: <1646848995.2231.2.camel@embeddedTS.com> (raw)
In-Reply-To: <CAMRc=McuAB96JSKVeAPQLOgjGZkD5hOtYt=904Aw4t4aYVVKqg@mail.gmail.com>
On Wed, 2022-03-09 at 09:32 +0100, Bartosz Golaszewski wrote:
> On Tue, Mar 8, 2022 at 7:19 PM Kris Bahnsen <kris@embeddedts.com> wrote:
> >
> > diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
> > index d885032cf814..fbabfca030c0 100644
> > --- a/drivers/gpio/gpio-ts4900.c
> > +++ b/drivers/gpio/gpio-ts4900.c
> > @@ -1,7 +1,8 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> This is not part of the fix, please send a separate patch that comes
> after the fix adding the SPDX identifier.
>
> > /*
> > * Digital I/O driver for Technologic Systems I2C FPGA Core
> > *
> > - * Copyright (C) 2015 Technologic Systems
> > + * Copyright (C) 2015-2018 Technologic Systems
> > * Copyright (C) 2016 Savoir-Faire Linux
> > *
> > * This program is free software; you can redistribute it and/or
>
> If you're adding the SPDX identifier, you can drop the license boilerplate here.
>
> Bart
>
Thanks for the feedback. I'll get a v3 series out soon to address these.
Kris
next prev parent reply other threads:[~2022-03-09 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 18:18 [PATCH v2] gpio: ts4900: Do not set DAT and OE together Kris Bahnsen
2022-03-09 8:32 ` Bartosz Golaszewski
2022-03-09 18:03 ` Kris Bahnsen [this message]
2022-03-10 11:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646848995.2231.2.camel@embeddedTS.com \
--to=kris@embeddedts.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@embeddedts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.