From mboxrd@z Thu Jan 1 00:00:00 1970 From: patchwork-bot+netdevbpf@kernel.org Subject: Re: [PATCH] hamradio: Fix wrong assignment of 'bbc->cfg.loopback' Date: Thu, 17 Mar 2022 02:30:11 +0000 Message-ID: <164748421108.27087.13961135961342141281.git-patchwork-notify@kernel.org> References: <20220315074851.6456-1-tangmeng@uniontech.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647484211; bh=aBBtB1WlenW0nX+sTuBbNSZBr6ooYgdbxwcBf+8Je9M=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=H72f5hcWiBTXVS8NAYJzRj78tRlgoJeyLhy1+Eq97pBRA3y1vcY7Y+/jRUvDRUd8E 67jlHUm8i2p0hCmZKxqGfFP8jJHGT0Ky/HVQ/DKBYaS4EXvwoxBiseSaB7X/6HF30N ER05sOGankmyLxH4As/TT7L59atdFcfHRhvpoiGrjL3JRSVEWTupGUMaaBwVOZ+TeB DuKbM/FWmhZd7g1oTq2ZQiaik1njkMbUvv4KQUAopr7Wi9ac87vjYeUVA93jrDDRdF Uab5tYvpQyUVX/ytOV5Szlgryd3aUeDWnEMomaN/CfIkZiK2eX4hPiKkPCR0mKey3q ApgictnfDYBRw== In-Reply-To: <20220315074851.6456-1-tangmeng@uniontech.com> List-ID: Content-Type: text/plain; charset="us-ascii" To: Meng Tang Cc: t.sailer@alumni.ethz.ch, davem@davemloft.net, kuba@kernel.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 15 Mar 2022 15:48:51 +0800 you wrote: > In file hamradio/baycom_epp.c, the baycom_setmode interface, there > is a problem with improper use of strstr. > > Suppose that when modestr="noloopback", both conditions which are > 'strstr(modestr,"noloopback")' and 'strstr(modestr,"loopback")' > will be true(not NULL), this lead the bc->cfg.loopback variable > will be first assigned to 0, and then reassigned to 1. > > [...] Here is the summary with links: - hamradio: Fix wrong assignment of 'bbc->cfg.loopback' https://git.kernel.org/netdev/net-next/c/a8df216630fe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html