From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Laurent Pinchart To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, Gustavo Padovan , David Airlie , "open list:DRM DRIVERS FOR RENESAS" , open list Subject: Re: [PATCH 14/14] drm/shmobile: use drm_crtc_vblank_{get,put}() Date: Mon, 06 Jun 2016 21:25:39 +0300 Message-ID: <16483223.YFJQnt9kYP@avalon> In-Reply-To: <1465224105-21485-14-git-send-email-gustavo@padovan.org> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-14-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Gustavo, Thank you for the patch. On Monday 06 Jun 2016 11:41:45 Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_vblank_{get,put}() with the new helper functions. > > Signed-off-by: Gustavo Padovan Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 1e154fc..6547b1d 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > @@ -441,7 +441,7 @@ void shmob_drm_crtc_finish_page_flip(struct > shmob_drm_crtc *scrtc) scrtc->event = NULL; > if (event) { > drm_crtc_send_vblank_event(&scrtc->crtc, event); > - drm_vblank_put(dev, 0); > + drm_crtc_vblank_put(&scrtc->crtc); > } > spin_unlock_irqrestore(&dev->event_lock, flags); > } > @@ -467,7 +467,7 @@ static int shmob_drm_crtc_page_flip(struct drm_crtc > *crtc, > > if (event) { > event->pipe = 0; > - drm_vblank_get(dev, 0); > + drm_crtc_vblank_get(&scrtc->crtc); > spin_lock_irqsave(&dev->event_lock, flags); > scrtc->event = event; > spin_unlock_irqrestore(&dev->event_lock, flags); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 14/14] drm/shmobile: use drm_crtc_vblank_{get,put}() Date: Mon, 06 Jun 2016 21:25:39 +0300 Message-ID: <16483223.YFJQnt9kYP@avalon> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-14-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6E156E62A for ; Mon, 6 Jun 2016 18:25:28 +0000 (UTC) In-Reply-To: <1465224105-21485-14-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: "open list:DRM DRIVERS FOR RENESAS" , Gustavo Padovan , open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgR3VzdGF2bywKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDA2IEp1biAy MDE2IDExOjQxOjQ1IEd1c3Rhdm8gUGFkb3ZhbiB3cm90ZToKPiBGcm9tOiBHdXN0YXZvIFBhZG92 YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gCj4gUmVwbGFjZSB0aGUgbGVn YWN5IGRybV92Ymxhbmtfe2dldCxwdXR9KCkgd2l0aCB0aGUgbmV3IGhlbHBlciBmdW5jdGlvbnMu Cj4gCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29s bGFib3JhLmNvLnVrPgoKQWNrZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9z aG1vYl9kcm1fY3J0Yy5jIHwgNCArKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zaG1v YmlsZS9zaG1vYl9kcm1fY3J0Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2Jf ZHJtX2NydGMuYyBpbmRleCAxZTE1NGZjLi42NTQ3YjFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3NobW9iaWxlL3NobW9iX2RybV9jcnRjLmMKPiBAQCAtNDQxLDcgKzQ0MSw3IEBAIHZvaWQgc2ht b2JfZHJtX2NydGNfZmluaXNoX3BhZ2VfZmxpcChzdHJ1Y3QKPiBzaG1vYl9kcm1fY3J0YyAqc2Ny dGMpIHNjcnRjLT5ldmVudCA9IE5VTEw7Cj4gIAlpZiAoZXZlbnQpIHsKPiAgCQlkcm1fY3J0Y19z ZW5kX3ZibGFua19ldmVudCgmc2NydGMtPmNydGMsIGV2ZW50KTsKPiAtCQlkcm1fdmJsYW5rX3B1 dChkZXYsIDApOwo+ICsJCWRybV9jcnRjX3ZibGFua19wdXQoJnNjcnRjLT5jcnRjKTsKPiAgCX0K PiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICB9 Cj4gQEAgLTQ2Nyw3ICs0NjcsNyBAQCBzdGF0aWMgaW50IHNobW9iX2RybV9jcnRjX3BhZ2VfZmxp cChzdHJ1Y3QgZHJtX2NydGMKPiAqY3J0YywKPiAKPiAgCWlmIChldmVudCkgewo+ICAJCWV2ZW50 LT5waXBlID0gMDsKPiAtCQlkcm1fdmJsYW5rX2dldChkZXYsIDApOwo+ICsJCWRybV9jcnRjX3Zi bGFua19nZXQoJnNjcnRjLT5jcnRjKTsKPiAgCQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT5ldmVu dF9sb2NrLCBmbGFncyk7Cj4gIAkJc2NydGMtPmV2ZW50ID0gZXZlbnQ7Cj4gIAkJc3Bpbl91bmxv Y2tfaXJxcmVzdG9yZSgmZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7CgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=