From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A750C433F5 for ; Tue, 19 Oct 2021 13:25:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 012366137F for ; Tue, 19 Oct 2021 13:25:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 012366137F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A96216E15D; Tue, 19 Oct 2021 13:25:42 +0000 (UTC) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEC876E15D for ; Tue, 19 Oct 2021 13:25:41 +0000 (UTC) Received: by mail-lj1-x22a.google.com with SMTP id n7so6153742ljp.5 for ; Tue, 19 Oct 2021 06:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X1jY2Qqxt6YWhnV3gpCcJZNEFbKKuJn17k39miNOmnw=; b=ER4eL+lj7rSgFqe1k9f7NP0Xedp2lyl0DbOhg2ocq5ghDZs3wJsUNzd2AxfVUBWgOX CldSEyp9jJ6MJxTT9k8h7QtJbdUZcUgPiO8zchszYrX3RAdO0HjkSKlpNCSq4cnW81ev uSnFWz5geOsAnr6dyKG0WG9IumnTGkz4OS1Eu993pMLhZvyeLoCVsldmcPUP60gfaPIX rf84owpPqdP+abE7HMt5cdmlMnWIKksTXnntXMAZfNEbcqyT/rFFi5pL/pqooVIdAdNi X+T88fR/Z13PWJhjH4WTFf14Zj49wJ46wE4OvsHc6GvO8DZx3AbqpzhX3zQCvxFf0TP/ RczQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X1jY2Qqxt6YWhnV3gpCcJZNEFbKKuJn17k39miNOmnw=; b=NVL4p9TLytueQlB9d+FjLKBeNRlQI6Af0ft51HVwu/uQ4HSxzAM4pFhbF39e5vEG5/ IOvHAPClsO07X2lvajd9k5jShvSuobjJsFk8rPgpZc6yX2GgnCYXXW8PvKbe89oYkCgv yon8MNQCCmLIap8v4ruFMZoSg2iWpX4JRMlqQtHVh/n8I3BPkFUv3hIyvzJoSOwzy/as uWUPk4h3TJtPDIgxSW3et1oHK/nXB63oHFPeYbYIpRkWR7U023qFF6rkvT5CN2V5ERS7 m7RCumuDkTHxNxQXvI2gwYEXJvnEFd28OagsaZPkXJOEE+3uVlxjeb7kf6gvZ3AlGQKE QZAA== X-Gm-Message-State: AOAM530gMFlFtGsIPtNreeU7Gno2lAiqX6rxbT4op2MKeUqxhVDyETB7 qK8GDTwRPUo8jhRh4/3cOYmk6tl/Rm0= X-Google-Smtp-Source: ABdhPJyEBGG7iDcVG31icdYRuoDVz7fUXzq7qVuT8pUeGj2UN5S1m4KOei5sbJ8rVY7PI/3BigmyhA== X-Received: by 2002:a2e:b603:: with SMTP id r3mr6838475ljn.14.1634649940193; Tue, 19 Oct 2021 06:25:40 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id l11sm382318lfg.79.2021.10.19.06.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 06:25:39 -0700 (PDT) From: Nicolas Frattaroli To: Daniel Vetter , Christian =?ISO-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies Date: Tue, 19 Oct 2021 15:25:38 +0200 Message-ID: <1649107.a7JZP30qnB@archbook> In-Reply-To: References: <20211019112706.27769-1-christian.koenig@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Dienstag, 19. Oktober 2021 15:06:31 CEST Christian K=F6nig wrote: >=20 > Am 19.10.21 um 14:35 schrieb Daniel Vetter: > > On Tue, Oct 19, 2021 at 01:27:06PM +0200, Christian K=F6nig wrote: > >> Trivial fix since we now need to grab a reference to the fence we have > >> added. Previously the dma_resv function where doing that for us. > >> > >> Signed-off-by: Christian K=F6nig > >> Fixes: 9c2ba265352a drm/scheduler: ("use new iterator in drm_sched_job= _add_implicit_dependencies v2") > > Uh I completely missed checking for that. Did you review all other > > conversions you've pushed for this kind of bug? >=20 > Yeah, currently double checking that. >=20 > > Reviewed-by: Daniel Vetter > > > > Also > > > > Reported-by: Nicolas Frattaroli > > References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbo= ok/ > > > > It's important to credit bug reporters! Also upgrade to t-b if Nicolas > > gets around to testing quickly. >=20 > Yeah, the credit part is certainly correct. I just usually ask people=20 > before adding their mail address to kernel commits because of the spam=20 > you get :) >=20 > Cheers, > Christian. No worries, I made this e-mail address specifically for kernel work due to this. I wouldn't even dare posting on public mailing lists with my regular e-mail address. Regards, Nicolas Frattaroli >=20 > > > > Cheers, Daniel > > > >> --- > >> drivers/gpu/drm/scheduler/sched_main.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/= scheduler/sched_main.c > >> index 5bc5f775abe1..94fe51b3caa2 100644 > >> --- a/drivers/gpu/drm/scheduler/sched_main.c > >> +++ b/drivers/gpu/drm/scheduler/sched_main.c > >> @@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct= drm_sched_job *job, > >> ret =3D drm_sched_job_add_dependency(job, fence); > >> if (ret) > >> return ret; > >> + > >> + /* Make sure to grab an additional ref on the added fence */ > >> + dma_fence_get(fence); > >> } > >> return 0; > >> } > >> >=20 >=20