All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+chrome-platform@kernel.org
To: Guenter Roeck <linux@roeck-us.net>
Cc: bleung@chromium.org, chrome-platform@lists.linux.dev,
	linux-kernel@vger.kernel.org, dnojiri@chromium.org,
	robbarnes@google.com, rajatja@google.com,
	briannorris@chromium.org, parthmalkan@google.com
Subject: Re: [PATCH v2] platform/chrome: Re-introduce cros_ec_cmd_xfer and use it for ioctls
Date: Wed, 20 Apr 2022 09:10:11 +0000	[thread overview]
Message-ID: <165044581114.11968.7352761617264023399.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220318165422.686848-1-linux@roeck-us.net>

Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Fri, 18 Mar 2022 09:54:22 -0700 you wrote:
> Commit 413dda8f2c6f ("platform/chrome: cros_ec_chardev: Use
> cros_ec_cmd_xfer_status helper") inadvertendly changed the userspace ABI.
> Previously, cros_ec ioctls would only report errors if the EC communication
> failed, and otherwise return success and the result of the EC
> communication. An EC command execution failure was reported in the EC
> response field. The above mentioned commit changed this behavior, and the
> ioctl itself would fail. This breaks userspace commands trying to analyze
> the EC command execution error since the actual EC command response is no
> longer reported to userspace.
> 
> [...]

Here is the summary with links:
  - [v2] platform/chrome: Re-introduce cros_ec_cmd_xfer and use it for ioctls
    https://git.kernel.org/chrome-platform/c/57b888ca2541

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-04-20  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 16:54 [PATCH v2] platform/chrome: Re-introduce cros_ec_cmd_xfer and use it for ioctls Guenter Roeck
2022-03-18 17:59 ` Daisuke Nojiri
     [not found] ` <CAC0y+AjJxRGE570hTAq4WEtFrWa71e9q_h4xyN_52o4b9G_r2g@mail.gmail.com>
2022-03-18 18:00   ` Daisuke Nojiri
2022-03-19  1:22 ` Brian Norris
2022-04-19  3:30 ` patchwork-bot+chrome-platform
2022-04-20  9:10 ` patchwork-bot+chrome-platform [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165044581114.11968.7352761617264023399.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+chrome-platform@kernel.org \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dnojiri@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=parthmalkan@google.com \
    --cc=rajatja@google.com \
    --cc=robbarnes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.