From: Kris Bahnsen via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>, buildroot@buildroot.org
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mark Featherston <mark@embeddedTS.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2 1/4] package/wilc1000-firmware: bump to 15.6
Date: Mon, 25 Apr 2022 13:16:29 -0700 [thread overview]
Message-ID: <1650917789.6000.2.camel@embeddedTS.com> (raw)
In-Reply-To: <9223c80f-61a0-985f-7aba-fa6128286fa9@mind.be>
On Mon, 2022-04-25 at 22:04 +0200, Arnout Vandecappelle wrote:
[snip]
> Hash for the license file you added was missing.
[snip]
> We actually use proprietary to mark any non-open-source license. The idea is
> that SPDX is uses for the LICENSE variable (with an exception: adding + instead
> of -or-later, and no -only). This is not done consistently, but I don't want to
> go in the wrong direction :-). And maybe there's something to be said for using
> a more descriptive license name than proprietary, but this shouldn't be snuck in
> with a version bump.
I was not aware of either of these details. Thanks for the clarification, I'll
keep them in mind for the future!
-Kris
>
>
> Regards,
> Arnout
>
> > +WILC1000_FIRMWARE_LICENSE_FILES = LICENSE.wilc_fw
> >
> > -define WILC1000_FIRMWARE_EXTRACT_CMDS
> > - $(UNZIP) -d $(BUILD_DIR) $(WILC1000_FIRMWARE_DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
> > - mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
> > - rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
> > +ifeq ($(BR2_PACKAGE_WILC1000_FIRMWARE),y)
> > +WILC1000_FIRMWARE_FILES += \
> > + wilc1000_wifi_firmware.bin
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_WILC3000_FIRMWARE),y)
> > +WILC1000_FIRMWARE_FILES += \
> > + wilc3000_ble_firmware.bin \
> > + wilc3000_wifi_firmware.bin
> > +endif
> > +
> > +define WILC1000_FIRMWARE_INSTALL_FILES
> > + cd $(@D) && \
> > + $(TAR) cf install.tar $(sort $(WILC1000_FIRMWARE_FILES)) && \
> > + $(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware/mchp
> > endef
> >
> > define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
> > - $(INSTALL) -D -m 0644 $(@D)/wilc1003_firmware.bin \
> > - $(TARGET_DIR)/lib/firmware/atmel/wilc1003_firmware.bin
> > + $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/mchp/
> > + $(WILC1000_FIRMWARE_INSTALL_FILES)
> > endef
> >
> > $(eval $(generic-package))
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-25 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 22:36 [Buildroot] [PATCH v2 0/4] Pull in WILC Wi-Fi updates Kris Bahnsen via buildroot
2022-04-22 22:36 ` [Buildroot] [PATCH v2 1/4] package/wilc1000-firmware: bump to 15.6 Kris Bahnsen via buildroot
2022-04-25 20:04 ` Arnout Vandecappelle
2022-04-25 20:16 ` Kris Bahnsen via buildroot [this message]
2022-04-22 22:36 ` [Buildroot] [PATCH v2 2/4] package/wilc-firmware: rename from wilc1000-firmware Kris Bahnsen via buildroot
2022-04-25 20:06 ` Arnout Vandecappelle
2022-04-22 22:36 ` [Buildroot] [PATCH v2 3/4] configs: add WILC3000_FIRMWARE to compatible devices Kris Bahnsen via buildroot
2022-04-25 20:07 ` Arnout Vandecappelle
2022-04-25 20:28 ` Kris Bahnsen via buildroot
2022-04-22 22:36 ` [Buildroot] [PATCH v2 4/4] package/wilc-driver: new package Kris Bahnsen via buildroot
2022-04-25 20:08 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1650917789.6000.2.camel@embeddedTS.com \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=eugen.hristev@microchip.com \
--cc=kris@embeddedTS.com \
--cc=ludovic.desroches@microchip.com \
--cc=mark@embeddedTS.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.