From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Mike Rapoport <rppt@kernel.org>, Anuradha Weeraman <anuradha@debian.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: avoid shadowing global mem_map in sparse_init_one_section()
Date: Mon, 6 Jul 2026 11:07:19 +0200 [thread overview]
Message-ID: <16516aae-d233-4756-a378-14ead66de36f@kernel.org> (raw)
In-Reply-To: <akohFqkKncFzoupL@kernel.org>
On 7/5/26 11:17, Mike Rapoport wrote:
> On Sat, Jul 04, 2026 at 11:54:51PM +0530, Anuradha Weeraman wrote:
>> With W=2, sparse_init_one_section() warns because its mem_map parameter
>> shadows the global mem_map declaration in linux/mmzone.h.
>>
>> Rename it to section_mem_map to make that scope explicit and avoid the
>> shadowing warning.
>
> I suspect that the comment in mmzone.h saying that mem_map is must be
> declared for SPARSEMEM is stale and it can be guarded by #ifdef
> CONFIG_FLATMEM which will be a more correct fix.
>
Unrelated to that, I thought we don't particularly care about W=2 stuff unless
it uncovers a real bug?
--
Cheers,
David
prev parent reply other threads:[~2026-07-06 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 18:24 [PATCH] mm: avoid shadowing global mem_map in sparse_init_one_section() Anuradha Weeraman
2026-07-05 9:17 ` Mike Rapoport
2026-07-06 9:07 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16516aae-d233-4756-a378-14ead66de36f@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anuradha@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.