From: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>
Cc: amodra@gmail.com
Subject: Re: [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S
Date: Tue, 17 May 2022 13:03:21 +0530 [thread overview]
Message-ID: <1652772528.r6qrwbbda5.naveen@linux.ibm.com> (raw)
In-Reply-To: <20220502125010.1319370-1-mpe@ellerman.id.au>
Michael Ellerman wrote:
>
> diff --git a/arch/powerpc/kernel/vdso/gettimeofday.S b/arch/powerpc/kernel/vdso/gettimeofday.S
> index eb9c81e1c218..0aee255e9cbb 100644
> --- a/arch/powerpc/kernel/vdso/gettimeofday.S
> +++ b/arch/powerpc/kernel/vdso/gettimeofday.S
> @@ -22,12 +22,15 @@
> .macro cvdso_call funct call_time=0
> .cfi_startproc
> PPC_STLU r1, -PPC_MIN_STKFRM(r1)
> + .cfi_adjust_cfa_offset PPC_MIN_STKFRM
> mflr r0
> - .cfi_register lr, r0
> PPC_STLU r1, -PPC_MIN_STKFRM(r1)
> + .cfi_adjust_cfa_offset PPC_MIN_STKFRM
> PPC_STL r0, PPC_MIN_STKFRM + PPC_LR_STKOFF(r1)
<snip>
> @@ -46,6 +50,7 @@
> mtlr r0
> .cfi_restore lr
> addi r1, r1, 2 * PPC_MIN_STKFRM
> + .cfi_def_cfa_offset 0
Should this be .cfi_adjust_cfa_offset, given that we used that at the
start of the function?
- Naveen
next prev parent reply other threads:[~2022-05-17 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 12:50 [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S Michael Ellerman
2022-05-02 14:27 ` Segher Boessenkool
2022-05-02 23:53 ` Alan Modra
2022-05-04 12:34 ` Michael Ellerman
2022-05-04 12:27 ` Michael Ellerman
2022-05-04 14:08 ` Segher Boessenkool
2022-05-08 11:11 ` Michael Ellerman
2022-05-17 7:33 ` Naveen N. Rao [this message]
2022-05-17 12:32 ` Michael Ellerman
2022-05-18 9:38 ` Naveen N. Rao
2022-05-19 1:30 ` Alan Modra
2022-05-20 12:14 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652772528.r6qrwbbda5.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.