From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9175C433F5 for ; Tue, 31 May 2022 13:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vKdLCTTUZqYG2Tlpc9u2XrF1TW/UrxwFQctJhjH2NZ8=; b=RhXPKr8tEseiWm QbL4Ph/fwLO9viimD6xcl584ABUjCTf5bVmf8XJA3OjssEKibMpGz1Xe1oP81yHqRrvEYbSe2fzwI FCEPNUZLKw61LoQDb0WMDvO8uw8A+LeWB8LGK3er0E/l42EQia6FDjlPAFsRVjbL7/GfoNbSO19xr go00aPOlduIf68DKVf4sp4sasxaoUfJqdIaQZ3onLdzT/PlSwHZbarlvqw8jUWjvF+vjux76MtAK0 F+HgDUqrJv1BLsp5rqZ4o2ML32FQyKNiYyw7XS6zg8MJ55RgyQ9PEeXGW7ftBx5cSYYdayz5zsrFU fr8Ks8gZZ3/XJ63XFyZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1qE-00B3dE-Of; Tue, 31 May 2022 13:23:23 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1oO-00B2go-Hb for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 13:21:32 +0000 Received: by mail-oi1-f180.google.com with SMTP id s188so17391483oie.4 for ; Tue, 31 May 2022 06:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=e5hEwdVyk0aAkl6eSBNPLNwTk/gtSZtsZFRN5GRZ6bA=; b=Th2BTwVJyKkbDGiFKJz2lvSBmr+xYUqzIGC0rhmDog9oqtX5FaM5QZ4yxbwpi//+nL L5EnXpzFtd7l08WM1C5O4RlLzNsKqOm1y5pX1B4HItysD2pkrq2G+F3jBLFD4zGVn2AR up4k2/VP1pk8BCFokGiDTpImXCSoHO/EzYTT1/SkXk4kNNWqYvQGQBOd2+YGLjyzD59N Tv3mWbM9utl2stYoEaILPqwVGqgfd/XE1LhNZPQIn7vZofaviOaN/wHOVIdQmSKoMrfq cIpg9uhOApsmY4C+WeXeKplrnGTlGLfsLQoCRTGSxRop7hNbqwRfnfBj8iymPbJ+xutZ D61w== X-Gm-Message-State: AOAM531gyOdzU09qVUqiAMdz/ZLzPChZ3c/VN8zdxchDd8dCxcv1Hgtp /PmImtxC1bmnf80y8BgTOA== X-Google-Smtp-Source: ABdhPJwc9hEHIr4dNicEv2trxpFWfW7N9CStjs9nOb2xy+SSJhjlsZ6CBFELIq7Zjs0oQODGv2QlAg== X-Received: by 2002:a05:6808:f8c:b0:32a:e67f:d20e with SMTP id o12-20020a0568080f8c00b0032ae67fd20emr11509012oiw.88.1654003287818; Tue, 31 May 2022 06:21:27 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s31-20020a056830439f00b0060613c844adsm6307651otv.10.2022.05.31.06.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 06:21:27 -0700 (PDT) Received: (nullmailer pid 1610161 invoked by uid 1000); Tue, 31 May 2022 13:21:25 -0000 From: Rob Herring To: Puranjay Mohan Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, robh+dt@kernel.org, edumazet@google.com, vigneshr@ti.com, kishon@ti.com, afd@ti.com, davem@davemloft.net, ssantosh@kernel.org, andrew@lunn.ch, krzysztof.kozlowski+dt@linaro.org, grygorii.strashko@ti.com, devicetree@vger.kernel.org, s-anna@ti.com, nm@ti.com, rogerq@kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20220531095108.21757-2-p-mohan@ti.com> References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Date: Tue, 31 May 2022 08:21:25 -0500 Message-Id: <1654003285.283793.1610159.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_062128_711599_BBC46B0D X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 31 May 2022 15:21:07 +0530, Puranjay Mohan wrote: > Add a YAML binding document for the ICSSG Programmable real time unit > based Ethernet driver. This driver uses the PRU and PRUSS consumer APIs > to interface the PRUs and load/run the firmware for supporting ethernet > functionality. > > Signed-off-by: Puranjay Mohan > --- > v1: https://lore.kernel.org/all/20220506052433.28087-2-p-mohan@ti.com/ > v1 -> v2: > * Addressed Rob's Comments > * It includes indentation, formatting, and other minor changes. > --- > .../bindings/net/ti,icssg-prueth.yaml | 181 ++++++++++++++++++ > 1 file changed, 181 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: pruss2_eth: False schema does not allow {'compatible': ['ti,am654-icssg-prueth'], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'sram': [[4294967295]], 'ti,prus': [[4294967295, 4294967295, 4294967295, 4294967295, 4294967295, 4294967295]], 'firmware-name': ['ti-pruss/am65x-pru0-prueth-fw.elf', 'ti-pruss/am65x-rtu0-prueth-fw.elf', 'ti-pruss/am65x-txpru0-prueth-fw.elf', 'ti-pruss/am65x-pru1-prueth-fw.elf', 'ti-pruss/am65x-rtu1-prueth-fw.elf', 'ti-pruss/am65x-txpru1-prueth-fw.elf'], 'ti,pruss-gp-mux-sel': [[2, 2, 2, 2, 2, 2]], 'ti,mii-g-rt': [[4294967295]], 'dmas': [[4294967295, 49920], [4294967295, 49921], [4294967295, 49922], [4294967295, 49923], [4294967295, 49924], [4294967295, 49925], [4294967295, 49926], [4294967295, 49927], [4294967295, 17152], [4294967295, 17153]], 'dma-names': ['tx0-0', 'tx0-1', 'tx0-2', 'tx0-3', 'tx1-0', 'tx1-1', 'tx1-2', 'tx1-3', 'rx0', 'rx1'], 'interrupts': [[24, 0, 2], [25, 1, 3]], 'interrupt-names': ['tx_ts0', 'tx_ts1'], 'ethernet-ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-rxid'], 'interrupts-extended': [[4294967295, 24]], 'ti,syscon-rgmii-delay': [[4294967295, 16672]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}, 'port@1': {'reg': [[1]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-rxid'], 'interrupts-extended': [[4294967295, 25]], 'ti,syscon-rgmii-delay': [[4294967295, 16676]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}}, '$nodename': ['pruss2_eth']} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: pruss2_eth: Unevaluated properties are not allowed ('firmware-name', 'ti,prus', 'ti,pruss-gp-mux-sel' were unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BA3C433EF for ; Tue, 31 May 2022 13:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344713AbiEaNVd (ORCPT ); Tue, 31 May 2022 09:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344700AbiEaNV3 (ORCPT ); Tue, 31 May 2022 09:21:29 -0400 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7D4972A6; Tue, 31 May 2022 06:21:28 -0700 (PDT) Received: by mail-oi1-f176.google.com with SMTP id m82so3421973oif.13; Tue, 31 May 2022 06:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=e5hEwdVyk0aAkl6eSBNPLNwTk/gtSZtsZFRN5GRZ6bA=; b=SLJnrAdPTX9gBHgCOIQUIvxYlWeUh/43uZIeHIbWXD6AgkZXfTsmVFN5/J1axleTgi W0Cv4Udy3xf4gfrDaQJ2zz6HRNdIo4oe8Has8kF5a35m8cB6mvSeB6hLgb2wmGZ5fQ/h MzL/WuStPns1a0DTMplSgAUK579dZESxCV+EFxyvFJ7Kco3zKrg3YmnHqJRJMUB2QrO7 1zYv9b9aqzsRFxxH06dMe8IDa/Z+qpPoVXzaBmIGqdUSVMwm86Cc0lArGHpgWeDfU6Ix MUSRE+Vou+C6XSt13kYA72n4pHOWi49g/UKizwP2QyPexXgNkdJxd6X4vNc7m5Zhv1G+ g9Sw== X-Gm-Message-State: AOAM532+2SN84i6RIgO+cR5M+6d+3gCJf6AiuBP6cV46rMtmUPWGfRgB xYlYGi0twYXqHrcOlpyJyQ== X-Google-Smtp-Source: ABdhPJwc9hEHIr4dNicEv2trxpFWfW7N9CStjs9nOb2xy+SSJhjlsZ6CBFELIq7Zjs0oQODGv2QlAg== X-Received: by 2002:a05:6808:f8c:b0:32a:e67f:d20e with SMTP id o12-20020a0568080f8c00b0032ae67fd20emr11509012oiw.88.1654003287818; Tue, 31 May 2022 06:21:27 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s31-20020a056830439f00b0060613c844adsm6307651otv.10.2022.05.31.06.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 06:21:27 -0700 (PDT) Received: (nullmailer pid 1610161 invoked by uid 1000); Tue, 31 May 2022 13:21:25 -0000 From: Rob Herring To: Puranjay Mohan Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, robh+dt@kernel.org, edumazet@google.com, vigneshr@ti.com, kishon@ti.com, afd@ti.com, davem@davemloft.net, ssantosh@kernel.org, andrew@lunn.ch, krzysztof.kozlowski+dt@linaro.org, grygorii.strashko@ti.com, devicetree@vger.kernel.org, s-anna@ti.com, nm@ti.com, rogerq@kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20220531095108.21757-2-p-mohan@ti.com> References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Date: Tue, 31 May 2022 08:21:25 -0500 Message-Id: <1654003285.283793.1610159.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 31 May 2022 15:21:07 +0530, Puranjay Mohan wrote: > Add a YAML binding document for the ICSSG Programmable real time unit > based Ethernet driver. This driver uses the PRU and PRUSS consumer APIs > to interface the PRUs and load/run the firmware for supporting ethernet > functionality. > > Signed-off-by: Puranjay Mohan > --- > v1: https://lore.kernel.org/all/20220506052433.28087-2-p-mohan@ti.com/ > v1 -> v2: > * Addressed Rob's Comments > * It includes indentation, formatting, and other minor changes. > --- > .../bindings/net/ti,icssg-prueth.yaml | 181 ++++++++++++++++++ > 1 file changed, 181 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: pruss2_eth: False schema does not allow {'compatible': ['ti,am654-icssg-prueth'], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'sram': [[4294967295]], 'ti,prus': [[4294967295, 4294967295, 4294967295, 4294967295, 4294967295, 4294967295]], 'firmware-name': ['ti-pruss/am65x-pru0-prueth-fw.elf', 'ti-pruss/am65x-rtu0-prueth-fw.elf', 'ti-pruss/am65x-txpru0-prueth-fw.elf', 'ti-pruss/am65x-pru1-prueth-fw.elf', 'ti-pruss/am65x-rtu1-prueth-fw.elf', 'ti-pruss/am65x-txpru1-prueth-fw.elf'], 'ti,pruss-gp-mux-sel': [[2, 2, 2, 2, 2, 2]], 'ti,mii-g-rt': [[4294967295]], 'dmas': [[4294967295, 49920], [4294967295, 49921], [4294967295, 49922], [4294967295, 49923], [4294967295, 49924], [4294967295, 49925], [4294967295, 49926], [4294967295, 49927], [4294967295, 17152], [4294967295, 17153]], 'dma-names': ['tx0-0', 'tx0-1', 'tx0-2', 'tx0-3', 'tx1-0', 'tx1-1', 'tx1-2', 'tx1-3', 'rx0', 'rx1'], 'i nterrupts': [[24, 0, 2], [25, 1, 3]], 'interrupt-names': ['tx_ts0', 'tx_ts1'], 'ethernet-ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-rxid'], 'interrupts-extended': [[4294967295, 24]], 'ti,syscon-rgmii-delay': [[4294967295, 16672]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}, 'port@1': {'reg': [[1]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-rxid'], 'interrupts-extended': [[4294967295, 25]], 'ti,syscon-rgmii-delay': [[4294967295, 16676]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}}, '$nodename': ['pruss2_eth']} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: pruss2_eth: Unevaluated properties are not allowed ('firmware-name', 'ti,prus', 'ti,pruss-gp-mux-sel' were unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.