From: "Heiko Stübner" <heiko@sntech.de>
To: David Miller <davem@davemloft.net>
Cc: kuba@kernel.org, robh+dt@kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper
Date: Tue, 16 Jun 2020 11:10:27 +0200 [thread overview]
Message-ID: <1656001.WqWBulSbu3@diego> (raw)
In-Reply-To: <20200615.181225.2016760272076151342.davem@davemloft.net>
Hi,
Am Dienstag, 16. Juni 2020, 03:12:25 CEST schrieb David Miller:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT)
> > + return devm_phy_package_join(&phydev->mdio.dev, phydev,
> > + vsc8531->base_addr, 0);
>
> But it is still dereferenced here.
>
> Did the compiler really not warn you about this when you test built
> these changes?
I'm wondering that myself ... it probably did and I overlooked it, which
also is indicated by the fact that I did add the declaration of the
vsc8531 when rebasing.
> > Because you removed this devm_kzalloc() code, vsc8531 is never initialized.
>
> You also need to provide a proper header posting when you repost this series
> after fixing this bug.
not sure I understand what you mean with "header posting" here.
Thanks
Heiko
next prev parent reply other threads:[~2020-06-16 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 14:44 [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper Heiko Stuebner
2020-06-15 14:45 ` [PATCH v3 2/3] dt-bindings: net: ethernet-phy: add enet-phy-clock-out-frequency Heiko Stuebner
2020-06-15 14:45 ` [PATCH v3 3/3] net: phy: mscc: handle the clkout control on some phy variants Heiko Stuebner
2020-06-15 20:56 ` [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper kernel test robot
2020-06-15 20:56 ` kernel test robot
2020-06-16 1:11 ` David Miller
2020-06-16 1:12 ` David Miller
2020-06-16 9:10 ` Heiko Stübner [this message]
2020-06-16 10:13 ` Russell King - ARM Linux admin
2020-06-16 12:27 ` Dan Carpenter
2020-06-16 12:27 ` [kbuild] " Dan Carpenter
2020-06-16 12:27 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-06-16 11:59 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1656001.WqWBulSbu3@diego \
--to=heiko@sntech.de \
--cc=andrew@lunn.ch \
--cc=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.