From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v4 01/38] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge Date: Thu, 08 Mar 2018 23:44:15 +0100 Message-ID: <1656609.JibIPNoNVJ@phil> References: <20180305222324.5872-1-enric.balletbo@collabora.com> <20180305222324.5872-2-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180305222324.5872-2-enric.balletbo@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Enric Balletbo i Serra Cc: dianders@chromium.org, wzz@rock-chips.com, hl@rock-chips.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, thierry.reding@gmail.com, =?ISO-8859-1?Q?St=E9phane?= Marchesin , orjan.eide@arm.com, m.szyprowski@samsung.com, hshi@chromium.org List-Id: linux-rockchip.vger.kernel.org QW0gTW9udGFnLCA1LiBNw6RyeiAyMDE4LCAyMzoyMjo1MyBDRVQgc2NocmllYiBFbnJpYyBCYWxs ZXRibyBpIFNlcnJhOgo+IEZyb206IHphaW4gd2FuZyA8d3p6QHJvY2stY2hpcHMuY29tPgo+IAo+ IFRoZXJlJ3MgYSByYWNlIGJldHdlZW4gd2hlbiBicmlkZ2VfZGlzYWJsZSBhbmQgd2hlbiB2b3Bf Y3J0Y19kaXNhYmxlCj4gYXJlIGNhbGxlZC4gSWYgdGhlIGZsdXNoIHRpbWVyIHRyaWdnZXJzIGEg bmV3IHBzciB3b3JrIGJldHdlZW4gdGhlc2UsCj4gd2Ugd2lsbCBvcGVyYXRlIGVEUCB3aXRob3V0 IHBvd2VyIHNodXRkb3duZWQgYnkgYnJpZGdlX2Rpc2FibGUuIEluIHRoaXMKPiBjYXNlLCBtb3Zp bmcgYWN0aXZhdGUvZGVhY3RpdmF0ZSB0byBlbmFibGUvZGlzYWJsZSBicmlkZ2UgdG8gYXZvaWQg aXQuCj4gCj4gQ2M6IFN0w6lwaGFuZSBNYXJjaGVzaW4gPG1hcmNoZXVAY2hyb21pdW0ub3JnPgo+ IFNpZ25lZC1vZmYtYnk6IHphaW4gd2FuZyA8d3p6QHJvY2stY2hpcHMuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4gU2lnbmVkLW9mZi1ieTog U2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogVGhpZXJy eSBFc2NhbmRlIDx0aGllcnJ5LmVzY2FuZGVAY29sbGFib3JhLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bjb2xsYWJvcmEuY29tPgoK YWRhcHRlZCB0aGUgc3ViamVjdCB0byBkcm0vcm9ja2NoaXAsIGFzIGl0IG9ubHkgdG91Y2hlcyB0 aGUgcm9ja2NoaXAKZ2x1ZSBkcml2ZXIgZm9yIHRoZSBhbmFsb2dpeF9kcCBhbmQgYXBwbGllZCB0 byBkcm0tbWlzYy1uZXh0IGFmdGVyCmNoZWNraW5nIG9uIGJvdGggcGlua3kgKHJrMzI4OCkgYW5k IGtldmluIChyazMzOTkpLgoKCkhlaWtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750902AbeCHWo0 convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2018 17:44:26 -0500 Received: from gloria.sntech.de ([95.129.55.99]:34092 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbeCHWoZ (ORCPT ); Thu, 8 Mar 2018 17:44:25 -0500 From: Heiko Stuebner To: Enric Balletbo i Serra Cc: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, hshi@chromium.org, wzz@rock-chips.com, hl@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, orjan.eide@arm.com, m.szyprowski@samsung.com, =?ISO-8859-1?Q?St=E9phane?= Marchesin Subject: Re: [PATCH v4 01/38] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge Date: Thu, 08 Mar 2018 23:44:15 +0100 Message-ID: <1656609.JibIPNoNVJ@phil> In-Reply-To: <20180305222324.5872-2-enric.balletbo@collabora.com> References: <20180305222324.5872-1-enric.balletbo@collabora.com> <20180305222324.5872-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 5. März 2018, 23:22:53 CET schrieb Enric Balletbo i Serra: > From: zain wang > > There's a race between when bridge_disable and when vop_crtc_disable > are called. If the flush timer triggers a new psr work between these, > we will operate eDP without power shutdowned by bridge_disable. In this > case, moving activate/deactivate to enable/disable bridge to avoid it. > > Cc: Stéphane Marchesin > Signed-off-by: zain wang > Signed-off-by: Caesar Wang > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Signed-off-by: Enric Balletbo i Serra adapted the subject to drm/rockchip, as it only touches the rockchip glue driver for the analogix_dp and applied to drm-misc-next after checking on both pinky (rk3288) and kevin (rk3399). Heiko