From: patchwork-bot+netdevbpf@kernel.org
To: Petr Machata <petrm@nvidia.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, stephen@networkplumber.org
Subject: Re: [PATCH iproute2 v2] ip: Fix size_columns() invocation that passes a 32-bit quantity
Date: Tue, 05 Jul 2022 16:20:12 +0000 [thread overview]
Message-ID: <165703801294.4255.10482939304957775474.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <2d920d88cf51f48c0201495ce371817523b7ab48.1656411269.git.petrm@nvidia.com>
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Tue, 28 Jun 2022 12:17:31 +0200 you wrote:
> In print_stats64(), the last size_columns() invocation passes number of
> carrier changes as one of the arguments. The value is decoded as a 32-bit
> quantity, but size_columns() expects a 64-bit one. This is undefined
> behavior.
>
> The reason valgrind does not cite this is that the previous size_columns()
> invocations prime the ABI area used for the value transfer. When these
> other invocations are commented away, valgrind does complain that
> "conditional jump or move depends on uninitialised value", as would be
> expected.
>
> [...]
Here is the summary with links:
- [iproute2,v2] ip: Fix size_columns() invocation that passes a 32-bit quantity
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=329fda186156
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-05 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 10:17 [PATCH iproute2 v2] ip: Fix size_columns() invocation that passes a 32-bit quantity Petr Machata
2022-07-05 16:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165703801294.4255.10482939304957775474.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.