From: patchwork-bot+netdevbpf@kernel.org
To: Quentin Monnet <quentin@isovalent.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Remove zlib feature test from Makefile
Date: Wed, 06 Jul 2022 05:40:12 +0000 [thread overview]
Message-ID: <165708601265.4885.2077080305152101341.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220705200456.285943-1-quentin@isovalent.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Tue, 5 Jul 2022 21:04:56 +0100 you wrote:
> The feature test to detect the availability of zlib in bpftool's
> Makefile does not bring much. The library is not optional: it may or may
> not be required along libbfd for disassembling instructions, but in any
> case it is necessary to build feature.o or even libbpf, on which bpftool
> depends.
>
> If we remove the feature test, we lose the nicely formatted error
> message, but we get a compiler error about "zlib.h: No such file or
> directory", which is equally informative. Let's get rid of the test.
>
> [...]
Here is the summary with links:
- [bpf-next] bpftool: Remove zlib feature test from Makefile
https://git.kernel.org/bpf/bpf-next/c/450a8dcb8c7f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-06 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 20:04 [PATCH bpf-next] bpftool: Remove zlib feature test from Makefile Quentin Monnet
2022-07-06 5:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165708601265.4885.2077080305152101341.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.