From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49CBCC433EF for ; Thu, 14 Jul 2022 21:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Mime-Version:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UpfnoStUpz4EJRg7TUfzoXDRL56E/v3xYWqQtWVKC6k=; b=39BEMCJ8zvW/LF OOnUN/4HBY+SEPqho2ALQh9piE+gdVQ+/YYThOelX3GuEHKZz/dvk29D0sLb+Gse8I7NxDKeT+i7f VLTgByrl22duRZ1ibKrfs2IQRkzHljQvofG1SBB4qs6pr8+dZqcfjNj9igfTDN4AzX4YvxYPemVso xt9BP0oinoleDRU8EsPuBKQfker2ea/qR/zTTIufqThWJ47yLRqO6r/6HVHOiCFEHNwTGFoa1hTfZ koLgVTrVapvLQKxHhb5Ghwy4H8m5HPYGwk+3ZtoZABhc6a7hiLOl6sjR6c+n6NiJicJmbes0hKmUn 3kM2Gt1BZcyJS/La5HfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC6MZ-001dIB-9i; Thu, 14 Jul 2022 21:27:11 +0000 Received: from smtp-out3.electric.net ([208.70.128.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC6MV-001dF8-KO for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 21:27:09 +0000 Received: from 1oC6MM-00090K-WA by out3b.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1oC6MQ-00096c-U9; Thu, 14 Jul 2022 14:27:02 -0700 Received: by emcmailer; Thu, 14 Jul 2022 14:27:02 -0700 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3b.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oC6MM-00090K-WA; Thu, 14 Jul 2022 14:26:59 -0700 Received: from tsdebian (97-120-89-198.ptld.qwest.net [97.120.89.198]) by mail.embeddedts.com (Postfix) with ESMTPSA id 9134F4DC; Thu, 14 Jul 2022 14:26:57 -0700 (MST) Message-ID: <1657833995.2979.1.camel@embeddedTS.com> Subject: Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support From: Kris Bahnsen To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Featherston Date: Thu, 14 Jul 2022 14:26:35 -0700 In-Reply-To: <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> References: <20220713221233.8486-1-kris@embeddedTS.com> <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> Organization: embeddedTS X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256 X-Authenticated_ID: X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121;h=Mime-Version:References:In-Reply-To:Date:To:From:Message-ID; bh=GseA+cRnj+YmYAVO5Y69v8C7WrdURv4BgtAoSd0DCpM=;b=hz/WBxV3h4iBrP9vWNGrG4x0jxMVhUxNOPwrX3h7o0QyBiR5HsXN/Bs9/wXVs/g8mZSku/B2FQ7BxxHy2HMleJ620RzIN3meKsr0OopL129w+iS8YtQlm1cZc9fM2omqRfbDAMVWcZ1C6Hmwar03v964/qcteuEuyFNbq0zmzg8GTgS6DERwcCqZT4FPbhy/DqTgizsF6wHXR0SKmWPgotdQCD3jt1mYnO96jx2evGcWAnpRBmUGD10KZe6zf7eo19jiK7ZA0S2DfgXKUjyi/+VjYEDAvL0nhW6RLJedYTc0BShVy6h6NLA1gj7Jad4uUFIkHfHwrVp5twI1FMw/dg==; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_142707_756446_5F2709D5 X-CRM114-Status: GOOD ( 46.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: kris@embeddedTS.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMDIyLTA3LTE0IGF0IDEwOjM0ICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdy b3RlOgo+IE9uIDE0LzA3LzIwMjIgMDA6MTIsIEtyaXMgQmFobnNlbiB3cm90ZToKPiA+IEFkZCBp bml0aWFsIHN1cHBvcnQgb2YgdGhlIGkuTVg2VUwgYmFzZWQgVFMtNzU1My1WMiBwbGF0Zm9ybS4K PiAKPiBVc2Ugc3ViamVjdCBwcmVmaXggbWF0Y2hpbmcgdGhlIHN1YnN5c3RlbS4gZ2l0IGxvZyAt LW9uZWxpbmUgLS0KCkNhbiB5b3UgcGxlYXNlIGVsYWJvcmF0ZT8gVGhlIHN1YmplY3QgcHJlZml4 IGlzICJBUk06IGR0czoiLCBJJ20gbm90CnN1cmUgd2hhdCBpcyBtaXNzaW5nLiBTaG91bGQgaXQg YmUgc29tZXRoaW5nIGxpa2UKIkFSTTogZHRzOiBpbXg2dWwtdHM3NTUzdjI6IiBpbiB0aGlzIGNh c2U/Cgo+IAo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBLcmlzIEJhaG5zZW4gPGtyaXNAZW1iZWRk ZWRUUy5jb20+Cj4gPiAtLS0KPiA+IAo+ID4gVjEtPlYyOiBJbXBsZW1lbnQgY2hhbmdlcyByZWNv bW1lbmRlZCBieSBSb2IgSGVycmluZyBhbmQgZHRic19jaGVjawo+ID4gCj4gPiBSRkMgb25seSwg bm90IHlldCByZWFkeSB0byBtZXJnZSwgbW9yZSB0ZXN0aW5nIG5lZWRlZCBhbmQgd2UncmUgd29y a2luZyBvbgo+ID4gU1BJIExDRCBzdXBwb3J0IGZvciB0aGlzIHBsYXRmb3JtLgo+ID4gCj4gPiBT cGVjaWZpY2FsbHksIEkgaGF2ZSBhIGZldyBxdWVzdGlvbnMgb24gc29tZSBwYXJhZGlnbXMgYW5k IGR0YnNfY2hlY2sgb3V0cHV0Ogo+ID4gCj4gPiBpbXg2dWwtdHM3NTUzdjIuZHRiOiAvOiBpMmMt Z3Bpbzogeydjb21wYXRpYmxlJzogLi4uIFwKPiA+ICdtYWduZXRvbWV0ZXJAYyc6IHsnY29tcGF0 aWJsZSc6IFsnYXNhaGkta2FzZWksYWs4OTc1J10sICdyZWcnOiBbWzEyXV19fX19IFwKPiA+IGlz IG5vdCBvZiB0eXBlICdhcnJheScKPiA+ICAgSSdtIG5vdCBzdXJlIHdoYXQgdGhpcyBlcnJvciBp cyByZWZlcnJpbmcgdG8gYXMgSSd2ZSBjb3BpZWQgdGhlIGV4YW1wbGUgaW4KPiA+ICAgaW52ZW5z ZW5zZSxtcHU2MDUwLnlhbWwgYWxtb3N0IHZlcmJhdGltLiBJcyB0aGlzIGFuIGlzc3VlIHdpdGgg b3VyIHBhdGNoCj4gPiAgIG9yIGEgZmFsc2UgcG9zaXRpdmUgZnJvbSBkdGJzX2NoZWNrPwo+IAo+ IFlvdSB3b3VsZCBuZWVkIHRvIHBhc3RlIGVudGlyZSBlcnJvciwgbWF5YmUgd2l0aCBjaGVja2Vy IGZsYWdzIC12LgoKSGVyZSBpcyB0aGUgdmVyYm9zZSBvdXRwdXQuIEknbSBub3QgZmFtaWxpYXIg ZW5vdWdoIHlldCB3aXRoIHRoZSBzY2hlbWEgYW5kIGl0cwp2YWxpZGF0aW9uIGNvZGUgdG8gY2F0 Y2ggd2hhdCBpcyB3cm9uZyBhbmQgd291bGQgYXBwcmVjaWF0ZSBhbnkgaW5zaWdodC4KCkNoZWNr OiAgYXJjaC9hcm0vYm9vdC9kdHMvaW14NnVsLXRzNzU1M3YyLmR0Ygovd29yay9hcmNoL2FybS9i b290L2R0cy9pbXg2dWwtdHM3NTUzdjIuZHRiOiAvOiBpMmMtZ3Bpbzogeydjb21wYXRpYmxlJzog WydpMmMtZ3BpbyddLCBcCicjYWRkcmVzcy1jZWxscyc6IFtbMV1dLCAnI3NpemUtY2VsbHMnOiBb WzBdXSwgJ3BpbmN0cmwtbmFtZXMnOiBbJ2RlZmF1bHQnXSwgXAoncGluY3RybC0wJzogW1s1OF1d LCAnc2RhLWdwaW9zJzogW1sxMSwgNSwgNl1dLCAnc2NsLWdwaW9zJzogW1sxMSwgNCwgNl1dLCBc CidpbXVANjgnOiB7J2NvbXBhdGlibGUnOiBbJ2ludmVuc2Vuc2UsbXB1OTI1MCddLCAncmVnJzog W1sxMDRdXSwgXAonaW50ZXJydXB0LXBhcmVudCc6IFtbNTVdXSwgJ2ludGVycnVwdHMnOiBbWzEs IDFdXSwgJ2kyYy1nYXRlJzogeycjYWRkcmVzcy1jZWxscyc6IFtbMV1dLCBcCicjc2l6ZS1jZWxs cyc6IFtbMF1dLCAnbWFnbmV0b21ldGVyQGMnOiB7J2NvbXBhdGlibGUnOiBbJ2FzYWhpLWthc2Vp LGFrODk3NSddLCBcCidyZWcnOiBbWzEyXV19fX19IGlzIG5vdCBvZiB0eXBlICdhcnJheScKCkZh aWxlZCB2YWxpZGF0aW5nICd0eXBlJyBpbiBzY2hlbWFbJ3BhdHRlcm5Qcm9wZXJ0aWVzJ11bJyg/ PCEsbnIpLWdwaW9zPyQnXToKICAgIHsnaXRlbXMnOiB7J2FkZGl0aW9uYWxJdGVtcyc6IHsnJHJl Zic6ICcjL2RlZmluaXRpb25zL2NlbGwnfSwKICAgICAgICAgICAgICAgJ2l0ZW1zJzogW3snb25l T2YnOiBbeydtYXhpbXVtJzogNDI5NDk2NzI5NSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdtaW5pbXVtJzogMSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICdwaGFuZGxlJzogVHJ1ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICd0eXBlJzogJ2ludGVnZXInfSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg eydjb25zdCc6IDAsICd0eXBlJzogJ2ludGVnZXInfV19XSwKICAgICAgICAgICAgICAgJ21pbkl0 ZW1zJzogMSwKICAgICAgICAgICAgICAgJ3R5cGUnOiAnYXJyYXknfSwKICAgICAnbWluSXRlbXMn OiAxLAogICAgICd0eXBlJzogJ2FycmF5J30KCk9uIGluc3RhbmNlWydpMmMtZ3BpbyddOgogICAg eycjYWRkcmVzcy1jZWxscyc6IFtbMV1dLAogICAgICcjc2l6ZS1jZWxscyc6IFtbMF1dLAogICAg ICdjb21wYXRpYmxlJzogWydpMmMtZ3BpbyddLAogICAgICdpbXVANjgnOiB7J2NvbXBhdGlibGUn OiBbJ2ludmVuc2Vuc2UsbXB1OTI1MCddLAogICAgICAgICAgICAgICAgJ2kyYy1nYXRlJzogeycj YWRkcmVzcy1jZWxscyc6IFtbMV1dLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjc2l6 ZS1jZWxscyc6IFtbMF1dLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICdtYWduZXRvbWV0 ZXJAYyc6IHsnY29tcGF0aWJsZSc6IFsnYXNhaGkta2FzZWksYWs4OTc1J10sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdyZWcnOiBbWzEyXV19fSwKICAg ICAgICAgICAgICAgICdpbnRlcnJ1cHQtcGFyZW50JzogW1s1NV1dLAogICAgICAgICAgICAgICAg J2ludGVycnVwdHMnOiBbWzEsIDFdXSwKICAgICAgICAgICAgICAgICdyZWcnOiBbWzEwNF1dfSwK ICAgICAncGluY3RybC0wJzogW1s1OF1dLAogICAgICdwaW5jdHJsLW5hbWVzJzogWydkZWZhdWx0 J10sCiAgICAgJ3NjbC1ncGlvcyc6IFtbMTEsIDQsIDZdXSwKICAgICAnc2RhLWdwaW9zJzogW1sx MSwgNSwgNl1dfQogICAgICAgIEZyb20gc2NoZW1hOiAvdXNyL2xvY2FsL2xpYi9weXRob24zLjkv ZGlzdC1wYWNrYWdlcy9kdHNjaGVtYS9zY2hlbWFzL2dwaW8vZ3Bpby1jb25zdW1lci55YW1sCgo+ IAo+ID4gCj4gPiAKPiA+IGlteDZ1bC10czc1NTN2Mi5kdGI6IHNwaUAyMDEwMDAwOiBzcGlkZXZA MTogJ2NvbXBhdGlibGUnIGlzIGEgcmVxdWlyZWQgcHJvcGVydHkKPiA+ICAgTWFueSBvZiBvdXIg ZGV2aWNlcyBoYXZlIG9wZW4tZW5kZWQgSTJDIGFuZCBTUEkgcG9ydHMgdGhhdCBtYXkgb3IgbWF5 IG5vdCBiZQo+ID4gICB1c2VkIGluIGN1c3RvbWVyIGFwcGxpY2F0aW9ucy4gV2l0aCAic3BpZGV2 IiBjb21wYXRpYmxlIHN0cmluZyBubyBsb25nZXIKPiA+ICAgc3VwcG9ydGVkLCB0aGVyZSBpcyBu byBlYXN5IHdheSB3ZSBrbm93IG9mIHRvIGxlYXZlIGEgcGxhY2Vob2xkZXIgb3IKPiA+ICAgaW5k aWNhdGlvbiB0aGF0IHRoZSBpbnRlcmZhY2UgaXMgcHJlc2VudCwgdXNhYmxlLCBhbmQgZWl0aGVy IG5lZWRzIHNwZWNpZmljCj4gPiAgIHN1cHBvcnQgZW5hYmxlZCBpbiBrZXJuZWwgb3IgdXNlcnNw YWNlIGFjY2VzcyB2aWEgL2Rldi8uIFdlIHdvdWxkIGxvdmUKPiA+ICAgZmVlZGJhY2sgb24gaG93 IHRvIGhhbmRsZSB0aGlzIHNpdHVhdGlvbiB3aGVuIHN1Ym1pdHRpbmcgcGxhdGZvcm1zIHVwc3Ry ZWFtLgo+IAo+IE5vIGVtcHR5IGRldmljZXMsIGVzcGVjaWFsbHkgZm9yIHNwaWRldiBpbiBEVFMu IFRoZXJlIGlzIHJlYWxseSBubwo+IHNpbmdsZSBuZWVkIHRvIGFkZCBmYWtlIHNwaWRldi4uLiBy ZWFsbHksIHdoeT8gVGhlIGN1c3RvbWVyIGNhbm5vdCByZWFkCj4gaGFyZHdhcmUgbWFudWFsIGFu ZCBjYW5ub3Qgc2VlIHRoZSBoZWFkZXIgb24gdGhlIGJvYXJkPyBZb3UgY2FuIGdpdmUgaGltCj4g YSB0dXRvcmlhbC9ob3d0byBndWlkZSwgYnV0IGRvbid0IGVtYmVkIGRlYWQgb3Igbm9uLXJlYWwg Y29kZSBpbiBEVFMuCgpXZSBzaGlwIGRldmljZXMgYXMgYm9vdGFibGUgb3V0IG9mIHRoZSBib3gu IEEgbnVtYmVyIG9mIG91ciBjdXN0b21lcnMgZW5kIHVwCmF0dGFjaGluZyBTUEkgZGV2aWNlcyB0 aGF0IGRvIG5vdCBoYXZlIGV4aXN0aW5nIGtlcm5lbCBkcml2ZXJzIGFuZCB0YWxrIHRvIHRoZW0K ZnJvbSB1c2Vyc3BhY2Ugd2l0aG91dCBoYXZpbmcgdG8gdG91Y2ggYSBrZXJuZWwgYnVpbGQuIFRo ZSBsb3NzIG9mIHNwaWRldgpkaXJlY3RseSBoYXMgaW5jcmVhc2VkIHN1cHBvcnQgcmVxdWVzdHMg d2UgcmVjZWl2ZSBvbiB0aGUgbWF0dGVyLgoKPiAKPiA+IAo+ID4gCj4gPiBpbXg2dWwtdHM3NTUz djIuZHRiOiB3aWZpQDA6IGNvbXBhdGlibGU6MDogJ21pY3JvY2hpcCx3aWxjMTAwMCcgd2FzIGV4 cGVjdGVkCj4gPiBpbXg2dWwtdHM3NTUzdjIuZHRiOiB3aWZpQDA6IGNvbXBhdGlibGU6IFsnbWlj cm9jaGlwLHdpbGMzMDAwJy4uLl0gaXMgdG9vIGxvbmcKPiA+IGlteDZ1bC10czc1NTN2Mi5kdGI6 IHdpZmlAMDogJ2NoaXBfZW4tZ3Bpb3MnIGRvZXMgbm90IG1hdGNoIGFueSBvZiB0aGUgXAo+ID4g cmVnZXhlczogcGluY3RybC1bMC05XSsnCj4gPiAgIEFzIG5vdGVkIGluIHRoZSBjb21tZW50cyBp biB0aGUgZHRzLCB0aGUgV0lMQzEwMDAgaW4ta2VybmVsIGRyaXZlciBkb2Vzbid0Cj4gPiAgIHN1 cHBvcnQgdGhlIEJMRSBmZWF0dXJlcyBvZiB0aGUgV0lMQzMwMDAuIFdlIG1haW50YWluIGFuIGV4 dGVybmFsIG1vZHVsZQo+ID4gICB0cmVlIHRoYXQgbGV0cyB1cyBidWlsZCBNaWNyb2NoaXAncyBv ZmZpY2lhbCBkcml2ZXIgd2l0aCBXSUxDMzAwMCBzdXBwb3J0Lgo+ID4gICBXb3VsZCB0aGUgZXh0 cmFuZW91cyBjb21wYXRpYmxlIHN0cmluZyBhbmQgcHJvcGVydHkgYmUgYWNjZXB0ZWQgdXBzdHJl YW0KPiA+ICAgaW4gbGlnaHQgb2YgdGhpcz8KPiAKPiBOby4gTm8gdW5kb2N1bWVudGVkIGNvbWFw dGlibGVzIHdpdGggc29tZSB3cm9uZyBwcm9wZXJ0aWVzLiBjaGlwX2VuIGlzCj4gY2xlYXJseSB3 cm9uZywgc28gaXQgY2Fubm90IGdvIHRvIERUUy4gVXBzdHJlYW0gZHJpdmVyIG9yIHJlbW92ZSB0 aGUgbm9kZS4KClVuZm9ydHVuYXRlLCBidXQsIHVuZGVyc3Rvb2QuCgo+IAo+ID4gCj4gPiAKPiA+ ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL2ZzbC55YW1sIHwgICAgMSAr Cj4gCj4gVGhpcyBpcyBhIHNlcGFyYXRlIHBhdGNoLgoKTWFrZXMgc2Vuc2UuCgo+IAo+ID4gIGFy Y2gvYXJtL2Jvb3QvZHRzL01ha2VmaWxlICAgICAgICAgICAgICAgICAgICAgfCAgICAxICsKPiA+ ICBhcmNoL2FybS9ib290L2R0cy9pbXg2dWwtdHM3NTUzdjIuZHRzICAgICAgICAgIHwgIDY5MyAr KysrKysrKysrCj4gPiAgYXJjaC9hcm0vY29uZmlncy90czc5NzBfZGVmY29uZmlnICAgICAgICAg ICAgICB8IDE2MjcgKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgYXJjaC9hcm0vY29uZmln cy90c2lteDZ1bF9kZWZjb25maWcgICAgICAgICAgICB8ICA5NjcgKysrKysrKysrKysrKysKPiAK PiBUaGlzIGFzIHdlbGwgKGFuZCB3b24ndCBiZSBhY2NlcHRlZCAtIG5vIG5ldyBkZWZjb25maWdz KS4KClRoZSBkZWZjb25maWdzIGJlaW5nIGluY2x1ZGVkIHdlcmUgYW4gb3ZlcnNpZ2h0IGFuZCBh YnNvbHV0ZWx5IHNsb3BweSBvbiBteQpwYXJ0LiBJIHNpbmNlcmVseSBhcG9sb2dpemUgZm9yIHRo YXQuCgo+IAo+ID4gCj4gPiArCj4gPiArCWxlZHMgewo+ID4gKwkJcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKPiA+ICsJCXBpbmN0cmwtMCA9IDwmcGluY3RybF9ncGlvX2xlZHM+Owo+ID4gKwkJ Y29tcGF0aWJsZSA9ICJncGlvLWxlZHMiOwo+ID4gKwo+ID4gKwkJZ3JlZW4tbGVkIHsKPiAKPiBs ZWQtMAo+IAo+ID4gKwkJCWxhYmVsID0gImdyZWVuLWxlZCI7Cj4gCj4gUmF0aGVyIHVzZSBjb2xv ciBhbmQgZnVuY3Rpb24sIHRoZW4gbGFiZWxzLgoKRml4ZWQsIHRoYW5rIHlvdS4gSSB3YXMgdW5h d2FyZSBvZiB0aGlzIG5ld2VyIHNldCBvZiBwcm9wZXJ0aWVzIGFuZCBJJ3ZlCmZvdW5kIHdoZXJl IHRoZXkgYXJlIGNsZWFybHkgc3BlbGxlZCBvdXQuCgo+IAo+ID4gKwo+ID4gKwlncGlvLWtleXMg ewo+ID4gKwkJY29tcGF0aWJsZSA9ICJncGlvLWtleXMiOwo+ID4gKwkJcGluY3RybC1uYW1lcyA9 ICJkZWZhdWx0IjsKPiA+ICsJCXBpbmN0cmwtMCA9IDwmcGluY3RybF9ncGlvX2tleXM+Owo+ID4g Kwo+ID4gKwkJbGVmdCB7Cj4gCj4gVGhpcyBmYWlscyBvbiBkdGJzX2NoZWNrLiBHZW5lcmljIG5v ZGUgbmFtZXMsIHNvICJrZXktMCIgb3IgImtleS1sZWZ0IgoKRm9yIHJlZmVyZW5jZSwgYXMgb2Yg Y29tbWl0IGIwNDc2MDJkNTc5YjRmYjAyODEyOGE1MjVmMDU2YmJkYzg5MGU3ZjAsIHRoZXJlCmFy ZSBubyBlcnJvcnMvd2FybmluZ3MgZnJvbSBkdGJzX2NoZWNrIG9yIGNoZWNrcGF0Y2gucGwgcmVn YXJkaW5nIG5vZGUKbmFtZXMgYmVpbmcgImtleS0uLi4iIGFuZCB0aGUgZXhhbXBsZSBpbiBncGlv LWtleXMueWFtbCB1c2VzICJ1cCIgImxlZnQiIGV0Yy4KCkkndmUgYWxzbyBjaGFuZ2VkIHRoZSBu b2RlIG5hbWUgdG8ganVzdCAia2V5cyIgcGVyIGRldmljZXRyZWUgc3BlY2lmaWNhdGlvbnMKZG9j LgoKPiAKPiA+ICsJaTJjX2dwaW86IGkyYy1ncGlvIHsKPiAKPiBHZW5lcmljIG5vZGUgbmFtZSwg c28gImkyYyIKClVuZGVyc3Rvb2QuCgpBcmUgdGhlcmUgYW55IGd1aWRlbGluZXMvcmVzdHJpY3Rp b25zIG9uIGxhYmVsIHVzZS9zY2hlbWHCoAp0aHJvdWdob3V0IGEgZHRzIGZpbGU/IFRoZSBkZXZp Y2V0cmVlLXNwZWNpZmljYXRpb24gZG9jdW1lbnQgb25seSBkZWZpbmVzCnZhbGlkIGNoYXJhY3Rl cnMgZm9yIGEgbGFiZWwgYW5kIEkndmUgYmVlbiB1bmFibGUgdG8gZmluZCBhbnkgb3RoZXIgZG9j cy4KCj4gCj4gPiArCQljb21wYXRpYmxlID0gImkyYy1ncGlvIjsKPiA+ICsJCXBpbmN0cmwtbmFt ZXMgPSAiZGVmYXVsdCI7Cj4gPiArCQlwaW5jdHJsLTAgPSA8JnBpbmN0cmxfaTJjZ3Bpbz47Cj4g PiArCQlzZGEtZ3Bpb3MgPSA8JmdwaW81IDUgKEdQSU9fQUNUSVZFX0hJR0h8R1BJT19PUEVOX0RS QUlOKT47Cj4gPiArCQlzY2wtZ3Bpb3MgPSA8JmdwaW81IDQgKEdQSU9fQUNUSVZFX0hJR0h8R1BJ T19PUEVOX0RSQUlOKT47Cj4gPiArCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+ICsJCSNzaXpl LWNlbGxzID0gPDA+Owo+ID4gKwkJc3RhdHVzID0gIm9rYXkiOwo+IAo+IFdoeSBkbyB5b3UgYWRk IHN0YXR1cz8gSXNuJ3QgdGhpcyBhIG5ldyBub2RlPwoKVGhhdCB3YXMgbXkgbWlzdGFrZSwgUm9i IHBvaW50ZWQgaXQgb3V0IGluIHYxIGFuZCBJIGZvcmdvdCB0byByZW1vdmUgaXQuCgo+IAo+ID4g Kwo+ID4gKwlwaW5jdHJsX2kyY2dwaW86IGkyY2dycGdwaW8gewo+IAo+IE5hbWUgbm90IG1hdGNo aW5nIHNjaGVtYSwgYXMgdGhleSBtdXN0IGVuZCB3aXRoIGdycC4gRGVyaXZlIHlvdXIgYm9hcmQK PiBmcm9tIHNvbWV0aGluZyBuZXcsIG5vdCBhbmNpZW50Li4uCj4gPiArCj4gPiArCXBpbmN0cmxf dXNkaGMxXzEwMG1oejogdXNkaGMxZ3JwMTAwbWh6IHsKPiAKPiBTYW1lLgo+IAo+ID4gCj4gPiAr Cj4gPiArCXBpbmN0cmxfdXNkaGMxXzIwMG1oejogdXNkaGMxZ3JwMjAwbWh6IHsKPiAKPiBObyBy ZWFsbHkuLi4KPiAKClRoYW5rcyBmb3IgcG9pbnRpbmcgdGhpcyBvdXQsIEkgd2FzIHVuYWJsZSB0 byBmaW5kIGFueSBzcGVjaWZpYyBkb2NzIG9uIHRoZQpwaW5jdHJsIG5vZGUgbmFtZSBzY2hlbWEg YW5kIGR0YnNfY2hlY2sgZ2F2ZSBubyBlcnJvcnMgb24gaXQuCgo+ID4gCj4gPiArfTsKPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybS9jb25maWdzL3RzNzk3MF9kZWZjb25maWcgYi9hcmNoL2FybS9j b25maWdzL3RzNzk3MF9kZWZjb25maWcKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRl eCAwMDAwMDAwMDAwMDAuLmE5NjgzMTc1MjQ0OQo+IAo+IFJlc3QgaXMgbm90IGFjY2VwdGVkIGFz IG5vdCBleHBsYWluZWQvanVzdGlmaWVkLgo+IAo+IAo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0 b2YKCk1hbnkgdGhhbmtzIGZvciB0aGUgcmV2aWV3LiAKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53160C433EF for ; Thu, 14 Jul 2022 21:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240810AbiGNV1H (ORCPT ); Thu, 14 Jul 2022 17:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240795AbiGNV1G (ORCPT ); Thu, 14 Jul 2022 17:27:06 -0400 Received: from smtp-out3.electric.net (smtp-out3.electric.net [208.70.128.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D62B6D9FF; Thu, 14 Jul 2022 14:27:05 -0700 (PDT) Received: from 1oC6MM-00090K-WA by out3b.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1oC6MQ-00096c-U9; Thu, 14 Jul 2022 14:27:02 -0700 Received: by emcmailer; Thu, 14 Jul 2022 14:27:02 -0700 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3b.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oC6MM-00090K-WA; Thu, 14 Jul 2022 14:26:59 -0700 Received: from tsdebian (97-120-89-198.ptld.qwest.net [97.120.89.198]) by mail.embeddedts.com (Postfix) with ESMTPSA id 9134F4DC; Thu, 14 Jul 2022 14:26:57 -0700 (MST) Message-ID: <1657833995.2979.1.camel@embeddedTS.com> Subject: Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support From: Kris Bahnsen Reply-To: kris@embeddedTS.com To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Featherston Date: Thu, 14 Jul 2022 14:26:35 -0700 In-Reply-To: <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> References: <20220713221233.8486-1-kris@embeddedTS.com> <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> Organization: embeddedTS Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256 X-Authenticated_ID: X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121;h=Mime-Version:References:In-Reply-To:Date:To:From:Message-ID; bh=GseA+cRnj+YmYAVO5Y69v8C7WrdURv4BgtAoSd0DCpM=;b=hz/WBxV3h4iBrP9vWNGrG4x0jxMVhUxNOPwrX3h7o0QyBiR5HsXN/Bs9/wXVs/g8mZSku/B2FQ7BxxHy2HMleJ620RzIN3meKsr0OopL129w+iS8YtQlm1cZc9fM2omqRfbDAMVWcZ1C6Hmwar03v964/qcteuEuyFNbq0zmzg8GTgS6DERwcCqZT4FPbhy/DqTgizsF6wHXR0SKmWPgotdQCD3jt1mYnO96jx2evGcWAnpRBmUGD10KZe6zf7eo19jiK7ZA0S2DfgXKUjyi/+VjYEDAvL0nhW6RLJedYTc0BShVy6h6NLA1gj7Jad4uUFIkHfHwrVp5twI1FMw/dg==; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2022-07-14 at 10:34 +0200, Krzysztof Kozlowski wrote: > On 14/07/2022 00:12, Kris Bahnsen wrote: > > Add initial support of the i.MX6UL based TS-7553-V2 platform. > > Use subject prefix matching the subsystem. git log --oneline -- Can you please elaborate? The subject prefix is "ARM: dts:", I'm not sure what is missing. Should it be something like "ARM: dts: imx6ul-ts7553v2:" in this case? > > > > > Signed-off-by: Kris Bahnsen > > --- > > > > V1->V2: Implement changes recommended by Rob Herring and dtbs_check > > > > RFC only, not yet ready to merge, more testing needed and we're working on > > SPI LCD support for this platform. > > > > Specifically, I have a few questions on some paradigms and dtbs_check output: > > > > imx6ul-ts7553v2.dtb: /: i2c-gpio: {'compatible': ... \ > > 'magnetometer@c': {'compatible': ['asahi-kasei,ak8975'], 'reg': [[12]]}}}} \ > > is not of type 'array' > > I'm not sure what this error is referring to as I've copied the example in > > invensense,mpu6050.yaml almost verbatim. Is this an issue with our patch > > or a false positive from dtbs_check? > > You would need to paste entire error, maybe with checker flags -v. Here is the verbose output. I'm not familiar enough yet with the schema and its validation code to catch what is wrong and would appreciate any insight. Check: arch/arm/boot/dts/imx6ul-ts7553v2.dtb /work/arch/arm/boot/dts/imx6ul-ts7553v2.dtb: /: i2c-gpio: {'compatible': ['i2c-gpio'], \ '#address-cells': [[1]], '#size-cells': [[0]], 'pinctrl-names': ['default'], \ 'pinctrl-0': [[58]], 'sda-gpios': [[11, 5, 6]], 'scl-gpios': [[11, 4, 6]], \ 'imu@68': {'compatible': ['invensense,mpu9250'], 'reg': [[104]], \ 'interrupt-parent': [[55]], 'interrupts': [[1, 1]], 'i2c-gate': {'#address-cells': [[1]], \ '#size-cells': [[0]], 'magnetometer@c': {'compatible': ['asahi-kasei,ak8975'], \ 'reg': [[12]]}}}} is not of type 'array' Failed validating 'type' in schema['patternProperties']['(? > > > > > > imx6ul-ts7553v2.dtb: spi@2010000: spidev@1: 'compatible' is a required property > > Many of our devices have open-ended I2C and SPI ports that may or may not be > > used in customer applications. With "spidev" compatible string no longer > > supported, there is no easy way we know of to leave a placeholder or > > indication that the interface is present, usable, and either needs specific > > support enabled in kernel or userspace access via /dev/. We would love > > feedback on how to handle this situation when submitting platforms upstream. > > No empty devices, especially for spidev in DTS. There is really no > single need to add fake spidev... really, why? The customer cannot read > hardware manual and cannot see the header on the board? You can give him > a tutorial/howto guide, but don't embed dead or non-real code in DTS. We ship devices as bootable out of the box. A number of our customers end up attaching SPI devices that do not have existing kernel drivers and talk to them from userspace without having to touch a kernel build. The loss of spidev directly has increased support requests we receive on the matter. > > > > > > > imx6ul-ts7553v2.dtb: wifi@0: compatible:0: 'microchip,wilc1000' was expected > > imx6ul-ts7553v2.dtb: wifi@0: compatible: ['microchip,wilc3000'...] is too long > > imx6ul-ts7553v2.dtb: wifi@0: 'chip_en-gpios' does not match any of the \ > > regexes: pinctrl-[0-9]+' > > As noted in the comments in the dts, the WILC1000 in-kernel driver doesn't > > support the BLE features of the WILC3000. We maintain an external module > > tree that lets us build Microchip's official driver with WILC3000 support. > > Would the extraneous compatible string and property be accepted upstream > > in light of this? > > No. No undocumented comaptibles with some wrong properties. chip_en is > clearly wrong, so it cannot go to DTS. Upstream driver or remove the node. Unfortunate, but, understood. > > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > > This is a separate patch. Makes sense. > > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/imx6ul-ts7553v2.dts | 693 ++++++++++ > > arch/arm/configs/ts7970_defconfig | 1627 ++++++++++++++++++++++++ > > arch/arm/configs/tsimx6ul_defconfig | 967 ++++++++++++++ > > This as well (and won't be accepted - no new defconfigs). The defconfigs being included were an oversight and absolutely sloppy on my part. I sincerely apologize for that. > > > > > + > > + leds { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_leds>; > > + compatible = "gpio-leds"; > > + > > + green-led { > > led-0 > > > + label = "green-led"; > > Rather use color and function, then labels. Fixed, thank you. I was unaware of this newer set of properties and I've found where they are clearly spelled out. > > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_keys>; > > + > > + left { > > This fails on dtbs_check. Generic node names, so "key-0" or "key-left" For reference, as of commit b047602d579b4fb028128a525f056bbdc890e7f0, there are no errors/warnings from dtbs_check or checkpatch.pl regarding node names being "key-..." and the example in gpio-keys.yaml uses "up" "left" etc. I've also changed the node name to just "keys" per devicetree specifications doc. > > > + i2c_gpio: i2c-gpio { > > Generic node name, so "i2c" Understood. Are there any guidelines/restrictions on label use/schema  throughout a dts file? The devicetree-specification document only defines valid characters for a label and I've been unable to find any other docs. > > > + compatible = "i2c-gpio"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2cgpio>; > > + sda-gpios = <&gpio5 5 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > > + scl-gpios = <&gpio5 4 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "okay"; > > Why do you add status? Isn't this a new node? That was my mistake, Rob pointed it out in v1 and I forgot to remove it. > > > + > > + pinctrl_i2cgpio: i2cgrpgpio { > > Name not matching schema, as they must end with grp. Derive your board > from something new, not ancient... > > + > > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz { > > Same. > > > > > + > > + pinctrl_usdhc1_200mhz: usdhc1grp200mhz { > > No really... > Thanks for pointing this out, I was unable to find any specific docs on the pinctrl node name schema and dtbs_check gave no errors on it. > > > > +}; > > diff --git a/arch/arm/configs/ts7970_defconfig b/arch/arm/configs/ts7970_defconfig > > new file mode 100644 > > index 000000000000..a96831752449 > > Rest is not accepted as not explained/justified. > > > Best regards, > Krzysztof Many thanks for the review.