From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3496CC43334 for ; Fri, 15 Jul 2022 17:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Mime-Version:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uh2wCbf7Lm6T6CCHbD3fu39NqdNR+cWl8W5acF803VA=; b=IfmG5qFCyE1XiZ oua9Io9JSr3GyhVvl/9A8txwBncYe5XftZcHSqlrq4fmBEd/TLZaXDBxwiFUf1DWsh6YNwnupGfd0 d1wrPEIEFKu73r9hBgxjrmnAkqs9TK/TSvdxxup3T5nUywPxcl27RsHJsggUKSUBA+osFlvsnX2Rg ufWPbkuXax0Fgqv3CX5IsbvR2qBTOgVY6HIUGjoa8N6RoWX+Sfbj+fk/+nb65zfV2ukT77tOjl1OZ 9B1lEXrL4gpapl+6JZftHL/J1qkm+I1PXtaywb4gOzvwmyqqVHbGIdoE+/1Vln4jJmgW26AQ7cTSd 3xyEn8kizrubJAK1O/OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCPX2-009IbT-GR; Fri, 15 Jul 2022 17:55:16 +0000 Received: from smtp-out3.electric.net ([208.70.128.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCPWy-009IPt-Fe for linux-arm-kernel@lists.infradead.org; Fri, 15 Jul 2022 17:55:14 +0000 Received: from 1oCPWT-000BsI-W3 by out3a.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1oCPWb-000C2b-Uv; Fri, 15 Jul 2022 10:54:49 -0700 Received: by emcmailer; Fri, 15 Jul 2022 10:54:49 -0700 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3a.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oCPWT-000BsI-W3; Fri, 15 Jul 2022 10:54:41 -0700 Received: from tsdebian (97-120-89-198.ptld.qwest.net [97.120.89.198]) by mail.embeddedts.com (Postfix) with ESMTPSA id E09C21C0A; Fri, 15 Jul 2022 10:54:40 -0700 (MST) Message-ID: <1657907657.2829.1.camel@embeddedTS.com> Subject: Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support From: Kris Bahnsen To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Featherston Date: Fri, 15 Jul 2022 10:54:17 -0700 In-Reply-To: References: <20220713221233.8486-1-kris@embeddedTS.com> <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> <1657833995.2979.1.camel@embeddedTS.com> Organization: embeddedTS X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256 X-Authenticated_ID: X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121;h=Mime-Version:References:In-Reply-To:Date:To:From:Message-ID; bh=dxvJjUrX64Cs5hkRtbhBYZ+CBeeqYYUwDDG4GscCgRg=;b=RCNRIPqG09r6kH74N7as77/3G7UZC/jdj5YvhraTRW4wujMa1l3NoCN2JRBjhbjL5PYW+69kXwBTzLYLRUeBob/vE+nszuiHZWnjSpRt0RHh/stQGD/6yo5O1NsCs3apgzZd5IvSOAnhuOgEnCNENPR9hudArlDpMtzkzTNBE8hW0ItYHd8Jsyk9mzToxeftTRmpxiXX0keBzL++UcnZKYmlSKnQipOlWRK9DoMo6gTHsKNqosF/3MOGWpRaWZXcx9l9/oMukJt2QdES/5ROglhoD6nj0FBnQNZf8RjjnTHM/82vGjSklGem2ypr40yBDtmbCTRv1ulIjGi4vdq5OQ==; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_105512_577775_0C9007AE X-CRM114-Status: GOOD ( 48.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: kris@embeddedTS.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMDIyLTA3LTE1IGF0IDA4OjQyICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdy b3RlOgo+IE9uIDE0LzA3LzIwMjIgMjM6MjYsIEtyaXMgQmFobnNlbiB3cm90ZToKPiA+IE9uIFRo dSwgMjAyMi0wNy0xNCBhdCAxMDozNCArMDIwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiA+ID4gT24gMTQvMDcvMjAyMiAwMDoxMiwgS3JpcyBCYWhuc2VuIHdyb3RlOgo+ID4gPiA+IEFk ZCBpbml0aWFsIHN1cHBvcnQgb2YgdGhlIGkuTVg2VUwgYmFzZWQgVFMtNzU1My1WMiBwbGF0Zm9y bS4KPiA+ID4gCj4gPiA+IFVzZSBzdWJqZWN0IHByZWZpeCBtYXRjaGluZyB0aGUgc3Vic3lzdGVt LiBnaXQgbG9nIC0tb25lbGluZSAtLQo+ID4gCj4gPiBDYW4geW91IHBsZWFzZSBlbGFib3JhdGU/ IFRoZSBzdWJqZWN0IHByZWZpeCBpcyAiQVJNOiBkdHM6IiwgSSdtIG5vdAo+ID4gc3VyZSB3aGF0 IGlzIG1pc3NpbmcuIFNob3VsZCBpdCBiZSBzb21ldGhpbmcgbGlrZQo+ID4gIkFSTTogZHRzOiBp bXg2dWwtdHM3NTUzdjI6IiBpbiB0aGlzIGNhc2U/Cj4gCj4gUnVuIHRoZSBjb21tYW5kLCB5b3Ug d2lsbCBzZWUuCgpJIGhhZCBwcmV2aW91c2x5IHJ1biB0aGUgY29tbWFuZCBhbmQgdGhlIG91dHB1 dCBvZiBpdCBkaWQgbm90IG1ha2Ugc2Vuc2UgaW4KdGhlIGNvbnRleHQgb2YgeW91ciBwcmlvciBj b21tZW50LiBGb3JnaXZlIG15IGlnbm9yYW5jZSwgYnV0IEknZCBsaWtlIHRvCnVuZGVyc3RhbmQg c3BlY2lmaWNhbGx5IHdoYXQgeW91IG1lYW4gaGVyZSBzbyB3ZSBjYW4gZG8gdGhlIGNvcnJlY3Qg dGhpbmcKaW4gdGhlIGZ1dHVyZS4KCiQgZ2l0IGxvZyAtLW9uZWxpbmUgLS0gfCBoZWFkIC1uIDIw CmQxNGVlMmQ1YTUwNiBBUk06IGR0czogQWRkIFRTLTc1NTMtVjIgc3VwcG9ydApiMDQ3NjAyZDU3 OWIgTWVyZ2UgdGFnICd0cmFjZS12NS4xOS1yYzUnIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1 Yi9zY20vbGludXgva2VybmVsL2dpdC9yb3N0ZWR0L2xpbnV4LXRyYWNlCjFlMWZiNDIwZmU2OCBz YW1wbGVzOiBVc2UgS1NZTV9OQU1FX0xFTiBmb3Iga3Byb2JlcwplMzY1NWRmYTU4MDUgZnByb2Jl L3NhbXBsZXM6IE1ha2Ugc2FtcGxlX3Byb2JlIHN0YXRpYwowYmI3ZTE0YzhlMTUgYmxrLWlvY29z dDogdHJhY2luZzogYXRvbWljNjRfcmVhZCgmaW9jLT52dGltZV9yYXRlKSBpcyBhc3NpZ25lZCBh biBleHRyYSBzZW1pY29sb24KMGE2ZDdkNDU0MTRhIGZ0cmFjZTogQmUgbW9yZSBzcGVjaWZpYyBh Ym91dCBhcmNoIGltcGFjdCB3aGVuIGZ1bmN0aW9uIHRyYWNlciBpcyBlbmFibGVkCjQ5NWZjZWM4 NjQ4YyB0cmFjaW5nOiBGaXggc2xlZXBpbmcgd2hpbGUgYXRvbWljIGluIGtkYiBmdGR1bXAKN2Vk YzM5NDViZGNlIHRyYWNpbmcvaGlzdG9ncmFtczogRml4IG1lbW9yeSBsZWFrIHByb2JsZW0KNzJh OGUwNWQ0ZjY2IE1lcmdlIHRhZyAnb3ZsLWZpeGVzLTUuMTktcmM3JyBvZiBnaXQ6Ly9naXQua2Vy bmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbXN6ZXJlZGkvdmZzCjI5ODUxNTY3ZDFh YSBNZXJnZSB0YWcgJ2RybS1maXhlcy0yMDIyLTA3LTEyJyBvZiBnaXQ6Ly9hbm9uZ2l0LmZyZWVk ZXNrdG9wLm9yZy9kcm0vZHJtCjBkOGJhMjRlNzJiNiBNZXJnZSB0YWcgJ3g4Nl9idWdzX3JldGJs ZWVkJyBvZiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdGlw L3RpcApjMjdjNzUzZWE2ZmQgeDg2L3N0YXRpY19jYWxsOiBTZXJpYWxpemUgX19zdGF0aWNfY2Fs bF9maXh1cCgpIHByb3Blcmx5CmNlMTE0Yzg2Njg2MCBNZXJnZSB0YWcgJ3g4Nl9idWdzX3JldGJs ZWVkJyBvZiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdGlw L3RpcAozNTkwYjQ0Yjk0MzQgTWVyZ2UgdGFnICdkcm0tbWlzYy1maXhlcy0yMDIyLTA3LTA3LTEn IG9mIHNzaDovL2dpdC5mcmVlZGVza3RvcC5vcmcvZ2l0L2RybS9kcm0tbWlzYyBpbnRvIGRybS1m aXhlcwo0MmUwYTg3MjMzZTMgTWVyZ2UgdGFnICdkcm0taW50ZWwtZml4ZXMtMjAyMi0wNy0wNycg b2YgZ2l0Oi8vYW5vbmdpdC5mcmVlZGVza3RvcC5vcmcvZHJtL2RybS1pbnRlbCBpbnRvIGRybS1m aXhlcwo3ZGU5NjM2NTg3OGYgTWVyZ2UgdGFnICdhbWQtZHJtLWZpeGVzLTUuMTktMjAyMi0wNy0w Nicgb2YgaHR0cHM6Ly9naXRsYWIuZnJlZWRlc2t0b3Aub3JnL2FnZDVmL2xpbnV4IGludG8gZHJt LWZpeGVzCjVhMjkyMzJkODcwZCBNZXJnZSB0YWcgJ2Zvci01LjE5LXJjNi10YWcnIG9mIGdpdDov L2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9rZGF2ZS9saW51eAoyMzQ1 OGFjOTFkYzggTWVyZ2UgdGFncyAnZnJlZS1tcV9zeXNjdGxzLWZvci12NS4xOScgYW5kICdwdHJh Y2VfdW5mcmVlemVfZml4LWZvci12NS4xOScgb2YgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3Nj bS9saW51eC9rZXJuZWwvZ2l0L2ViaWVkZXJtL3VzZXItbmFtZXNwYWNlCjhlNTlhNmE3YTRmYSBN ZXJnZSB0YWcgJ21tLWhvdGZpeGVzLXN0YWJsZS0yMDIyLTA3LTExJyBvZiBnaXQ6Ly9naXQua2Vy bmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvYWtwbS9tbQpiNTM3NDM5NmU1ZGUgTWVy Z2UgdGFnICdtb2R1bGVzLTUuMTktcmM3JyBvZiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2Nt L2xpbnV4L2tlcm5lbC9naXQvbWNncm9mL2xpbnV4Cgo+IAo+ID4gCj4gPiA+IAo+ID4gPiA+IAo+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEtyaXMgQmFobnNlbiA8a3Jpc0BlbWJlZGRlZFRTLmNvbT4K PiA+ID4gPiAtLS0KPiA+ID4gPiAKPiA+ID4gPiBWMS0+VjI6IEltcGxlbWVudCBjaGFuZ2VzIHJl Y29tbWVuZGVkIGJ5IFJvYiBIZXJyaW5nIGFuZCBkdGJzX2NoZWNrCj4gPiA+ID4gCj4gPiA+ID4g UkZDIG9ubHksIG5vdCB5ZXQgcmVhZHkgdG8gbWVyZ2UsIG1vcmUgdGVzdGluZyBuZWVkZWQgYW5k IHdlJ3JlIHdvcmtpbmcgb24KPiA+ID4gPiBTUEkgTENEIHN1cHBvcnQgZm9yIHRoaXMgcGxhdGZv cm0uCj4gPiA+ID4gCj4gPiA+ID4gU3BlY2lmaWNhbGx5LCBJIGhhdmUgYSBmZXcgcXVlc3Rpb25z IG9uIHNvbWUgcGFyYWRpZ21zIGFuZCBkdGJzX2NoZWNrIG91dHB1dDoKPiA+ID4gPiAKPiA+ID4g PiBpbXg2dWwtdHM3NTUzdjIuZHRiOiAvOiBpMmMtZ3Bpbzogeydjb21wYXRpYmxlJzogLi4uIFwK PiA+ID4gPiAnbWFnbmV0b21ldGVyQGMnOiB7J2NvbXBhdGlibGUnOiBbJ2FzYWhpLWthc2VpLGFr ODk3NSddLCAncmVnJzogW1sxMl1dfX19fSBcCj4gPiA+ID4gaXMgbm90IG9mIHR5cGUgJ2FycmF5 Jwo+ID4gPiA+ICAgSSdtIG5vdCBzdXJlIHdoYXQgdGhpcyBlcnJvciBpcyByZWZlcnJpbmcgdG8g YXMgSSd2ZSBjb3BpZWQgdGhlIGV4YW1wbGUgaW4KPiA+ID4gPiAgIGludmVuc2Vuc2UsbXB1NjA1 MC55YW1sIGFsbW9zdCB2ZXJiYXRpbS4gSXMgdGhpcyBhbiBpc3N1ZSB3aXRoIG91ciBwYXRjaAo+ ID4gPiA+ICAgb3IgYSBmYWxzZSBwb3NpdGl2ZSBmcm9tIGR0YnNfY2hlY2s/Cj4gPiA+IAo+ID4g PiBZb3Ugd291bGQgbmVlZCB0byBwYXN0ZSBlbnRpcmUgZXJyb3IsIG1heWJlIHdpdGggY2hlY2tl ciBmbGFncyAtdi4KPiA+IAo+ID4gSGVyZSBpcyB0aGUgdmVyYm9zZSBvdXRwdXQuIEknbSBub3Qg ZmFtaWxpYXIgZW5vdWdoIHlldCB3aXRoIHRoZSBzY2hlbWEgYW5kIGl0cwo+ID4gdmFsaWRhdGlv biBjb2RlIHRvIGNhdGNoIHdoYXQgaXMgd3JvbmcgYW5kIHdvdWxkIGFwcHJlY2lhdGUgYW55IGlu c2lnaHQuCj4gPiAKPiA+IENoZWNrOiAgYXJjaC9hcm0vYm9vdC9kdHMvaW14NnVsLXRzNzU1M3Yy LmR0Ygo+ID4gL3dvcmsvYXJjaC9hcm0vYm9vdC9kdHMvaW14NnVsLXRzNzU1M3YyLmR0YjogLzog aTJjLWdwaW86IHsnY29tcGF0aWJsZSc6IFsnaTJjLWdwaW8nXSwgXAo+ID4gJyNhZGRyZXNzLWNl bGxzJzogW1sxXV0sICcjc2l6ZS1jZWxscyc6IFtbMF1dLCAncGluY3RybC1uYW1lcyc6IFsnZGVm YXVsdCddLCBcCj4gPiAncGluY3RybC0wJzogW1s1OF1dLCAnc2RhLWdwaW9zJzogW1sxMSwgNSwg Nl1dLCAnc2NsLWdwaW9zJzogW1sxMSwgNCwgNl1dLCBcCj4gPiAnaW11QDY4Jzogeydjb21wYXRp YmxlJzogWydpbnZlbnNlbnNlLG1wdTkyNTAnXSwgJ3JlZyc6IFtbMTA0XV0sIFwKPiA+ICdpbnRl cnJ1cHQtcGFyZW50JzogW1s1NV1dLCAnaW50ZXJydXB0cyc6IFtbMSwgMV1dLCAnaTJjLWdhdGUn OiB7JyNhZGRyZXNzLWNlbGxzJzogW1sxXV0sIFwKPiA+ICcjc2l6ZS1jZWxscyc6IFtbMF1dLCAn bWFnbmV0b21ldGVyQGMnOiB7J2NvbXBhdGlibGUnOiBbJ2FzYWhpLWthc2VpLGFrODk3NSddLCBc Cj4gPiAncmVnJzogW1sxMl1dfX19fSBpcyBub3Qgb2YgdHlwZSAnYXJyYXknCj4gPiAKPiA+IEZh aWxlZCB2YWxpZGF0aW5nICd0eXBlJyBpbiBzY2hlbWFbJ3BhdHRlcm5Qcm9wZXJ0aWVzJ11bJyg/ PCEsbnIpLWdwaW9zPyQnXToKPiA+ICAgICB7J2l0ZW1zJzogeydhZGRpdGlvbmFsSXRlbXMnOiB7 JyRyZWYnOiAnIy9kZWZpbml0aW9ucy9jZWxsJ30sCj4gPiAgICAgICAgICAgICAgICAnaXRlbXMn OiBbeydvbmVPZic6IFt7J21heGltdW0nOiA0Mjk0OTY3Mjk1LAo+ID4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdtaW5pbXVtJzogMSwKPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAncGhhbmRsZSc6IFRydWUsCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ3R5cGUnOiAnaW50ZWdlcid9LAo+ID4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgeydjb25zdCc6IDAsICd0eXBlJzogJ2ludGVnZXInfV19 XSwKPiA+ICAgICAgICAgICAgICAgICdtaW5JdGVtcyc6IDEsCj4gPiAgICAgICAgICAgICAgICAn dHlwZSc6ICdhcnJheSd9LAo+ID4gICAgICAnbWluSXRlbXMnOiAxLAo+ID4gICAgICAndHlwZSc6 ICdhcnJheSd9Cj4gPiAKPiA+IE9uIGluc3RhbmNlWydpMmMtZ3BpbyddOgo+IAo+IEJlY2F1c2Ug eW91IHVzZSAiaTJjLWdwaW8iLCBpdCBzZWVtcy4uLiBGaXggaXQgYW5kIGNoZWNrIGlmIGVycm9y IGdvZXMgYXdheS4KCllvdSBhcmUgY29ycmVjdCwgdGhlIGVycm9yIG5vIGxvbmdlciBhcHBlYXJz IGFmdGVyIEkgaGFkIGZpeGVkIHRoZSBub2RlIG5hbWUuCgo+IAo+ID4gICAgIHsnI2FkZHJlc3Mt Y2VsbHMnOiBbWzFdXSwKPiA+ICAgICAgJyNzaXplLWNlbGxzJzogW1swXV0sCj4gPiAgICAgICdj b21wYXRpYmxlJzogWydpMmMtZ3BpbyddLAo+ID4gICAgICAnaW11QDY4Jzogeydjb21wYXRpYmxl JzogWydpbnZlbnNlbnNlLG1wdTkyNTAnXSwKPiA+ICAgICAgICAgICAgICAgICAnaTJjLWdhdGUn OiB7JyNhZGRyZXNzLWNlbGxzJzogW1sxXV0sCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICcjc2l6ZS1jZWxscyc6IFtbMF1dLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnbWFnbmV0b21ldGVyQGMnOiB7J2NvbXBhdGlibGUnOiBbJ2FzYWhpLWthc2VpLGFrODk3NSdd LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Jl Zyc6IFtbMTJdXX19LAo+ID4gICAgICAgICAgICAgICAgICdpbnRlcnJ1cHQtcGFyZW50JzogW1s1 NV1dLAo+ID4gICAgICAgICAgICAgICAgICdpbnRlcnJ1cHRzJzogW1sxLCAxXV0sCj4gPiAgICAg ICAgICAgICAgICAgJ3JlZyc6IFtbMTA0XV19LAo+ID4gICAgICAncGluY3RybC0wJzogW1s1OF1d LAo+ID4gICAgICAncGluY3RybC1uYW1lcyc6IFsnZGVmYXVsdCddLAo+ID4gICAgICAnc2NsLWdw aW9zJzogW1sxMSwgNCwgNl1dLAo+ID4gICAgICAnc2RhLWdwaW9zJzogW1sxMSwgNSwgNl1dfQo+ ID4gICAgICAgICBGcm9tIHNjaGVtYTogL3Vzci9sb2NhbC9saWIvcHl0aG9uMy45L2Rpc3QtcGFj a2FnZXMvZHRzY2hlbWEvc2NoZW1hcy9ncGlvL2dwaW8tY29uc3VtZXIueWFtbAo+ID4gCj4gPiA+ IAo+ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IGlteDZ1bC10czc1NTN2Mi5kdGI6IHNwaUAyMDEw MDAwOiBzcGlkZXZAMTogJ2NvbXBhdGlibGUnIGlzIGEgcmVxdWlyZWQgcHJvcGVydHkKPiA+ID4g PiAgIE1hbnkgb2Ygb3VyIGRldmljZXMgaGF2ZSBvcGVuLWVuZGVkIEkyQyBhbmQgU1BJIHBvcnRz IHRoYXQgbWF5IG9yIG1heSBub3QgYmUKPiA+ID4gPiAgIHVzZWQgaW4gY3VzdG9tZXIgYXBwbGlj YXRpb25zLiBXaXRoICJzcGlkZXYiIGNvbXBhdGlibGUgc3RyaW5nIG5vIGxvbmdlcgo+ID4gPiA+ ICAgc3VwcG9ydGVkLCB0aGVyZSBpcyBubyBlYXN5IHdheSB3ZSBrbm93IG9mIHRvIGxlYXZlIGEg cGxhY2Vob2xkZXIgb3IKPiA+ID4gPiAgIGluZGljYXRpb24gdGhhdCB0aGUgaW50ZXJmYWNlIGlz IHByZXNlbnQsIHVzYWJsZSwgYW5kIGVpdGhlciBuZWVkcyBzcGVjaWZpYwo+ID4gPiA+ICAgc3Vw cG9ydCBlbmFibGVkIGluIGtlcm5lbCBvciB1c2Vyc3BhY2UgYWNjZXNzIHZpYSAvZGV2Ly4gV2Ug d291bGQgbG92ZQo+ID4gPiA+ICAgZmVlZGJhY2sgb24gaG93IHRvIGhhbmRsZSB0aGlzIHNpdHVh dGlvbiB3aGVuIHN1Ym1pdHRpbmcgcGxhdGZvcm1zIHVwc3RyZWFtLgo+ID4gPiAKPiA+ID4gTm8g ZW1wdHkgZGV2aWNlcywgZXNwZWNpYWxseSBmb3Igc3BpZGV2IGluIERUUy4gVGhlcmUgaXMgcmVh bGx5IG5vCj4gPiA+IHNpbmdsZSBuZWVkIHRvIGFkZCBmYWtlIHNwaWRldi4uLiByZWFsbHksIHdo eT8gVGhlIGN1c3RvbWVyIGNhbm5vdCByZWFkCj4gPiA+IGhhcmR3YXJlIG1hbnVhbCBhbmQgY2Fu bm90IHNlZSB0aGUgaGVhZGVyIG9uIHRoZSBib2FyZD8gWW91IGNhbiBnaXZlIGhpbQo+ID4gPiBh IHR1dG9yaWFsL2hvd3RvIGd1aWRlLCBidXQgZG9uJ3QgZW1iZWQgZGVhZCBvciBub24tcmVhbCBj b2RlIGluIERUUy4KPiA+IAo+ID4gV2Ugc2hpcCBkZXZpY2VzIGFzIGJvb3RhYmxlIG91dCBvZiB0 aGUgYm94LiBBIG51bWJlciBvZiBvdXIgY3VzdG9tZXJzIGVuZCB1cAo+ID4gYXR0YWNoaW5nIFNQ SSBkZXZpY2VzIHRoYXQgZG8gbm90IGhhdmUgZXhpc3Rpbmcga2VybmVsIGRyaXZlcnMgYW5kIHRh bGsgdG8gdGhlbQo+ID4gZnJvbSB1c2Vyc3BhY2Ugd2l0aG91dCBoYXZpbmcgdG8gdG91Y2ggYSBr ZXJuZWwgYnVpbGQuIFRoZSBsb3NzIG9mIHNwaWRldgo+ID4gZGlyZWN0bHkgaGFzIGluY3JlYXNl ZCBzdXBwb3J0IHJlcXVlc3RzIHdlIHJlY2VpdmUgb24gdGhlIG1hdHRlci4KPiAKPiBVbmZvcnR1 bmF0ZWx5IHRoaXMgaXMgYW4gYXJndW1lbnQgbGlrZSAtIG91ciBjdXN0b21lcnMgYWx3YXlzIHdh bnRlZAo+IGRlYWQgY29kZSBpbiBEVFMsIHNvIHdlIGVtYmVkIGhlcmUgc3VjaC4gRmVlbCBmcmVl IHRvIGFkZCBhIGNvbW1lbnQKPiBhYm91dCBwbGFjZWhvbGRlciBldGMsIGJ1dCBlbXB0eSBub2Rl IG5vdC4gQW5vdGhlciBpc3N1ZSBpcyB0aGF0IGVtcHR5Cj4gbm9kZSB3aXRob3V0IGNvbXBhdGli bGUgYWxzbyBkb2VzIG5vdCBoZWxwIHlvdXIgY3VzdG9tZXJzLi4uCj4gCj4gPiAKPiAKPiAoLi4u KQo+IAo+ID4gCj4gPiA+IAo+ID4gPiA+ICsKPiA+ID4gPiArCWdwaW8ta2V5cyB7Cj4gPiA+ID4g KwkJY29tcGF0aWJsZSA9ICJncGlvLWtleXMiOwo+ID4gPiA+ICsJCXBpbmN0cmwtbmFtZXMgPSAi ZGVmYXVsdCI7Cj4gPiA+ID4gKwkJcGluY3RybC0wID0gPCZwaW5jdHJsX2dwaW9fa2V5cz47Cj4g PiA+ID4gKwo+ID4gPiA+ICsJCWxlZnQgewo+ID4gPiAKPiA+ID4gVGhpcyBmYWlscyBvbiBkdGJz X2NoZWNrLiBHZW5lcmljIG5vZGUgbmFtZXMsIHNvICJrZXktMCIgb3IgImtleS1sZWZ0Igo+ID4g Cj4gPiBGb3IgcmVmZXJlbmNlLCBhcyBvZiBjb21taXQgYjA0NzYwMmQ1NzliNGZiMDI4MTI4YTUy NWYwNTZiYmRjODkwZTdmMCwgdGhlcmUKPiA+IGFyZSBubyBlcnJvcnMvd2FybmluZ3MgZnJvbSBk dGJzX2NoZWNrIG9yIGNoZWNrcGF0Y2gucGwgcmVnYXJkaW5nIG5vZGUKPiA+IG5hbWVzIGJlaW5n ICJrZXktLi4uIiBhbmQgdGhlIGV4YW1wbGUgaW4gZ3Bpby1rZXlzLnlhbWwgdXNlcyAidXAiICJs ZWZ0IiBldGMuCj4gCj4gSSBrbm93LCBJIGNoYW5nZWQgaXQuIEl0J3MgaW4gbGludXgtbmV4dC4K PiAKPiA+IAo+ID4gSSd2ZSBhbHNvIGNoYW5nZWQgdGhlIG5vZGUgbmFtZSB0byBqdXN0ICJrZXlz IiBwZXIgZGV2aWNldHJlZSBzcGVjaWZpY2F0aW9ucwo+ID4gZG9jLgo+ID4gCj4gPiA+IAo+ID4g PiA+ICsJaTJjX2dwaW86IGkyYy1ncGlvIHsKPiA+ID4gCj4gPiA+IEdlbmVyaWMgbm9kZSBuYW1l LCBzbyAiaTJjIgo+ID4gCj4gPiBVbmRlcnN0b29kLgo+ID4gCj4gPiBBcmUgdGhlcmUgYW55IGd1 aWRlbGluZXMvcmVzdHJpY3Rpb25zIG9uIGxhYmVsIHVzZS9zY2hlbWHCoAo+ID4gdGhyb3VnaG91 dCBhIGR0cyBmaWxlPyBUaGUgZGV2aWNldHJlZS1zcGVjaWZpY2F0aW9uIGRvY3VtZW50IG9ubHkg ZGVmaW5lcwo+ID4gdmFsaWQgY2hhcmFjdGVycyBmb3IgYSBsYWJlbCBhbmQgSSd2ZSBiZWVuIHVu YWJsZSB0byBmaW5kIGFueSBvdGhlciBkb2NzLgo+IAo+IEZvciBsYWJlbCAtIHVzZSB1bmRlcnNj b3JlcyBhbmQgdGhhdCdzIGl0LiBPbmx5IHRoZSBub2RlIG5hbWVzIHNob3VsZCBiZQo+IGdlbmVy aWMuCj4gCj4gPiAKPiAKPiBCZXN0IHJlZ2FyZHMsCj4gS3J6eXN6dG9mCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D22C43334 for ; Fri, 15 Jul 2022 17:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbiGORy4 (ORCPT ); Fri, 15 Jul 2022 13:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiGORyy (ORCPT ); Fri, 15 Jul 2022 13:54:54 -0400 Received: from smtp-out3.electric.net (smtp-out3.electric.net [208.70.128.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC5B54CB5; Fri, 15 Jul 2022 10:54:52 -0700 (PDT) Received: from 1oCPWT-000BsI-W3 by out3a.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1oCPWb-000C2b-Uv; Fri, 15 Jul 2022 10:54:49 -0700 Received: by emcmailer; Fri, 15 Jul 2022 10:54:49 -0700 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3a.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oCPWT-000BsI-W3; Fri, 15 Jul 2022 10:54:41 -0700 Received: from tsdebian (97-120-89-198.ptld.qwest.net [97.120.89.198]) by mail.embeddedts.com (Postfix) with ESMTPSA id E09C21C0A; Fri, 15 Jul 2022 10:54:40 -0700 (MST) Message-ID: <1657907657.2829.1.camel@embeddedTS.com> Subject: Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support From: Kris Bahnsen Reply-To: kris@embeddedTS.com To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Featherston Date: Fri, 15 Jul 2022 10:54:17 -0700 In-Reply-To: References: <20220713221233.8486-1-kris@embeddedTS.com> <55dccabb-41e9-dc45-f404-c333f5472e75@linaro.org> <1657833995.2979.1.camel@embeddedTS.com> Organization: embeddedTS Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256 X-Authenticated_ID: X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121;h=Mime-Version:References:In-Reply-To:Date:To:From:Message-ID; bh=dxvJjUrX64Cs5hkRtbhBYZ+CBeeqYYUwDDG4GscCgRg=;b=RCNRIPqG09r6kH74N7as77/3G7UZC/jdj5YvhraTRW4wujMa1l3NoCN2JRBjhbjL5PYW+69kXwBTzLYLRUeBob/vE+nszuiHZWnjSpRt0RHh/stQGD/6yo5O1NsCs3apgzZd5IvSOAnhuOgEnCNENPR9hudArlDpMtzkzTNBE8hW0ItYHd8Jsyk9mzToxeftTRmpxiXX0keBzL++UcnZKYmlSKnQipOlWRK9DoMo6gTHsKNqosF/3MOGWpRaWZXcx9l9/oMukJt2QdES/5ROglhoD6nj0FBnQNZf8RjjnTHM/82vGjSklGem2ypr40yBDtmbCTRv1ulIjGi4vdq5OQ==; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 2022-07-15 at 08:42 +0200, Krzysztof Kozlowski wrote: > On 14/07/2022 23:26, Kris Bahnsen wrote: > > On Thu, 2022-07-14 at 10:34 +0200, Krzysztof Kozlowski wrote: > > > On 14/07/2022 00:12, Kris Bahnsen wrote: > > > > Add initial support of the i.MX6UL based TS-7553-V2 platform. > > > > > > Use subject prefix matching the subsystem. git log --oneline -- > > > > Can you please elaborate? The subject prefix is "ARM: dts:", I'm not > > sure what is missing. Should it be something like > > "ARM: dts: imx6ul-ts7553v2:" in this case? > > Run the command, you will see. I had previously run the command and the output of it did not make sense in the context of your prior comment. Forgive my ignorance, but I'd like to understand specifically what you mean here so we can do the correct thing in the future. $ git log --oneline -- | head -n 20 d14ee2d5a506 ARM: dts: Add TS-7553-V2 support b047602d579b Merge tag 'trace-v5.19-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace 1e1fb420fe68 samples: Use KSYM_NAME_LEN for kprobes e3655dfa5805 fprobe/samples: Make sample_probe static 0bb7e14c8e15 blk-iocost: tracing: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon 0a6d7d45414a ftrace: Be more specific about arch impact when function tracer is enabled 495fcec8648c tracing: Fix sleeping while atomic in kdb ftdump 7edc3945bdce tracing/histograms: Fix memory leak problem 72a8e05d4f66 Merge tag 'ovl-fixes-5.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs 29851567d1aa Merge tag 'drm-fixes-2022-07-12' of git://anongit.freedesktop.org/drm/drm 0d8ba24e72b6 Merge tag 'x86_bugs_retbleed' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip c27c753ea6fd x86/static_call: Serialize __static_call_fixup() properly ce114c866860 Merge tag 'x86_bugs_retbleed' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 3590b44b9434 Merge tag 'drm-misc-fixes-2022-07-07-1' of ssh://git.freedesktop.org/git/drm/drm-misc into drm-fixes 42e0a87233e3 Merge tag 'drm-intel-fixes-2022-07-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes 7de96365878f Merge tag 'amd-drm-fixes-5.19-2022-07-06' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes 5a29232d870d Merge tag 'for-5.19-rc6-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux 23458ac91dc8 Merge tags 'free-mq_sysctls-for-v5.19' and 'ptrace_unfreeze_fix-for-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace 8e59a6a7a4fa Merge tag 'mm-hotfixes-stable-2022-07-11' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm b5374396e5de Merge tag 'modules-5.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux > > > > > > > > > > > > > > Signed-off-by: Kris Bahnsen > > > > --- > > > > > > > > V1->V2: Implement changes recommended by Rob Herring and dtbs_check > > > > > > > > RFC only, not yet ready to merge, more testing needed and we're working on > > > > SPI LCD support for this platform. > > > > > > > > Specifically, I have a few questions on some paradigms and dtbs_check output: > > > > > > > > imx6ul-ts7553v2.dtb: /: i2c-gpio: {'compatible': ... \ > > > > 'magnetometer@c': {'compatible': ['asahi-kasei,ak8975'], 'reg': [[12]]}}}} \ > > > > is not of type 'array' > > > > I'm not sure what this error is referring to as I've copied the example in > > > > invensense,mpu6050.yaml almost verbatim. Is this an issue with our patch > > > > or a false positive from dtbs_check? > > > > > > You would need to paste entire error, maybe with checker flags -v. > > > > Here is the verbose output. I'm not familiar enough yet with the schema and its > > validation code to catch what is wrong and would appreciate any insight. > > > > Check: arch/arm/boot/dts/imx6ul-ts7553v2.dtb > > /work/arch/arm/boot/dts/imx6ul-ts7553v2.dtb: /: i2c-gpio: {'compatible': ['i2c-gpio'], \ > > '#address-cells': [[1]], '#size-cells': [[0]], 'pinctrl-names': ['default'], \ > > 'pinctrl-0': [[58]], 'sda-gpios': [[11, 5, 6]], 'scl-gpios': [[11, 4, 6]], \ > > 'imu@68': {'compatible': ['invensense,mpu9250'], 'reg': [[104]], \ > > 'interrupt-parent': [[55]], 'interrupts': [[1, 1]], 'i2c-gate': {'#address-cells': [[1]], \ > > '#size-cells': [[0]], 'magnetometer@c': {'compatible': ['asahi-kasei,ak8975'], \ > > 'reg': [[12]]}}}} is not of type 'array' > > > > Failed validating 'type' in schema['patternProperties']['(? > {'items': {'additionalItems': {'$ref': '#/definitions/cell'}, > > 'items': [{'oneOf': [{'maximum': 4294967295, > > 'minimum': 1, > > 'phandle': True, > > 'type': 'integer'}, > > {'const': 0, 'type': 'integer'}]}], > > 'minItems': 1, > > 'type': 'array'}, > > 'minItems': 1, > > 'type': 'array'} > > > > On instance['i2c-gpio']: > > Because you use "i2c-gpio", it seems... Fix it and check if error goes away. You are correct, the error no longer appears after I had fixed the node name. > > > {'#address-cells': [[1]], > > '#size-cells': [[0]], > > 'compatible': ['i2c-gpio'], > > 'imu@68': {'compatible': ['invensense,mpu9250'], > > 'i2c-gate': {'#address-cells': [[1]], > > '#size-cells': [[0]], > > 'magnetometer@c': {'compatible': ['asahi-kasei,ak8975'], > > 'reg': [[12]]}}, > > 'interrupt-parent': [[55]], > > 'interrupts': [[1, 1]], > > 'reg': [[104]]}, > > 'pinctrl-0': [[58]], > > 'pinctrl-names': ['default'], > > 'scl-gpios': [[11, 4, 6]], > > 'sda-gpios': [[11, 5, 6]]} > > From schema: /usr/local/lib/python3.9/dist-packages/dtschema/schemas/gpio/gpio-consumer.yaml > > > > > > > > > > > > > > > > > imx6ul-ts7553v2.dtb: spi@2010000: spidev@1: 'compatible' is a required property > > > > Many of our devices have open-ended I2C and SPI ports that may or may not be > > > > used in customer applications. With "spidev" compatible string no longer > > > > supported, there is no easy way we know of to leave a placeholder or > > > > indication that the interface is present, usable, and either needs specific > > > > support enabled in kernel or userspace access via /dev/. We would love > > > > feedback on how to handle this situation when submitting platforms upstream. > > > > > > No empty devices, especially for spidev in DTS. There is really no > > > single need to add fake spidev... really, why? The customer cannot read > > > hardware manual and cannot see the header on the board? You can give him > > > a tutorial/howto guide, but don't embed dead or non-real code in DTS. > > > > We ship devices as bootable out of the box. A number of our customers end up > > attaching SPI devices that do not have existing kernel drivers and talk to them > > from userspace without having to touch a kernel build. The loss of spidev > > directly has increased support requests we receive on the matter. > > Unfortunately this is an argument like - our customers always wanted > dead code in DTS, so we embed here such. Feel free to add a comment > about placeholder etc, but empty node not. Another issue is that empty > node without compatible also does not help your customers... > > > > > (...) > > > > > > > > > > + > > > > + gpio-keys { > > > > + compatible = "gpio-keys"; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_gpio_keys>; > > > > + > > > > + left { > > > > > > This fails on dtbs_check. Generic node names, so "key-0" or "key-left" > > > > For reference, as of commit b047602d579b4fb028128a525f056bbdc890e7f0, there > > are no errors/warnings from dtbs_check or checkpatch.pl regarding node > > names being "key-..." and the example in gpio-keys.yaml uses "up" "left" etc. > > I know, I changed it. It's in linux-next. > > > > > I've also changed the node name to just "keys" per devicetree specifications > > doc. > > > > > > > > > + i2c_gpio: i2c-gpio { > > > > > > Generic node name, so "i2c" > > > > Understood. > > > > Are there any guidelines/restrictions on label use/schema  > > throughout a dts file? The devicetree-specification document only defines > > valid characters for a label and I've been unable to find any other docs. > > For label - use underscores and that's it. Only the node names should be > generic. > > > > > Best regards, > Krzysztof >