From: Thomas Monjalon <thomas@monjalon.net>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, rosen.xu@intel.com
Subject: Re: [PATCH] bus/fpga: use strlcpy instead of strncpy
Date: Sun, 13 May 2018 12:07:13 +0200 [thread overview]
Message-ID: <1658878.RdDdYUol4R@xps> (raw)
In-Reply-To: <20180512070217.16735-1-pablo.de.lara.guarch@intel.com>
12/05/2018 09:02, Pablo de Lara:
> Gcc 8 reports a build error:
>
> drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified
> bound 256 equals destination size [-Werror=stringop-truncation]
> strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-05-13 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 7:02 [PATCH] bus/fpga: use strlcpy instead of strncpy Pablo de Lara
2018-05-13 10:07 ` Thomas Monjalon [this message]
2018-05-14 10:06 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658878.RdDdYUol4R@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=rosen.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.