From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2152C19F2A for ; Thu, 4 Aug 2022 14:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238427AbiHDOgU (ORCPT ); Thu, 4 Aug 2022 10:36:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbiHDOgU (ORCPT ); Thu, 4 Aug 2022 10:36:20 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBE032461 for ; Thu, 4 Aug 2022 07:36:19 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id y141so19519206pfb.7 for ; Thu, 04 Aug 2022 07:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=q+k2/oQCg1jExDf3V4wAMLxe+YHu3Cav2Cj1hEhSNaI=; b=hE/oiEFnClv6y9rBHS2KMK6uuYGV0bVD21qZwtxdqZZmyh8k38w/J6Qot3ihBwHCsr +9bjT8zHi1y2HAOFKWIAT0cE2At/qgXJNxJMte7A2oqMd7MD9csFv3Hi4a75c5HMJ2iA GtwMS+oGPYOklrpW7S0botKdD3HBD3wXtRpXfjlQYKeW+mGGBCAJjfGk0Jfbgih5+NLr pD+VnyUgWZ2lTvRKRodcgEjHjACT105SBfJGerMo6oqdwY6tfVz7XNgUK6YEX5wtZ1vk vCcHZ9gczAibbdkDA+LGnxCrdEt+13gYZhYXchttcZhGXn+L38dkEeV0oZvFKdNWgy4H n+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=q+k2/oQCg1jExDf3V4wAMLxe+YHu3Cav2Cj1hEhSNaI=; b=EG+J/794Pcu/Q9WG1L9gCqaojvzF0sclbHLcnv9kzm/t0xZCBrkw8EoDlgFxuXIROc SiRvjLQGJDQmSrOVtNTbA1kCEE18KvCFdxucJl1mnvsyhtkY99dQm71Euv4RPtCmfDXq 9hwkHOsq4pcSnVErbE7Ee6JlSl/Y7yKC2olWC2tIiEPU6/Gxbjmctg428PJGr4wbl8CK hi3ANBn7ATq/Ah136K/sPFMhAB4KcxypE8uLvnCg/eRiV9WLQhjm8iAbKkamj8C4wIfy ykM+FprEtp7Zf1e2jqiPRTn0KweHNtWYgnRGnCA4b47Hx39xEcIXbgs0WU+bwFNNQdN6 3J4g== X-Gm-Message-State: ACgBeo3X6jPpfrK0RuC7D+H0RVMhIzH5zWvD9DMy+2J5AG+W7/LlLjqW CAgPE9e0sPTbnFNk87FoVElIag== X-Google-Smtp-Source: AA6agR7McvvMMvvmO1Lg8S2YS4nUVsullv7y6a/2XZIXBqXo7EJcpWXdQpN/AKwj5X+DJQwZRxS8eg== X-Received: by 2002:a63:82c2:0:b0:41b:c0f3:39b3 with SMTP id w185-20020a6382c2000000b0041bc0f339b3mr1878157pgd.86.1659623778954; Thu, 04 Aug 2022 07:36:18 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x12-20020a17090300cc00b0016d2db82962sm1084731plc.16.2022.08.04.07.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 07:36:18 -0700 (PDT) From: Jens Axboe To: paul@paul-moore.com, yepeilin.cs@gmail.com, eparis@redhat.com, asml.silence@gmail.com Cc: linux-audit@redhat.com, peilin.ye@bytedance.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220803222343.31673-1-yepeilin.cs@gmail.com> References: <20220803050230.30152-1-yepeilin.cs@gmail.com> <20220803222343.31673-1-yepeilin.cs@gmail.com> Subject: Re: [PATCH v2] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker() Message-Id: <165962377794.930556.772272743019429536.b4-ty@kernel.dk> Date: Thu, 04 Aug 2022 08:36:17 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, 3 Aug 2022 15:23:43 -0700, Peilin Ye wrote: > From: Peilin Ye > > Currently @audit_context is allocated twice for io_uring workers: > > 1. copy_process() calls audit_alloc(); > 2. io_sq_thread() or io_wqe_worker() calls audit_alloc_kernel() (which > is effectively audit_alloc()) and overwrites @audit_context, > causing: > > [...] Applied, thanks! [1/1] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker() commit: f482aa98652795846cc55da98ebe331eb74f3d0b Best regards, -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B015DC19F2A for ; Thu, 4 Aug 2022 14:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659623829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=og7dpXev7ht/sFS7BGVXuC8WppRsxee5a9jt0IPencY=; b=EfRAo6q+nfbrN3YUAa0ZQqOAcWS46jz55hH8JbeyNz8i1YFb93kbcCaOklAMaT4bBS/d/P F2PJZz7X0/Qyn6TKCGKnYLLI1OzH3U8cW34nyc3730PVOLBT1ZBPVpYAXIIc24mce0+gHL ddfFhgolOkSTbSV39HgjO4vKyQuUD0w= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-Dl-tawjlOAy7lyluKUpiig-1; Thu, 04 Aug 2022 10:37:06 -0400 X-MC-Unique: Dl-tawjlOAy7lyluKUpiig-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9EBB6280EE27; Thu, 4 Aug 2022 14:37:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82318400DEF8; Thu, 4 Aug 2022 14:37:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 59FB71946A68; Thu, 4 Aug 2022 14:37:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 05B891946A56 for ; Thu, 4 Aug 2022 14:36:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D9DDA401E23; Thu, 4 Aug 2022 14:36:29 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D6410401E5C for ; Thu, 4 Aug 2022 14:36:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42A36824074 for ; Thu, 4 Aug 2022 14:36:23 +0000 (UTC) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-aygglbaaNkWgWQyIJA_ugQ-1; Thu, 04 Aug 2022 10:36:20 -0400 X-MC-Unique: aygglbaaNkWgWQyIJA_ugQ-1 Received: by mail-pf1-f172.google.com with SMTP id c139so19521339pfc.2 for ; Thu, 04 Aug 2022 07:36:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=q+k2/oQCg1jExDf3V4wAMLxe+YHu3Cav2Cj1hEhSNaI=; b=ybMz4l0DsuY04TTGu08UdKxj7ZiLW36nPPBF0v6a0YTFysPOwmmZN4E9I1P0u9fCL/ kqS+qgjTguIBqNhhC+TdQkikxJcZ5CkwXfWY5U6+KNTVD+6MdnqFuDAooHWJ2BtXOnsg qerx208FdX5OWre6oMc34B/idv2DDEBankIcrAhn4WzZoS6jzg/lwB0TGxqN+Jq9x8fX 2Sg/PiyzsBZplm99I4xUIKsVqC3OAacoIvSIIU9Z5yrTJtXwWUn+tTUaaR6Ac/F1das9 PMuNkVXd88yLfSKBzXrKt8/KKqdZgfrftC0ElzP4ssFYzy3K5IEa5S4Prn54hmB/Yoyv f7OA== X-Gm-Message-State: ACgBeo3PflO8pfsANZyrkZJWRZ4XsGTqXCSzUBQ6rm+bR3Rzfclf9nhg RcuzW5Sh0e27D7SWYFsCFFLP3fFLSQc+gA== X-Google-Smtp-Source: AA6agR7McvvMMvvmO1Lg8S2YS4nUVsullv7y6a/2XZIXBqXo7EJcpWXdQpN/AKwj5X+DJQwZRxS8eg== X-Received: by 2002:a63:82c2:0:b0:41b:c0f3:39b3 with SMTP id w185-20020a6382c2000000b0041bc0f339b3mr1878157pgd.86.1659623778954; Thu, 04 Aug 2022 07:36:18 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x12-20020a17090300cc00b0016d2db82962sm1084731plc.16.2022.08.04.07.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 07:36:18 -0700 (PDT) From: Jens Axboe To: paul@paul-moore.com, yepeilin.cs@gmail.com, eparis@redhat.com, asml.silence@gmail.com In-Reply-To: <20220803222343.31673-1-yepeilin.cs@gmail.com> References: <20220803050230.30152-1-yepeilin.cs@gmail.com> <20220803222343.31673-1-yepeilin.cs@gmail.com> Subject: Re: [PATCH v2] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker() Message-Id: <165962377794.930556.772272743019429536.b4-ty@kernel.dk> Date: Thu, 04 Aug 2022 08:36:17 -0600 MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mailman-Approved-At: Thu, 04 Aug 2022 14:37:02 +0000 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-audit@redhat.com, peilin.ye@bytedance.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 3 Aug 2022 15:23:43 -0700, Peilin Ye wrote: > From: Peilin Ye > > Currently @audit_context is allocated twice for io_uring workers: > > 1. copy_process() calls audit_alloc(); > 2. io_sq_thread() or io_wqe_worker() calls audit_alloc_kernel() (which > is effectively audit_alloc()) and overwrites @audit_context, > causing: > > [...] Applied, thanks! [1/1] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker() commit: f482aa98652795846cc55da98ebe331eb74f3d0b Best regards, -- Jens Axboe -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit