From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"talshn@nvidia.com" <talshn@nvidia.com>,
"Kadam, Pallavi" <pallavi.kadam@intel.com>,
"Menon, Ranjit" <ranjit.menon@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, "ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW
Date: Thu, 04 Feb 2021 13:59:44 +0100 [thread overview]
Message-ID: <1660039.Gq7iE7GDot@thomas> (raw)
In-Reply-To: <d9457302-47c6-988b-6765-5eb4d64fc94c@intel.com>
04/02/2021 13:36, Ferruh Yigit:
> On 2/4/2021 10:41 AM, Zhang, Qi Z wrote:
> > From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote:
> >>> Adds extra cflags '-fno-asynchronous-unwind-tables'
> >>> to avoid the MinGW build error:
> >>> Error: invalid register for .seh_savexmm
> >>>
> >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW")
> >>>
> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >>
> >> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >>
> >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, I
> >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it that this
> >> option somehow affects GCC inlining heuristics. Similar issue existed in
> >> librte_acl (at least a year ago win GCC 6, I believe), where GCC generated
> >> incorrect code unless certain functions had been inlined (caught by test app).
> >> No an AVX expert, just my 2c.
> >
> > Applied to dpdk-next-net-intel.
> >
>
> Hi Thomas, David,
>
> Do you prefer to get this directly to the main repo, since it is fixing the
> windows build?
Given it will be pulled shortly, I think it's OK through next-net.
next prev parent reply other threads:[~2021-02-04 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:06 [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW Leyi Rong
2021-02-02 9:30 ` Thomas Monjalon
2021-02-02 10:24 ` Bruce Richardson
2021-02-02 14:13 ` Tal Shnaiderman
2021-02-02 14:31 ` Rong, Leyi
2021-02-02 14:32 ` [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW Leyi Rong
2021-02-02 23:07 ` Dmitry Kozlyuk
2021-02-04 10:41 ` Zhang, Qi Z
2021-02-04 12:36 ` Ferruh Yigit
2021-02-04 12:59 ` Thomas Monjalon [this message]
2021-02-04 13:43 ` David Marchand
2021-02-04 21:57 ` [dpdk-dev] [dpdk-ci] " Lincoln Lavoie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660039.Gq7iE7GDot@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=leyi.rong@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.