From: Jens Axboe <axboe@kernel.dk>
To: Dylan Yudaken <dylany@fb.com>,
io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>
Cc: Kernel-team@fb.com
Subject: Re: [PATCH for-next v2] io_uring: allow buffer recycling in READV
Date: Wed, 07 Sep 2022 10:57:30 -0600 [thread overview]
Message-ID: <166256985044.1932974.15663220087273783004.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220907165152.994979-1-dylany@fb.com>
On Wed, 7 Sep 2022 09:51:52 -0700, Dylan Yudaken wrote:
> In commit 934447a603b2 ("io_uring: do not recycle buffer in READV") a
> temporary fix was put in io_kbuf_recycle to simply never recycle READV
> buffers.
>
> Instead of that, rather treat READV with REQ_F_BUFFER_SELECTED the same as
> a READ with REQ_F_BUFFER_SELECTED. Since READV requires iov_len of 1 they
> are essentially the same.
> In order to do this inside io_prep_rw() add some validation to check that
> it is in fact only length 1, and also extract the length of the buffer at
> prep time.
>
> [...]
Applied, thanks!
[1/1] io_uring: allow buffer recycling in READV
commit: 8e966e46c38df6d4f45d2122e321b2d5982fcaf8
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-09-07 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 16:51 [PATCH for-next v2] io_uring: allow buffer recycling in READV Dylan Yudaken
2022-09-07 16:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166256985044.1932974.15663220087273783004.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Kernel-team@fb.com \
--cc=asml.silence@gmail.com \
--cc=dylany@fb.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.