From: Guixin Liu <kanie@linux.alibaba.com>
To: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: [PATCH 5/5] scsi: megaraid_sas: move megasas_dbg_lvl init to megasas_init
Date: Wed, 14 Sep 2022 16:48:03 +0800 [thread overview]
Message-ID: <1663145283-4872-6-git-send-email-kanie@linux.alibaba.com> (raw)
In-Reply-To: <1663145283-4872-1-git-send-email-kanie@linux.alibaba.com>
The megasas_dbg_lvl is a driver level parameter, dont init in
probe path, otherwise we can not see any debug print when bind
a device to megaraid driver.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index b5503f9..66f84b5 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -7439,7 +7439,6 @@ static inline void megasas_init_ctrl_params(struct megasas_instance *instance)
(instance->pdev->device == PCI_DEVICE_ID_LSI_SAS0071SKINNY))
instance->flag_ieee = 1;
- megasas_dbg_lvl = 0;
instance->flag = 0;
instance->unload = 1;
instance->last_time = 0;
@@ -9011,6 +9010,7 @@ static int __init megasas_init(void)
*/
pr_info("megasas: %s\n", MEGASAS_VERSION);
+ megasas_dbg_lvl = 0;
support_poll_for_event = 2;
support_device_change = 1;
support_nvme_encapsulation = true;
--
1.8.3.1
next prev parent reply other threads:[~2022-09-14 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 8:47 [PATCH 0/5] scsi: megaraid_sas: some bug fixes and cod cleanup Guixin Liu
2022-09-14 8:47 ` [PATCH 1/5] scsi: megaraid_sas: correct the parameter of scsi_device_lookup Guixin Liu
2022-09-28 10:50 ` Sumit Saxena
2022-09-14 8:48 ` [PATCH 2/5] scsi: megaraid_sas: correct an error message Guixin Liu
2022-09-28 10:52 ` Sumit Saxena
2022-09-14 8:48 ` [PATCH 3/5] scsi: megaraid_sas: simplify the megasas_update_device_list Guixin Liu
2022-09-28 11:04 ` Sumit Saxena
2022-09-14 8:48 ` [PATCH 4/5] scsi: megaraid_sas: remove unnecessary memset Guixin Liu
2022-09-28 11:17 ` Sumit Saxena
2022-09-14 8:48 ` Guixin Liu [this message]
2022-09-28 11:19 ` [PATCH 5/5] scsi: megaraid_sas: move megasas_dbg_lvl init to megasas_init Sumit Saxena
2022-09-19 2:35 ` [PATCH 0/5] scsi: megaraid_sas: some bug fixes and cod cleanup Guixin Liu
2022-09-22 8:49 ` Guixin Liu
2022-10-01 9:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663145283-4872-6-git-send-email-kanie@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.