From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] FAT: Simplify get_contents
Date: Fri, 20 Jul 2012 15:21:37 +0200 (CEST) [thread overview]
Message-ID: <1663419836.332713.1342790497668.JavaMail.root@advansee.com> (raw)
In-Reply-To: <685733824.294131.1342735372755.JavaMail.root@advansee.com>
One call to get_cluster can be factorized with another, so avoid duplicating
code.
Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Cc: Wolfgang Denk <wd@denx.de>
---
Changes for v2:
- Patch renumbering because of the new v2 1/8.
- Possible code style changes due to the new v2 1/8.
.../fs/fat/fat.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git u-boot-66714b1.orig/fs/fat/fat.c u-boot-66714b1/fs/fat/fat.c
index 101eb3a..19f6a8c 100644
--- u-boot-66714b1.orig/fs/fat/fat.c
+++ u-boot-66714b1/fs/fat/fat.c
@@ -367,21 +367,9 @@ get_contents(fsdata *mydata, dir_entry *dentptr, __u8 *buffer,
actsize += bytesperclust;
}
- /* actsize >= file size */
- actsize -= bytesperclust;
-
- /* get remaining clusters */
- if (get_cluster(mydata, curclust, buffer, (int)actsize) != 0) {
- printf("Error reading cluster\n");
- return -1;
- }
-
/* get remaining bytes */
- gotsize += (int)actsize;
- filesize -= actsize;
- buffer += actsize;
actsize = filesize;
- if (get_cluster(mydata, endclust, buffer, (int)actsize) != 0) {
+ if (get_cluster(mydata, curclust, buffer, (int)actsize) != 0) {
printf("Error reading cluster\n");
return -1;
}
next prev parent reply other threads:[~2012-07-20 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 22:02 [U-Boot] [PATCH 6/7] FAT: Simplify get_contents Benoît Thébaudeau
2012-07-20 13:21 ` Benoît Thébaudeau [this message]
2012-09-02 15:25 ` [U-Boot] [PATCH v2 7/8] " Wolfgang Denk
2012-09-04 20:50 ` Tom Rini
2012-09-04 22:07 ` Benoît Thébaudeau
2012-09-04 22:10 ` Tom Rini
2012-09-04 22:41 ` Tom Rini
2012-09-04 22:53 ` Benoît Thébaudeau
2012-09-05 0:03 ` Tom Rini
2012-09-04 22:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663419836.332713.1342790497668.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.