From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 17/21] modetest: Give the CRTC ID to the -P option Date: Wed, 20 Mar 2013 16:01:30 +0100 Message-ID: <1663586.hpolvtbntI@avalon> References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com> <1363704962-14077-18-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id A0285E65F2 for ; Wed, 20 Mar 2013 08:00:48 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Rob, On Tuesday 19 March 2013 14:21:32 Rob Clark wrote: > On Tue, Mar 19, 2013 at 10:55 AM, Laurent Pinchart wrote: > > Planes are associated with CRTCs, not connectors. Don't try to be too > > clever, use the CRTC ID in the -P option. This prepares for splitting > > CRTC and planes setup. > > hmm, I was thinking that it would be nice to someday make modetest clever > enough to deal w/ connector names instead of connector-id.. That's a good idea (and it shouldn't be too difficult to implement). > this kinda goes in the opposite direction. Please note that I use the CRTC ID instead of the connector ID for planes setup only. Planes are associated with a CRTC, not a connector. I thus thought it made sense to use the CRTC ID in the argument. If you think that's a bad idea I can drop the patch. Should modetest then associate the planes with the CRTC currently associated with the given connector ? -- Regards, Laurent Pinchart