From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:34863 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752487AbeDFNPi (ORCPT ); Fri, 6 Apr 2018 09:15:38 -0400 From: Laurent Pinchart To: Jacopo Mondi Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, vladimir_zapolskiy@mentor.com, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 06 Apr 2018 16:15:35 +0300 Message-ID: <1664336.M7KDjLhzuK@avalon> In-Reply-To: <1523018517-24121-2-git-send-email-jacopo+renesas@jmondi.org> References: <1523018517-24121-1-git-send-email-jacopo+renesas@jmondi.org> <1523018517-24121-2-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 15:41:56 EEST Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. >=20 > Signed-off-by: Jacopo Mondi > Reviewed-by: Andrzej Hajda > Reviewed-by: Niklas S=F6derlund > Reviewed-by: Laurent Pinchart > --- > .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++= +++ > 1 file changed, 60 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt >=20 > diff --git > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > new file mode 100644 > index 0000000..1191f17 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -0,0 +1,60 @@ > +Thine Electronics THC63LVD1024 LVDS decoder > +------------------------------------------- > + > +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS > streams > +to parallel data outputs. The chip supports single/dual input/output mod= es, > +handling up to two two input LVDS stream and up to two digital CMOS/TTL s/to two two/to two/ s/stream/streams/ > outputs. > + > +Single or dual operation modes, output data mapping and DDR output modes > are > +configured through input signals and the chip does not expose any control > bus. > + > +Required properties: > +- compatible: Shall be "thine,thc63lvd1024" > + > +Optional properties: > +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS inp= ut, > + PPL and digital circuitry > +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > +- enable-gpios: Output enable GPIO signal, pin name "OE". Active high As Rob mentioned in a reply to v6, we currently use "enable" as the inverse= of=20 "powerdown". I would call this one oe-gpios instead. Quoting Rob: "Debating "oe" vs. "output-enable" is bikeshedding IMO. Anyone familiar wit= h=20 h/w design should recognize OE." > + > +The THC63LVD1024 video port connections are modeled according > +to OF graph bindings specified by Documentation/devicetree/bindings/ > graph.txt > + > +Required video port nodes: > +- port@0: First LVDS input port > +- port@2: First digital CMOS/TTL parallel output > + > +Optional video port nodes: > +- port@1: Second LVDS input port > +- port@3: Second digital CMOS/TTL parallel output > + > +Example: > +-------- > + > + thc63lvd1024: lvds-decoder { > + compatible =3D "thine,thc63lvd1024"; > + > + vcc-supply =3D <®_lvds_vcc>; > + powerdown-gpios =3D <&gpio4 15 GPIO_ACTIVE_LOW>; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + > + lvds_dec_in_0: endpoint { > + remote-endpoint =3D <&lvds_out>; > + }; > + }; > + > + port@2{ > + reg =3D <2>; > + > + lvds_dec_out_2: endpoint { > + remote-endpoint =3D <&adv7511_in>; > + }; > + }; > + }; > + }; =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 06 Apr 2018 16:15:35 +0300 Message-ID: <1664336.M7KDjLhzuK@avalon> References: <1523018517-24121-1-git-send-email-jacopo+renesas@jmondi.org> <1523018517-24121-2-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1523018517-24121-2-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, airlied@linux.ie, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, geert@linux-m68k.org, dri-devel@lists.freedesktop.org, niklas.soderlund@ragnatech.se, vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDYgQXByaWwg MjAxOCAxNTo0MTo1NiBFRVNUIEphY29wbyBNb25kaSB3cm90ZToKPiBEb2N1bWVudCBUaGluZSBU SEM2M0xWRDEwMjQgTFZEUyBkZWNvZGVyIGRldmljZSB0cmVlIGJpbmRpbmdzLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IEphY29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4KPiBSZXZp ZXdlZC1ieTogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiBSZXZpZXdlZC1i eTogTmlrbGFzIFPDtmRlcmx1bmQgPG5pa2xhcy5zb2Rlcmx1bmQrcmVuZXNhc0ByYWduYXRlY2gu c2U+Cj4gUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRl YXNvbmJvYXJkLmNvbT4KPiAtLS0KPiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3RoaW5l LHRoYzYzbHZkMTAyNC50eHQgfCA2MCArKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFu Z2VkLCA2MCBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NAo+IERvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQu dHh0Cj4gCj4gZGlmZiAtLWdpdAo+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvYnJpZGdlL3RoaW5lLHRoYzYzbHZkMTAyNC50eHQKPiBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0 Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwLi4xMTkxZjE3Cj4gLS0tIC9k ZXYvbnVsbAo+ICsrKwo+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvYnJpZGdlL3RoaW5lLHRoYzYzbHZkMTAyNC50eHQKPiBAQCAtMCwwICsxLDYwIEBACj4gK1Ro aW5lIEVsZWN0cm9uaWNzIFRIQzYzTFZEMTAyNCBMVkRTIGRlY29kZXIKPiArLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsKPiArVGhlIFRIQzYzTFZEMTAyNCBp cyBhIGR1YWwgbGluayBMVkRTIHJlY2VpdmVyIGRlc2lnbmVkIHRvIGNvbnZlcnQgTFZEUwo+IHN0 cmVhbXMKPiArdG8gcGFyYWxsZWwgZGF0YSBvdXRwdXRzLiBUaGUgY2hpcCBzdXBwb3J0cyBzaW5n bGUvZHVhbCBpbnB1dC9vdXRwdXQgbW9kZXMsCj4gK2hhbmRsaW5nIHVwIHRvIHR3byB0d28gaW5w dXQgTFZEUyBzdHJlYW0gYW5kIHVwIHRvIHR3byBkaWdpdGFsIENNT1MvVFRMCgpzL3RvIHR3byB0 d28vdG8gdHdvLwpzL3N0cmVhbS9zdHJlYW1zLwoKPiBvdXRwdXRzLgo+ICsKPiArU2luZ2xlIG9y IGR1YWwgb3BlcmF0aW9uIG1vZGVzLCBvdXRwdXQgZGF0YSBtYXBwaW5nIGFuZCBERFIgb3V0cHV0 IG1vZGVzCj4gYXJlCj4gK2NvbmZpZ3VyZWQgdGhyb3VnaCBpbnB1dCBzaWduYWxzIGFuZCB0aGUg Y2hpcCBkb2VzIG5vdCBleHBvc2UgYW55IGNvbnRyb2wKPiBidXMuCj4gKwo+ICtSZXF1aXJlZCBw cm9wZXJ0aWVzOgo+ICstIGNvbXBhdGlibGU6IFNoYWxsIGJlICJ0aGluZSx0aGM2M2x2ZDEwMjQi Cj4gKwo+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICstIHZjYy1zdXBwbHk6IFBvd2VyIHN1cHBs eSBmb3IgVFRMIG91dHB1dCwgVFRMIENMT0NLT1VUIHNpZ25hbCwgTFZEUyBpbnB1dCwKPiArICBQ UEwgYW5kIGRpZ2l0YWwgY2lyY3VpdHJ5Cj4gKy0gcG93ZXJkb3duLWdwaW9zOiBQb3dlciBkb3du IEdQSU8gc2lnbmFsLCBwaW4gbmFtZSAiL1BEV04iLiBBY3RpdmUgbG93Cj4gKy0gZW5hYmxlLWdw aW9zOiBPdXRwdXQgZW5hYmxlIEdQSU8gc2lnbmFsLCBwaW4gbmFtZSAiT0UiLiBBY3RpdmUgaGln aAoKQXMgUm9iIG1lbnRpb25lZCBpbiBhIHJlcGx5IHRvIHY2LCB3ZSBjdXJyZW50bHkgdXNlICJl bmFibGUiIGFzIHRoZSBpbnZlcnNlIG9mIAoicG93ZXJkb3duIi4gSSB3b3VsZCBjYWxsIHRoaXMg b25lIG9lLWdwaW9zIGluc3RlYWQuIFF1b3RpbmcgUm9iOgoKIkRlYmF0aW5nICJvZSIgdnMuICJv dXRwdXQtZW5hYmxlIiBpcyBiaWtlc2hlZGRpbmcgSU1PLiBBbnlvbmUgZmFtaWxpYXIgd2l0aCAK aC93IGRlc2lnbiBzaG91bGQgcmVjb2duaXplIE9FLiIKCj4gKwo+ICtUaGUgVEhDNjNMVkQxMDI0 IHZpZGVvIHBvcnQgY29ubmVjdGlvbnMgYXJlIG1vZGVsZWQgYWNjb3JkaW5nCj4gK3RvIE9GIGdy YXBoIGJpbmRpbmdzIHNwZWNpZmllZCBieSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvCj4gZ3JhcGgudHh0Cj4gKwo+ICtSZXF1aXJlZCB2aWRlbyBwb3J0IG5vZGVzOgo+ICstIHBv cnRAMDogRmlyc3QgTFZEUyBpbnB1dCBwb3J0Cj4gKy0gcG9ydEAyOiBGaXJzdCBkaWdpdGFsIENN T1MvVFRMIHBhcmFsbGVsIG91dHB1dAo+ICsKPiArT3B0aW9uYWwgdmlkZW8gcG9ydCBub2RlczoK PiArLSBwb3J0QDE6IFNlY29uZCBMVkRTIGlucHV0IHBvcnQKPiArLSBwb3J0QDM6IFNlY29uZCBk aWdpdGFsIENNT1MvVFRMIHBhcmFsbGVsIG91dHB1dAo+ICsKPiArRXhhbXBsZToKPiArLS0tLS0t LS0KPiArCj4gKwl0aGM2M2x2ZDEwMjQ6IGx2ZHMtZGVjb2RlciB7Cj4gKwkJY29tcGF0aWJsZSA9 ICJ0aGluZSx0aGM2M2x2ZDEwMjQiOwo+ICsKPiArCQl2Y2Mtc3VwcGx5ID0gPCZyZWdfbHZkc192 Y2M+Owo+ICsJCXBvd2VyZG93bi1ncGlvcyA9IDwmZ3BpbzQgMTUgR1BJT19BQ1RJVkVfTE9XPjsK PiArCj4gKwkJcG9ydHMgewo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJI3NpemUt Y2VsbHMgPSA8MD47Cj4gKwo+ICsJCQlwb3J0QDAgewo+ICsJCQkJcmVnID0gPDA+Owo+ICsKPiAr CQkJCWx2ZHNfZGVjX2luXzA6IGVuZHBvaW50IHsKPiArCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8 Jmx2ZHNfb3V0PjsKPiArCQkJCX07Cj4gKwkJCX07Cj4gKwo+ICsJCQlwb3J0QDJ7Cj4gKwkJCQly ZWcgPSA8Mj47Cj4gKwo+ICsJCQkJbHZkc19kZWNfb3V0XzI6IGVuZHBvaW50IHsKPiArCQkJCQly ZW1vdGUtZW5kcG9pbnQgPSA8JmFkdjc1MTFfaW4+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiArCQl9 Owo+ICsJfTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK