All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	"Zoltan Szubbocsev (zszubbocsev)" <zszubbocsev@micron.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [EXT] Re: [PATCH V1] mtd: core: Micron SLC NAND filling block
Date: Wed, 19 Dec 2018 19:28:28 +0100	[thread overview]
Message-ID: <1664708.GA0Z09RGF1@blindfold> (raw)
In-Reply-To: <BYAPR08MB4533FD42451BCEB47D46FEEDDBBE0@BYAPR08MB4533.namprd08.prod.outlook.com>

Bean,

Am Mittwoch, 19. Dezember 2018, 19:11:25 CET schrieb Bean Huo (beanhuo):
> >If you overwrite (sub)pages 0 and 1, UBI EC and VID headers are gone.
> >In case of a power-cut before the erase operation, UBI will detect the
> >corrupted EC and VID headers and re-erase the block.
> 
> This is actually what I want. Means always overwrite EC and VID headers, in order to 
> let UBI to re-erase this block just because of this block contains my filling data (resulting from one power-cut after filling pages).
> Otherwise, for the next boot, during attach stage, UBIFS will consider this block to be a corrupted block.
> 
> let me take one example, eg, the last programmed page is page8, and after the filling pages, 
> before mtd->_erase, power-cut hits, so in this block, there will be below data layout, 
> 
> Page0 : EC header
> Page1: VID header
> Page2: not empty, valid data 
> Page3: not empty, valid data
> Page4: not empty, valid data
> Page5: not empty, valid data
> Page6: not empty, valid data
> Page7: not empty, valid data
> Page8: not empty, valid data
> 
> Page9: filled with padding data by the patch
> Page10: empty, keep all 0xff
> Page11: filled with padding data by the patch
> Page12: empty, keep all 0xff
> Page13: filled with padding data by the patch
> 
> As for the older UBIFS (eg, v4.2), there will result in attach failure, but for the latest
> UBIFS, if I don't overwrite EC and VID header, will this condition happen?

Sorry I didn't make myself clear. It is perfectly fine to kill both EC and VID headers.
This is actually what we want.

Thanks,
//richard

  reply	other threads:[~2018-12-19 18:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 11:03 [PATCH V1] mtd: core: Micron SLC NAND filling block Bean Huo (beanhuo)
2018-12-19 13:17 ` Boris Brezillon
2018-12-19 13:59   ` [EXT] " Zoltan Szubbocsev (zszubbocsev)
2018-12-19 14:17     ` Miquel Raynal
2018-12-19 17:19       ` Bean Huo (beanhuo)
2018-12-19 18:31         ` Richard Weinberger
2018-12-19 18:46         ` Boris Brezillon
2018-12-19 14:27 ` Richard Weinberger
2018-12-19 18:11   ` [EXT] " Bean Huo (beanhuo)
2018-12-19 18:28     ` Richard Weinberger [this message]
2018-12-19 18:44     ` Boris Brezillon
2018-12-19 22:29     ` Thomas Gleixner
2019-01-02 13:34       ` Bean Huo (beanhuo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1664708.GA0Z09RGF1@blindfold \
    --to=richard@nod.at \
    --cc=beanhuo@micron.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=tglx@linutronix.de \
    --cc=zszubbocsev@micron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.