From: patchwork-bot+netdevbpf@kernel.org
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: santosh.shilimkar@oracle.com, davem@davemloft.net,
sowmini.varadhan@oracle.com, hdanton@sina.com,
syzkaller-bugs@googlegroups.com,
syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
Date: Mon, 03 Oct 2022 07:00:15 +0000 [thread overview]
Message-ID: <166478041523.16664.6828494970350493146.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <3de97b2d-1c15-5dda-4fe2-78311a91d861@I-love.SAKURA.ne.jp>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 29 Sep 2022 00:25:37 +0900 you wrote:
> syzbot is reporting lockdep warning at rds_tcp_reset_callbacks() [1], for
> commit ac3615e7f3cffe2a ("RDS: TCP: Reduce code duplication in
> rds_tcp_reset_callbacks()") added cancel_delayed_work_sync() into a section
> protected by lock_sock() without realizing that rds_send_xmit() might call
> lock_sock().
>
> We don't need to protect cancel_delayed_work_sync() using lock_sock(), for
> even if rds_{send,recv}_worker() re-queued this work while __flush_work()
> from cancel_delayed_work_sync() was waiting for this work to complete,
> retried rds_{send,recv}_worker() is no-op due to the absence of RDS_CONN_UP
> bit.
>
> [...]
Here is the summary with links:
- net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
https://git.kernel.org/netdev/net/c/a91b750fd662
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-10-03 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 5:34 [syzbot] possible deadlock in rds_tcp_reset_callbacks syzbot
2022-09-28 15:25 ` [PATCH] net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks() Tetsuo Handa
2022-10-03 7:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166478041523.16664.6828494970350493146.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=hdanton@sina.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
--cc=syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.