All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	kernel-team@fb.com, quentin@isovalent.com,
	andrea.terzolo@polito.it
Subject: Re: [PATCH v2 bpf-next 1/2] bpf: explicitly define BPF_FUNC_xxx integer values
Date: Thu, 06 Oct 2022 15:30:16 +0000	[thread overview]
Message-ID: <166507021639.23640.5377002138284115237.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221006042452.2089843-1-andrii@kernel.org>

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 5 Oct 2022 21:24:51 -0700 you wrote:
> Historically enum bpf_func_id's BPF_FUNC_xxx enumerators relied on
> implicit sequential values being assigned by compiler. This is
> convenient, as new BPF helpers are always added at the very end, but it
> also has its downsides, some of them being:
> 
>   - with over 200 helpers now it's very hard to know what's each helper's ID,
>     which is often important to know when working with BPF assembly (e.g.,
>     by dumping raw bpf assembly instructions with llvm-objdump -d
>     command). it's possible to work around this by looking into vmlinux.h,
>     dumping /sys/btf/kernel/vmlinux, looking at libbpf-provided
>     bpf_helper_defs.h, etc. But it always feels like an unnecessary step
>     and one should be able to quickly figure this out from UAPI header.
> 
> [...]

Here is the summary with links:
  - [v2,bpf-next,1/2] bpf: explicitly define BPF_FUNC_xxx integer values
    https://git.kernel.org/bpf/bpf-next/c/8a76145a2ec2
  - [v2,bpf-next,2/2] scripts/bpf_doc.py: update logic to not assume sequential enum values
    https://git.kernel.org/bpf/bpf-next/c/ce3e44a09dce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-10-06 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06  4:24 [PATCH v2 bpf-next 1/2] bpf: explicitly define BPF_FUNC_xxx integer values Andrii Nakryiko
2022-10-06  4:24 ` [PATCH v2 bpf-next 2/2] scripts/bpf_doc.py: update logic to not assume sequential enum values Andrii Nakryiko
2022-10-06  9:40   ` Quentin Monnet
2022-10-06  4:29 ` [PATCH v2 bpf-next 1/2] bpf: explicitly define BPF_FUNC_xxx integer values Andrii Nakryiko
2022-10-06  9:40 ` Quentin Monnet
2022-10-06 10:45 ` Jiri Olsa
2022-10-06 11:27 ` Toke Høiland-Jørgensen
2022-10-06 15:30 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166507021639.23640.5377002138284115237.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrea.terzolo@polito.it \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=quentin@isovalent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.