From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pOaKC-0004BR-Fh for mharc-grub-devel@gnu.org; Sun, 05 Feb 2023 03:24:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOaKA-0004Ac-I0 for grub-devel@gnu.org; Sun, 05 Feb 2023 03:24:34 -0500 Received: from mout.gmx.net ([212.227.15.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOaK8-0006Fi-SY for grub-devel@gnu.org; Sun, 05 Feb 2023 03:24:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675585466; bh=4upZmtAAA3xQXZjkiX/h0xNp8KDFn7bjXJ46EvVWSBE=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=oFDaeDUUpkBU2CWXoNsYTsrXMMx8a7LsmDjdhgPKipfB78CXFfN4o2FpptLM74iiL ToWnh5SltCKv4IElppGr0ie9OInyvcj9WKfd/lVlid3J2S77EmWg2xEEuMXtL20jKy S2o12hBMQP2bEpxzxqsSAP6zpI3E1JAxKRdVIezaumQba6oONIRAo1VY/3+57BYqvY GVFRaKLB9WyoEIkh6I3g18CMj2osgEwPePypV2lzDolgB0qnUHSv4xvBSLhahX12PG Gr0OtTiUfGX64f9V8d8VMPZndNRlOtkJRldPynUWHIPRQSr8+6Xo8pDNGa/pQgQuF+ huLEPad6nWkBw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.243.254]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MK3Rs-1p34OV3av8-00LTWX; Sun, 05 Feb 2023 09:24:25 +0100 Date: Sun, 05 Feb 2023 09:24:21 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH] tests: Add pathological iso9660 filesystem tests Content-Type: text/plain; charset="utf-8" Cc: daniel.kiper@oracle.com,development@efficientek.com References: <20230205002831.1940679-1-development@efficientek.com> In-Reply-To: <20230205002831.1940679-1-development@efficientek.com> Message-Id: <16652393890953890042@scdbackup.webframe.org> X-Provags-ID: V03:K1:C170KzEJ4N0MasuTTASuFn4KGY0kSFZQ7eG4UraEPxxm6QAdfwv 1Q4mbPXNsi0c47fXTUCMFld2uAwiiYBu0HP8t3EXG3DPFfozftkcg9smMGrm91w5pB0Yqmv s178oxQIDDDw0qnsTTBczpRTXJvzd6o/Kf0CSxFC3zJlqgy7vwJQDy/bLIUOpLSF4ixmhj8 LUwQtAtDSsId+N+tedFMA== UI-OutboundReport: notjunk:1;M01:P0:oEaqOvsgfQU=;Mf0IaQ/VgC/+p0QD2wK1LoCzDpp ELgJWOIVSStwlw9FfqNai2o8DljJpTxXVEG5NSEPJ/xvxNtU+hfBiLysKT0pat5jxlyPtRNer i4ypZdzVfuBQp1E0HvyvIs2Zf4rieBYG2DwOUrzXnvLMkLk3YsrUEb/ZeA5TDB7vWs8/elN4V pcaSQEdR4aL9/2VL0cwuLyzSQvIrXKWvCu4hEcmXpOlT9UQzU2jDg0MC1gmmb5tbLZrHDDNeH WzAZYnLvcUIP4NGhi76jI369/flzMyH2pfOGwiA8unWeKf0rJJvLMyAc7gizuo5XdWejzNV7P 3bY5Qjr2oWqZ3olGCnvWnPhyeOSz8vrVGt1AL8sM+GDslLRUz05Pqu8WGDneOWNldAdyy6wZ7 dtmlfSjwInwTOOFtCTKdYTDAaTNtn488xr5MPT/tgjrjLGdgDaZ0nmChm2j0S7Z4PI2viQ2Po z55r9/YqnnOnKd8cqRkLMV1ZugSKOF2MVKRf+5jBI/i5yqVHg+8K92mkQu5P9xcDYskfEarDm I9WwC7230vEHchhOoY/dX4NlmnYxWh9xSrlTkg+PO91vJWdkw9HtaC8KQ4Dj/iJdvvS1PMt5K hNsHgqj68rmiyIG4D7m2Agvf3PAhAkKCTwvKLrd00DcyM0KU1B0tHNmYHSNVFjB4fiIwA7uIb gZbAzeT0A9OcJrpsCEsXJ3LBQIdnDTnF8f4aOPG4ItQ45yGafVicblicKpQ/q01UFY0bnTibt ExL4yXIrYGwBxzWYWkUWcYd1cZRjoDwfh3PkEiiZK++DZQ++cDUmB8o8Bq6iBIKaQx5sJNMTI ghe7ZTANbGgsi1/t9XWMp6k3tLyxR5+9ZG28WdwH2x2jpnS03h79R+2kJvB+hSXru+d6X18E5 ZlVQ0pE8psAAiPLZovloI/65lKdGoMrQmJTGkfUOleQUq6yyCZfd85pkW5WefEO4T1bSGB0hU CDtqonqPbN+26L2VUnhiU4+MMcQ= Received-SPF: pass client-ip=212.227.15.15; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2023 08:24:34 -0000 Hi, Glenn Washburn wrote: > --- a/tests/iso9660_test.in > +++ b/tests/iso9660_test.in > @@ -12,4 +12,13 @@ fi > "@builddir@/grub-fs-tester" rockridge_joliet > "@builddir@/grub-fs-tester" joliet_1999 > "@builddir@/grub-fs-tester" rockridge_1999 > -"@builddir@/grub-fs-tester" rockridge_joliet_1999 > \ No newline at end of file > +"@builddir@/grub-fs-tester" rockridge_joliet_1999 > + > +for fs in iso9660_ce_loop iso9660_ce_loop2; do > + tempdir=`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date > '+%Y%m%d%H%M%S%N').${fs}.XXX"` || > + { echo "Failed to make temporary directory"; exit 99; } > + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso" > + output=$(LC_ALL=C timeout -s KILL "60" \ > + "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / ) > + test "$?" -eq 0 -a -z "$output" > +done Shouldn't the decompressed files and the temporary directory be removed afterwards ? Have a nice day :) Thomas