From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA35C433FE for ; Thu, 13 Oct 2022 13:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbiJMNSn (ORCPT ); Thu, 13 Oct 2022 09:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbiJMNSg (ORCPT ); Thu, 13 Oct 2022 09:18:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E26E012FF89 for ; Thu, 13 Oct 2022 06:18:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66671617A7 for ; Thu, 13 Oct 2022 13:18:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E2C9C433D6; Thu, 13 Oct 2022 13:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665667101; bh=u0r/emeG1onKEVgDAm2kfO1iKl2rk2ZSCQTFuKotjpk=; h=Subject:To:Cc:From:Date:From; b=nNSc7nJPF5+bP1vSgZ2ud20wGdXTWur9sb+KIpd5VDaNGJLaZ9W/9ruxDfbSStUn7 bEfKffEWSjsr6OxG5bpL5av5FpL7tDdKmTkr3muEbFy8mHQ4zMdHYGEDkbH74pbg8F fNappASf5gczb30wnioJ0ZvEh6b7Nog1QezXmTsc= Subject: WTF: patch "[PATCH] scsi: qla2xxx: Define static symbols" was seriously submitted to be applied to the 6.0-stable tree? To: njavali@marvell.com, himanshu.madhani@oracle.com, lkp@intel.com, martin.petersen@oracle.com Cc: From: Date: Thu, 13 Oct 2022 15:12:41 +0200 Message-ID: <166566676115205@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below was submitted to be applied to the 6.0-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst. I could be totally wrong, and if so, please respond to and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 2c57d0defa22b2339c06364a275bcc9048a77255 Mon Sep 17 00:00:00 2001 From: Nilesh Javali Date: Fri, 26 Aug 2022 03:25:58 -0700 Subject: [PATCH] scsi: qla2xxx: Define static symbols drivers/scsi/qla2xxx/qla_os.c:40:20: warning: symbol 'qla_trc_array' was not declared. Should it be static? drivers/scsi/qla2xxx/qla_os.c:345:5: warning: symbol 'ql2xdelay_before_pci_error_handling' was not declared. Should it be static? Define qla_trc_array and ql2xdelay_before_pci_error_handling as static to fix sparse warnings. Link: https://lore.kernel.org/r/20220826102559.17474-7-njavali@marvell.com Cc: stable@vger.kernel.org Reported-by: kernel test robot Reviewed-by: Himanshu Madhani Signed-off-by: Nilesh Javali Signed-off-by: Martin K. Petersen diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index f76ae8a64ea9..0ccaeea4e1bd 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -37,7 +37,7 @@ static int apidev_major; */ struct kmem_cache *srb_cachep; -struct trace_array *qla_trc_array; +static struct trace_array *qla_trc_array; int ql2xfulldump_on_mpifail; module_param(ql2xfulldump_on_mpifail, int, S_IRUGO | S_IWUSR); @@ -342,7 +342,7 @@ MODULE_PARM_DESC(ql2xabts_wait_nvme, "To wait for ABTS response on I/O timeouts for NVMe. (default: 1)"); -u32 ql2xdelay_before_pci_error_handling = 5; +static u32 ql2xdelay_before_pci_error_handling = 5; module_param(ql2xdelay_before_pci_error_handling, uint, 0644); MODULE_PARM_DESC(ql2xdelay_before_pci_error_handling, "Number of seconds delayed before qla begin PCI error self-handling (default: 5).\n");