All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: use kmem_cache for translation table
Date: Sat, 25 Jun 2016 17:46:47 +0200	[thread overview]
Message-ID: <1666680.Y9BoZfK7nu@sven-edge> (raw)
In-Reply-To: <1466865846-32621-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On Saturday 25 June 2016 16:44:06 Sven Eckelmann wrote:
> The translation table (global, local) is usually the part of batman-adv
> which has the most dynamical allocated objects. Most of them
> (tt_local_entry, tt_global_entry, tt_orig_list_entry, tt_change_node,
> tt_req_node, tt_roam_node) are equally sized. So it makes sense to have
> them allocated from a kmem_cache for each type.
> 
> This approach allowed a small wireless router (TP-Link TL-841NDv8; SLUB
> allocator) to store 34% more translation table entries compared to the
> current implementation.
> 
> [1] https://open-mesh.org/projects/batman-adv/wiki/Kmalloc-kmem-cache-tests
> 
> Reported-by: Linus Lüssing <linus.luessing@c0d3.blue>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---

Here is the changelog (since the RFC):

v2:
 - use kmem_cache_zalloc instead of kmem_cache_alloc + memset as
   suggested by Linus
 - add cache batadv_tt_change_cache, batadv_tt_req_cache,
   batadv_tt_roam_cache
 - Added Reported-by
 - rewrote commit message
 - summarize+link the results from Linus' tests

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-25 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25 14:44 [B.A.T.M.A.N.] [PATCH v2] batman-adv: use kmem_cache for translation table Sven Eckelmann
2016-06-25 15:46 ` Sven Eckelmann [this message]
2016-06-27  4:02   ` Linus Lüssing
2016-06-27  6:09     ` Sven Eckelmann
2016-06-28 15:40       ` Linus Lüssing
2016-07-08  9:53 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1666680.Y9BoZfK7nu@sven-edge \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.