Re: [dpdk-dev] [PATCH] test/table: skip when not enough memory is available

[Thomas Monjalon <thomas@monjalon.net>]

Hi,

05/07/2019 19:54, Dumitrescu, Cristian:
> From: David Marchand [mailto:david.marchand@redhat.com]
> > Following empirical tries, this test wants at least 3300M of memory to
> > run.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Yes, some tests need large amounts of memory.

Basic tests should not.

> I understand your proposal, but it feels
> a bit like a hack for this test.

Of course it is a hack, probably on purpose to show the issue :)

> Could we create a more generic fix?
> 
> Expanding on your idea, could we wrap this code
> into a macro such as TEST_CHECK_FOR_LARGE_MEMORY(memsize_in_gb)
> that could live in test.h and call it for this test
> (and potentially others that have the same requirements)?

I don't see what it would improve.

> Or maybe people have a better idea?

Yes, a better idea is to reduce the requirements.
Requiring more than 3GB for a unit test is not reasonnable.
If you want to stress the algorithm, then it is a performance test,
and it won't be launched on basic CI.

So there are 2 proposals here:
	- use small memory amount
	- classify as perf test
Please choose one of these two, but neither the hack above,
nor a macro to hide the hack.
Thanks