From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6EEFA3741 for ; Mon, 31 Oct 2022 06:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229469AbiJaGOZ (ORCPT ); Mon, 31 Oct 2022 02:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiJaGOY (ORCPT ); Mon, 31 Oct 2022 02:14:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9E9CB2D for ; Sun, 30 Oct 2022 23:14:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 653E360FC6 for ; Mon, 31 Oct 2022 06:14:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77B71C433D6; Mon, 31 Oct 2022 06:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667196862; bh=QASxdIkaFv1HLt+yORaNACAla7GWMENaqdb02+2yD4Q=; h=Subject:To:Cc:From:Date:From; b=iDi3XMlaNMYF140y2f/ay/YoQkohcofv98+i4W20V+8V1mbhzcTVAMWR9rWtI3abJ ZgAJnanMh0jlGL8hnswIXJSLDdK+urLxFFp8PKsd6z8b6qtvGMLrJ9fYb86h/OdSLM 9oPqc0xzkVzeVgs5EQhk5JEmwdt8Lv2qSZrTD5bU= Subject: FAILED: patch "[PATCH] exec: Copy oldsighand->action under spin-lock" failed to apply to 4.14-stable tree To: bernd.edlinger@hotmail.de, keescook@chromium.org Cc: From: Date: Mon, 31 Oct 2022 07:15:16 +0100 Message-ID: <1667196916115182@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Possible dependencies: 5bf2fedca8f5 ("exec: Copy oldsighand->action under spin-lock") 021691559245 ("exec: Factor unshare_sighand out of de_thread and call it separately") d036bda7d0e7 ("sched/core: Convert sighand_struct.count to refcount_t") 06e62a46bbba ("fork: don't copy inconsistent signal handler state to child") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5bf2fedca8f59379025b0d52f917b9ddb9bfe17e Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Mon, 7 Jun 2021 15:54:27 +0200 Subject: [PATCH] exec: Copy oldsighand->action under spin-lock unshare_sighand should only access oldsighand->action while holding oldsighand->siglock, to make sure that newsighand->action is in a consistent state. Signed-off-by: Bernd Edlinger Cc: stable@vger.kernel.org Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/AM8PR10MB470871DEBD1DED081F9CC391E4389@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM diff --git a/fs/exec.c b/fs/exec.c index 349a5da91efe..32dc8cf5fceb 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1197,11 +1197,11 @@ static int unshare_sighand(struct task_struct *me) return -ENOMEM; refcount_set(&newsighand->count, 1); - memcpy(newsighand->action, oldsighand->action, - sizeof(newsighand->action)); write_lock_irq(&tasklist_lock); spin_lock(&oldsighand->siglock); + memcpy(newsighand->action, oldsighand->action, + sizeof(newsighand->action)); rcu_assign_pointer(me->sighand, newsighand); spin_unlock(&oldsighand->siglock); write_unlock_irq(&tasklist_lock);