From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Date: Thu, 19 Nov 2015 05:57:02 +0100 Message-ID: <1668139.HQCaUDeMrM@phil> References: <1445599528-18825-1-git-send-email-wxt@rock-chips.com> <2741625.HAsG2fX6yg@diego> <564D3772.9050402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <564D3772.9050402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang Cc: Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Russell King , Pawel Moll , Ian Campbell , Dmitry Torokhov , Doug Anderson , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Rob Herring , Kumar Gala , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Caesar Wang List-Id: linux-rockchip.vger.kernel.org SGkgQ2Flc2FyLAoKQW0gRG9ubmVyc3RhZywgMTkuIE5vdmVtYmVyIDIwMTUsIDEwOjQ0OjAyIHNj aHJpZWIgQ2Flc2FyIFdhbmc6Cj4g5ZyoIDIwMTXlubQxMOaciDI15pelIDE1OjU1LCBIZWlrbyBT dMO8Ym5lciDlhpnpgZM6Cj4gPiBBbSBGcmVpdGFnLCAyMy4gT2t0b2JlciAyMDE1LCAwODoyNTow OCBzY2hyaWViIERvdWcgQW5kZXJzb246Cj4gPj4gT24gRnJpLCBPY3QgMjMsIDIwMTUgYXQgNDoy NSBBTSwgQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4gPj4+IEFkZCB0 aGUgImluaXQiIGFuZiAic2xlZXAiIHBpbmN0cmwgYXMgdGhlIE9UUCBncGlvIHN0YXRlLgo+ID4+ PiBXZSBuZWVkIHRoZSBPVFAgcGluIGlzIGdwaW8gc3RhdGUgYmVmb3JlIHJlc2V0dGluZyB0aGUg VFNBREMgY29udHJvbGxlciwKPiA+Pj4gc2luY2UgdGhlIHRzaHV0IHBvbGFyaXR5IHdpbGwgZ2Vu ZXJhdGUgYSBoaWdoIHNpZ25hbC4KPiA+Pj4KPiA+Pj4gImluaXQiIHBpbmN0cmwgcHJvcGVydHkg aXMgZGVmaW5lZCBieSBEb3VnJ3MgUGF0Y2hbMF0uCj4gPj4+Cj4gPj4+IFBhdGNoWzBdOgo+ID4+ PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzc0NTQzMTEvCj4gPj4+Cj4gPj4+ IFNpZ25lZC1vZmYtYnk6IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4gPj4+IFJl dmlld2VkLWJ5OiBEb3VnbGFzIEFuZGVyc29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4gPj4+ IC0tLQo+ID4+Pgo+ID4+PiBDaGFuZ2VzIGluIHY0OiBOb25lCj4gPj4+Cj4gPj4+IENoYW5nZXMg aW4gdjM6Cj4gPj4+ICAgIC0gQWRkIHRoZSAic2xlZXAiIHBpbmN0cmwgYXMgdGhlIGdwaW8gc3Rh dGUgaW4gUEFUQ0hbMy8zXQo+ID4+Pgo+ID4+PiBDaGFuZ2VzIGluIHYyOgo+ID4+PiAgICAtIEFk ZCBzb21lIGNvbW1pdHMgZm9yIG1vcmUgb2J2aW91cyBpbiBQQVRDSFsyLzJdCj4gPj4+Cj4gPj4+ IENoYW5nZXMgaW4gdjE6Cj4gPj4+ICAgIC0gQXMgdGhlIERvdWcgY29tbWVudHMsIGRyb3AgdGhl IHRoZXJtYWwgZHJpdmVyIHBhdGNocyBzaW5jZQo+ID4+PiAgICAKPiA+Pj4gICAgICB3ZSBjYW4g d2l0aCBwaW5jdHJsIGNoYW5naW5nIHRvIHdvcmsuCj4gPj4+ICAgIAo+ID4+PiAgICAtIEFzIHRo ZSBEb3VnJ3MgcGF0Y2ggdG8gYWRkIHRoZSAnaW5pdCcgcHJvcGVydHkuCj4gPj4+ICAgCj4gPj4+ ICAgYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LmR0c2kgfCAxMCArKysrKysrKy0tCj4gPj4+ICAg MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+PiBJIHJl YWxpemVkIHRoYXQgdGhlIHN1YmplY3Qgb2YgdGhpcyBwYXRjaCBzaG91bGQgcHJvYmFibHkgY29u dGFpbiB0aGUKPiA+PiB3b3JkIHJrMzI4OCwgYnV0IEkgcHJlc3VtZSBIZWlrbyB3b3VsZCByYXRo ZXIgYWRkIHRoYXQgaGltc2VsZiB0aGFuCj4gPj4gZm9yIHlvdSB0byBzcGluIHRoaXMgYWdhaW4u ICA7KQo+ID4geWVwIDotKSAuLi4gbm8gbmVlZCB0byByZXNwaW4gZm9yIHN1Y2ggYW4gZWFzeSBj aGFuZ2UKPiAKPiBUaGF0J3Mgc2VlbSB0aGlzIHBhdGNoIGRpZG4ndCBtZXJnZSBpbnRvIHlvdXIg djQuNS1hcm1zb2Mvc29jIGJyYW5jaC46LSkKPiAKPiBJIGd1ZXNzIHRoaXMgcGF0Y2ggc2hvdWxk IG1lcmdlIGludG8gIGtlcm5lbC00LjQgc2luY2UgdGhlIFBhdGNoWzEvM10gLyAKPiBbMi8zXSBo YXZlIGJlZW4gbWVyZ2VkIGludG8gNC40LXJjMS46LVAKCnRoYW5rcyBmb3IgdGhlIHJlbWluZGVy IDotKQoKSXQgc2VlbXMgSSBkaWRuJ3QgZ2V0IGEgbm90aWNlIHdoZW4gdGhlIGNvcmUgdGhlcm1h bCBjaGFuZ2VzIHdlcmUgbWVyZ2VkLCBzbyAKdGhpcyBwYXRjaCBzZWVtcyB0byBoYXZlIGRyb3Bw ZWQgb2YgbXkgcmFkYXIuIEl0IGlzIGNsZWFybHkgYSBmaXggZm9yIGEgcmVhbCAKaXNzdWUsIHNv IEkndmUgYWRkZWQgaXQgdG8gbXkgZml4ZXMgYnJhbmNoIGZvciA0LjQuCgoKSGVpa28KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlw IG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 19 Nov 2015 05:57:02 +0100 Subject: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl In-Reply-To: <564D3772.9050402@gmail.com> References: <1445599528-18825-1-git-send-email-wxt@rock-chips.com> <2741625.HAsG2fX6yg@diego> <564D3772.9050402@gmail.com> Message-ID: <1668139.HQCaUDeMrM@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Caesar, Am Donnerstag, 19. November 2015, 10:44:02 schrieb Caesar Wang: > ? 2015?10?25? 15:55, Heiko St?bner ??: > > Am Freitag, 23. Oktober 2015, 08:25:08 schrieb Doug Anderson: > >> On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang wrote: > >>> Add the "init" anf "sleep" pinctrl as the OTP gpio state. > >>> We need the OTP pin is gpio state before resetting the TSADC controller, > >>> since the tshut polarity will generate a high signal. > >>> > >>> "init" pinctrl property is defined by Doug's Patch[0]. > >>> > >>> Patch[0]: > >>> https://patchwork.kernel.org/patch/7454311/ > >>> > >>> Signed-off-by: Caesar Wang > >>> Reviewed-by: Douglas Anderson > >>> --- > >>> > >>> Changes in v4: None > >>> > >>> Changes in v3: > >>> - Add the "sleep" pinctrl as the gpio state in PATCH[3/3] > >>> > >>> Changes in v2: > >>> - Add some commits for more obvious in PATCH[2/2] > >>> > >>> Changes in v1: > >>> - As the Doug comments, drop the thermal driver patchs since > >>> > >>> we can with pinctrl changing to work. > >>> > >>> - As the Doug's patch to add the 'init' property. > >>> > >>> arch/arm/boot/dts/rk3288.dtsi | 10 ++++++++-- > >>> 1 file changed, 8 insertions(+), 2 deletions(-) > >> I realized that the subject of this patch should probably contain the > >> word rk3288, but I presume Heiko would rather add that himself than > >> for you to spin this again. ;) > > yep :-) ... no need to respin for such an easy change > > That's seem this patch didn't merge into your v4.5-armsoc/soc branch.:-) > > I guess this patch should merge into kernel-4.4 since the Patch[1/3] / > [2/3] have been merged into 4.4-rc1.:-P thanks for the reminder :-) It seems I didn't get a notice when the core thermal changes were merged, so this patch seems to have dropped of my radar. It is clearly a fix for a real issue, so I've added it to my fixes branch for 4.4. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757609AbbKSE5V (ORCPT ); Wed, 18 Nov 2015 23:57:21 -0500 Received: from gloria.sntech.de ([95.129.55.99]:59960 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbbKSE5T convert rfc822-to-8bit (ORCPT ); Wed, 18 Nov 2015 23:57:19 -0500 From: Heiko Stuebner To: Caesar Wang Cc: Doug Anderson , Mark Rutland , "devicetree@vger.kernel.org" , Russell King , Pawel Moll , Ian Campbell , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Rob Herring , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , Caesar Wang Subject: Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Date: Thu, 19 Nov 2015 05:57:02 +0100 Message-ID: <1668139.HQCaUDeMrM@phil> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <564D3772.9050402@gmail.com> References: <1445599528-18825-1-git-send-email-wxt@rock-chips.com> <2741625.HAsG2fX6yg@diego> <564D3772.9050402@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, Am Donnerstag, 19. November 2015, 10:44:02 schrieb Caesar Wang: > 在 2015年10月25日 15:55, Heiko Stübner 写道: > > Am Freitag, 23. Oktober 2015, 08:25:08 schrieb Doug Anderson: > >> On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang wrote: > >>> Add the "init" anf "sleep" pinctrl as the OTP gpio state. > >>> We need the OTP pin is gpio state before resetting the TSADC controller, > >>> since the tshut polarity will generate a high signal. > >>> > >>> "init" pinctrl property is defined by Doug's Patch[0]. > >>> > >>> Patch[0]: > >>> https://patchwork.kernel.org/patch/7454311/ > >>> > >>> Signed-off-by: Caesar Wang > >>> Reviewed-by: Douglas Anderson > >>> --- > >>> > >>> Changes in v4: None > >>> > >>> Changes in v3: > >>> - Add the "sleep" pinctrl as the gpio state in PATCH[3/3] > >>> > >>> Changes in v2: > >>> - Add some commits for more obvious in PATCH[2/2] > >>> > >>> Changes in v1: > >>> - As the Doug comments, drop the thermal driver patchs since > >>> > >>> we can with pinctrl changing to work. > >>> > >>> - As the Doug's patch to add the 'init' property. > >>> > >>> arch/arm/boot/dts/rk3288.dtsi | 10 ++++++++-- > >>> 1 file changed, 8 insertions(+), 2 deletions(-) > >> I realized that the subject of this patch should probably contain the > >> word rk3288, but I presume Heiko would rather add that himself than > >> for you to spin this again. ;) > > yep :-) ... no need to respin for such an easy change > > That's seem this patch didn't merge into your v4.5-armsoc/soc branch.:-) > > I guess this patch should merge into kernel-4.4 since the Patch[1/3] / > [2/3] have been merged into 4.4-rc1.:-P thanks for the reminder :-) It seems I didn't get a notice when the core thermal changes were merged, so this patch seems to have dropped of my radar. It is clearly a fix for a real issue, so I've added it to my fixes branch for 4.4. Heiko