From: patchwork-bot+bluetooth@kernel.org
To: Sungwoo Kim <iam@sung-woo.kim>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: L2CAP: Fix u8 overflow
Date: Tue, 22 Nov 2022 00:50:15 +0000 [thread overview]
Message-ID: <166907821592.6181.15285782519233443066.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221118200145.1741199-1-iam@sung-woo.kim>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Fri, 18 Nov 2022 15:01:47 -0500 you wrote:
> By keep sending L2CAP_CONF_REQ packets, chan->num_conf_rsp increases
> multiple times and eventually it will wrap around the maximum number
> (i.e., 255).
> This patch prevents this by adding a boundary check with
> L2CAP_MAX_CONF_RSP
>
> Btmon log:
> Bluetooth monitor ver 5.64
> = Note: Linux version 6.1.0-rc2 (x86_64) 0.264594
> = Note: Bluetooth subsystem version 2.22 0.264636
> @ MGMT Open: btmon (privileged) version 1.22 {0x0001} 0.272191
> = New Index: 00:00:00:00:00:00 (Primary,Virtual,hci0) [hci0] 13.877604
> @ RAW Open: 9496 (privileged) version 2.22 {0x0002} 13.890741
> = Open Index: 00:00:00:00:00:00 [hci0] 13.900426
> (...)
> > ACL Data RX: Handle 200 flags 0x00 dlen 1033 #32 [hci0] 14.273106
> invalid packet size (12 != 1033)
> 08 00 01 00 02 01 04 00 01 10 ff ff ............
> > ACL Data RX: Handle 200 flags 0x00 dlen 1547 #33 [hci0] 14.273561
> invalid packet size (14 != 1547)
> 0a 00 01 00 04 01 06 00 40 00 00 00 00 00 ........@.....
> > ACL Data RX: Handle 200 flags 0x00 dlen 2061 #34 [hci0] 14.274390
> invalid packet size (16 != 2061)
> 0c 00 01 00 04 01 08 00 40 00 00 00 00 00 00 04 ........@.......
> > ACL Data RX: Handle 200 flags 0x00 dlen 2061 #35 [hci0] 14.274932
> invalid packet size (16 != 2061)
> 0c 00 01 00 04 01 08 00 40 00 00 00 07 00 03 00 ........@.......
> = bluetoothd: Bluetooth daemon 5.43 14.401828
> > ACL Data RX: Handle 200 flags 0x00 dlen 1033 #36 [hci0] 14.275753
> invalid packet size (12 != 1033)
> 08 00 01 00 04 01 04 00 40 00 00 00 ........@...
>
> [...]
Here is the summary with links:
- Bluetooth: L2CAP: Fix u8 overflow
https://git.kernel.org/bluetooth/bluetooth-next/c/ae4569813a6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-11-22 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 20:01 [PATCH] Bluetooth: L2CAP: Fix u8 overflow Sungwoo Kim
2022-11-19 3:07 ` bluez.test.bot
2022-11-19 4:36 ` bluez.test.bot
2022-11-19 5:29 ` bluez.test.bot
2022-11-22 0:50 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166907821592.6181.15285782519233443066.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=iam@sung-woo.kim \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.